lib: fix build for missing RCU library dependency
diff mbox series

Message ID 20200713135120.3230675-1-ferruh.yigit@intel.com
State Accepted
Delegated to: David Marchand
Headers show
Series
  • lib: fix build for missing RCU library dependency
Related show

Checks

Context Check Description
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed
ci/checkpatch success coding style OK

Commit Message

Ferruh Yigit July 13, 2020, 1:51 p.m. UTC
'librte_rcu' is now dependency to 'librte_lpm' library, this dependency
should be reflected to build system.

Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: ruifeng.wang@arm.com
---
 lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ruifeng Wang July 13, 2020, 3:46 p.m. UTC | #1
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, July 13, 2020 9:51 PM
> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; Vladimir Medvedkin
> <vladimir.medvedkin@intel.com>; Ray Kinsella <mdr@ashroe.eu>
> Cc: dev@dpdk.org; Ferruh Yigit <ferruh.yigit@intel.com>
> Subject: [PATCH] lib: fix build for missing RCU library dependency
> 
> 'librte_rcu' is now dependency to 'librte_lpm' library, this dependency should
> be reflected to build system.
> 
> Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: ruifeng.wang@arm.com
Hi Ferruh,

Thanks for fixing this.
Although I didn't reproduce the building issue, this patch is obviously valid.

Regards.
/Ruifeng

Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
>  lib/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/Makefile b/lib/Makefile index 4b981f505e..8f5b68a2d4 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -59,7 +59,7 @@ DEPDIRS-librte_rib := librte_eal librte_mempool
>  DIRS-$(CONFIG_RTE_LIBRTE_FIB) += librte_fib  DEPDIRS-librte_fib :=
> librte_eal librte_rib
>  DIRS-$(CONFIG_RTE_LIBRTE_LPM) += librte_lpm -DEPDIRS-librte_lpm :=
> librte_eal librte_hash
> +DEPDIRS-librte_lpm := librte_eal librte_hash librte_rcu
>  DIRS-$(CONFIG_RTE_LIBRTE_ACL) += librte_acl  DEPDIRS-librte_acl :=
> librte_eal
>  DIRS-$(CONFIG_RTE_LIBRTE_MEMBER) += librte_member
> --
> 2.25.4
Kinsella, Ray July 14, 2020, 11:20 a.m. UTC | #2
On 13/07/2020 16:46, Ruifeng Wang wrote:
> 
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Monday, July 13, 2020 9:51 PM
>> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
>> <Ruifeng.Wang@arm.com>; Vladimir Medvedkin
>> <vladimir.medvedkin@intel.com>; Ray Kinsella <mdr@ashroe.eu>
>> Cc: dev@dpdk.org; Ferruh Yigit <ferruh.yigit@intel.com>
>> Subject: [PATCH] lib: fix build for missing RCU library dependency
>>
>> 'librte_rcu' is now dependency to 'librte_lpm' library, this dependency should
>> be reflected to build system.
>>
>> Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Cc: ruifeng.wang@arm.com
> Hi Ferruh,
> 
> Thanks for fixing this.
> Although I didn't reproduce the building issue, this patch is obviously valid.
> 
> Regards.
> /Ruifeng
> 
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

Was already there for meson/ninja.

Acked-by: Ray Kinsella <mdr@ashroe.eu>

>> ---
>>  lib/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/Makefile b/lib/Makefile index 4b981f505e..8f5b68a2d4 100644
>> --- a/lib/Makefile
>> +++ b/lib/Makefile
>> @@ -59,7 +59,7 @@ DEPDIRS-librte_rib := librte_eal librte_mempool
>>  DIRS-$(CONFIG_RTE_LIBRTE_FIB) += librte_fib  DEPDIRS-librte_fib :=
>> librte_eal librte_rib
>>  DIRS-$(CONFIG_RTE_LIBRTE_LPM) += librte_lpm -DEPDIRS-librte_lpm :=
>> librte_eal librte_hash
>> +DEPDIRS-librte_lpm := librte_eal librte_hash librte_rcu
>>  DIRS-$(CONFIG_RTE_LIBRTE_ACL) += librte_acl  DEPDIRS-librte_acl :=
>> librte_eal
>>  DIRS-$(CONFIG_RTE_LIBRTE_MEMBER) += librte_member
>> --
>> 2.25.4
>
David Marchand July 15, 2020, 11:16 a.m. UTC | #3
On Mon, Jul 13, 2020 at 3:51 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> 'librte_rcu' is now dependency to 'librte_lpm' library, this dependency
> should be reflected to build system.

Good catch, thanks Ferruh.

> Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Acked-by: Ray Kinsella <mdr@ashroe.eu>

Applied.

Patch
diff mbox series

diff --git a/lib/Makefile b/lib/Makefile
index 4b981f505e..8f5b68a2d4 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -59,7 +59,7 @@  DEPDIRS-librte_rib := librte_eal librte_mempool
 DIRS-$(CONFIG_RTE_LIBRTE_FIB) += librte_fib
 DEPDIRS-librte_fib := librte_eal librte_rib
 DIRS-$(CONFIG_RTE_LIBRTE_LPM) += librte_lpm
-DEPDIRS-librte_lpm := librte_eal librte_hash
+DEPDIRS-librte_lpm := librte_eal librte_hash librte_rcu
 DIRS-$(CONFIG_RTE_LIBRTE_ACL) += librte_acl
 DEPDIRS-librte_acl := librte_eal
 DIRS-$(CONFIG_RTE_LIBRTE_MEMBER) += librte_member