[v8,12/24] examples/ipsec-secgw: new link status print format
diff mbox series

Message ID 20200711104414.15422-13-i.dyukov@samsung.com
State Superseded
Delegated to: Ferruh Yigit
Headers show
Series
  • ethdev: allow unknown link speed
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Ivan Dyukov July 11, 2020, 10:43 a.m. UTC
Add usage of rte_eth_link_to_str function to example
applications

Signed-off-by: Ivan Dyukov <i.dyukov@samsung.com>
---
 examples/ipsec-secgw/ipsec-secgw.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

Comments

Ananyev, Konstantin July 13, 2020, 10:30 a.m. UTC | #1
Hi Ivan,

> Add usage of rte_eth_link_to_str function to example
> application
> 
> Signed-off-by: Ivan Dyukov <i.dyukov@samsung.com>
> ---
>  examples/ipsec-secgw/ipsec-secgw.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
> index f777ce2af..de10dfe0e 100644
> --- a/examples/ipsec-secgw/ipsec-secgw.c
> +++ b/examples/ipsec-secgw/ipsec-secgw.c
> @@ -1775,6 +1775,7 @@ check_all_ports_link_status(uint32_t port_mask)
>  	uint8_t count, all_ports_up, print_flag = 0;
>  	struct rte_eth_link link;
>  	int ret;
> +	char link_status_text[60];

Wonder where this magic number (60) came from?
Probably makes sense to have define for it,
(RTE_ETHDEV_LINK_STATUS_MAX_LEN or so),
as it seems to be used all over the places.

> 
>  	printf("\nChecking link status");
>  	fflush(stdout);
> @@ -1794,14 +1795,9 @@ check_all_ports_link_status(uint32_t port_mask)
>  			}
>  			/* print link status if flag set */
>  			if (print_flag == 1) {
> -				if (link.link_status)
> -					printf(
> -					"Port%d Link Up - speed %u Mbps -%s\n",
> -						portid, link.link_speed,
> -				(link.link_duplex == ETH_LINK_FULL_DUPLEX) ?
> -					("full-duplex") : ("half-duplex"));
> -				else
> -					printf("Port %d Link Down\n", portid);
> +				rte_eth_link_to_str(link_status_text, 60, NULL,
s/60/sizeof((link_status_text)/
?
> +						    &link);
> +				printf("Port %d %s", portid, link_status_text);
>  				continue;
>  			}
>  			/* clear all_ports_up flag if any link down */
> --
> 2.17.1

Patch
diff mbox series

diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
index f777ce2af..de10dfe0e 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -1775,6 +1775,7 @@  check_all_ports_link_status(uint32_t port_mask)
 	uint8_t count, all_ports_up, print_flag = 0;
 	struct rte_eth_link link;
 	int ret;
+	char link_status_text[60];
 
 	printf("\nChecking link status");
 	fflush(stdout);
@@ -1794,14 +1795,9 @@  check_all_ports_link_status(uint32_t port_mask)
 			}
 			/* print link status if flag set */
 			if (print_flag == 1) {
-				if (link.link_status)
-					printf(
-					"Port%d Link Up - speed %u Mbps -%s\n",
-						portid, link.link_speed,
-				(link.link_duplex == ETH_LINK_FULL_DUPLEX) ?
-					("full-duplex") : ("half-duplex"));
-				else
-					printf("Port %d Link Down\n", portid);
+				rte_eth_link_to_str(link_status_text, 60, NULL,
+						    &link);
+				printf("Port %d %s", portid, link_status_text);
 				continue;
 			}
 			/* clear all_ports_up flag if any link down */