diff mbox series

build: C++ linkage support is added to rte_service_component.h file

Message ID 20200707122516.28630-1-levendsayar@gmail.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series build: C++ linkage support is added to rte_service_component.h file |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Levend Sayar July 7, 2020, 12:25 p.m. UTC 
  From: Levend Sayar <levendsayar@gmail.com>

Signed-off-by: Levend Sayar <levendsayar@gmail.com>
---
 lib/librte_eal/include/rte_service_component.h | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

Comments

Levend Sayar July 7, 2020, 3:31 p.m. UTC | #1 
Sorry.
I thought that it does not need to have any explanation since it is obvious
as you said.
But will add an explanation right now and push again.

Thanks for your attention.

Best,
Levend

On Tue, Jul 7, 2020 at 6:01 PM Van Haaren, Harry <harry.van.haaren@intel.com>
wrote:

> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Tuesday, July 7, 2020 3:19 PM
> > To: levendsayar@gmail.com
> > Cc: dev@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com>;
> > david.marchand@redhat.com
> > Subject: Re: [PATCH] build: C++ linkage support is added to
> > rte_service_component.h file
> >
> > 07/07/2020 14:25, levendsayar@gmail.com:
> > > From: Levend Sayar <levendsayar@gmail.com>
> >
> > Would be good to have a short explanation, even if obvious.
>
> +1
>
> > > Signed-off-by: Levend Sayar <levendsayar@gmail.com>
>
> With a short description in the commit message, you can include ack in v2
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
>
> <snip patch>
>
diff mbox series

Patch

diff --git a/lib/librte_eal/include/rte_service_component.h b/lib/librte_eal/include/rte_service_component.h
index b75aba11b..c1eefae41 100644
--- a/lib/librte_eal/include/rte_service_component.h
+++ b/lib/librte_eal/include/rte_service_component.h
@@ -9,6 +9,11 @@ 
  * Include this file if you are writing a component that requires CPU cycles to
  * operate, and you wish to run the component using service cores
  */
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 #include <rte_compat.h>
 #include <rte_service.h>
 
@@ -130,4 +135,8 @@  int32_t rte_service_init(void);
  */
 void rte_service_finalize(void);
 
-#endif /* _SERVICE_PRIVATE_H_ */
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* _RTE_SERVICE_PRIVATE_H_ */