diff mbox series

log: remove unneeded log type declaration

Message ID 20200706130811.3512556-1-jerinj@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series log: remove unneeded log type declaration |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Jerin Jacob Kollanukkaran July 6, 2020, 1:08 p.m. UTC 
  From: Jerin Jacob <jerinj@marvell.com>

RTE_LOG_REGISTER macro already declares the the log type.
Remove the unneeded log type declaration.

Fixes: 9c99878aa1b16de2 ("log: introduce logtype register macro")

Reported-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/vdpa/mlx5/mlx5_vdpa.c  | 1 -
 lib/librte_graph/graph.c       | 1 -
 lib/librte_rawdev/rte_rawdev.c | 3 ---
 lib/librte_stack/rte_stack.c   | 2 --
 4 files changed, 7 deletions(-)

Comments

Eads, Gage July 6, 2020, 6:10 p.m. UTC | #1 
> Subject: [dpdk-dev] [PATCH] log: remove unneeded log type declaration
> 
> From: Jerin Jacob <jerinj@marvell.com>
> 
> RTE_LOG_REGISTER macro already declares the the log type.
> Remove the unneeded log type declaration.
> 
> Fixes: 9c99878aa1b16de2 ("log: introduce logtype register macro")
> 
> Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>

Acked-by: Gage Eads <gage.eads@intel.com>
David Marchand July 7, 2020, 11:14 a.m. UTC | #2 
On Mon, Jul 6, 2020 at 8:10 PM Eads, Gage <gage.eads@intel.com> wrote:
>
> > Subject: [dpdk-dev] [PATCH] log: remove unneeded log type declaration
> >
> > From: Jerin Jacob <jerinj@marvell.com>
> >
> > RTE_LOG_REGISTER macro already declares the the log type.
> > Remove the unneeded log type declaration.
> >
> > Fixes: 9c99878aa1b16de2 ("log: introduce logtype register macro")
> >
> > Reported-by: David Marchand <david.marchand@redhat.com>
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>
> Acked-by: Gage Eads <gage.eads@intel.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c
index a60fc4ef0..9bb462e95 100644
--- a/drivers/vdpa/mlx5/mlx5_vdpa.c
+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c
@@ -48,7 +48,6 @@ 
 TAILQ_HEAD(mlx5_vdpa_privs, mlx5_vdpa_priv) priv_list =
 					      TAILQ_HEAD_INITIALIZER(priv_list);
 static pthread_mutex_t priv_list_lock = PTHREAD_MUTEX_INITIALIZER;
-int mlx5_vdpa_logtype;
 
 static struct mlx5_vdpa_priv *
 mlx5_vdpa_find_priv_resource_by_vdev(struct rte_vdpa_device *vdev)
diff --git a/lib/librte_graph/graph.c b/lib/librte_graph/graph.c
index baa383cd7..7224b00a7 100644
--- a/lib/librte_graph/graph.c
+++ b/lib/librte_graph/graph.c
@@ -18,7 +18,6 @@ 
 static struct graph_head graph_list = STAILQ_HEAD_INITIALIZER(graph_list);
 static rte_spinlock_t graph_lock = RTE_SPINLOCK_INITIALIZER;
 static rte_graph_t graph_id;
-int rte_graph_logtype;
 
 #define GRAPH_ID_CHECK(id) ID_CHECK(id, graph_id)
 
diff --git a/lib/librte_rawdev/rte_rawdev.c b/lib/librte_rawdev/rte_rawdev.c
index aec61f425..2eb7b3bc3 100644
--- a/lib/librte_rawdev/rte_rawdev.c
+++ b/lib/librte_rawdev/rte_rawdev.c
@@ -34,9 +34,6 @@ 
 #include "rte_rawdev.h"
 #include "rte_rawdev_pmd.h"
 
-/* dynamic log identifier */
-int librawdev_logtype;
-
 static struct rte_rawdev rte_rawdevices[RTE_RAWDEV_MAX_DEVS];
 
 struct rte_rawdev *rte_rawdevs = rte_rawdevices;
diff --git a/lib/librte_stack/rte_stack.c b/lib/librte_stack/rte_stack.c
index e4c0ce131..8a51fba17 100644
--- a/lib/librte_stack/rte_stack.c
+++ b/lib/librte_stack/rte_stack.c
@@ -17,8 +17,6 @@ 
 #include "rte_stack.h"
 #include "stack_pvt.h"
 
-int stack_logtype;
-
 TAILQ_HEAD(rte_stack_list, rte_tailq_entry);
 
 static struct rte_tailq_elem rte_stack_tailq = {