[v2,1/3] ethdev: add new RSS offload types
diff mbox series

Message ID 1593666710-343445-2-git-send-email-simei.su@intel.com
State Accepted
Delegated to: Ferruh Yigit
Headers show
Series
  • net/ice: enable advanced RSS for PPPoE
Related show

Checks

Context Check Description
ci/Intel-compilation fail Compilation issues
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Simei Su July 2, 2020, 5:11 a.m. UTC
This patch defines new RSS offload types for PPPoE. Typically,
session id would be the RSS input set for a PPPoE packet, but
as a hint, each driver may have different default behaviors.

Signed-off-by: Simei Su <simei.su@intel.com>
---
 lib/librte_ethdev/rte_ethdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zhang, Qi Z July 3, 2020, 1:50 p.m. UTC | #1
> -----Original Message-----
> From: Su, Simei <simei.su@intel.com>
> Sent: Thursday, July 2, 2020 1:12 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>; Guo, Junfeng
> <junfeng.guo@intel.com>; Su, Simei <simei.su@intel.com>
> Subject: [PATCH v2 1/3] ethdev: add new RSS offload types
> 
> This patch defines new RSS offload types for PPPoE. Typically, session id
> would be the RSS input set for a PPPoE packet, but as a hint, each driver may
> have different default behaviors.
> 
> Signed-off-by: Simei Su <simei.su@intel.com>
> ---
>  lib/librte_ethdev/rte_ethdev.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
> index a49242b..631b146 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -521,7 +521,7 @@ struct rte_eth_rss_conf {
>  #define ETH_RSS_AH                 (1ULL << 28)
>  #define ETH_RSS_L2TPV3             (1ULL << 29)
>  #define ETH_RSS_PFCP               (1ULL << 30)
> -
> +#define ETH_RSS_PPPOE		   (1ULL << 31)
> 
>  /*
>   * We use the following macros to combine with above ETH_RSS_* for
> --
> 1.8.3.1

Reviewed-by: Qi Zhang <qi.z.zhang@intel.com>
Ferruh Yigit July 7, 2020, 9:50 a.m. UTC | #2
On 7/3/2020 2:50 PM, Zhang, Qi Z wrote:
> 
> 
>> -----Original Message-----
>> From: Su, Simei <simei.su@intel.com>
>> Sent: Thursday, July 2, 2020 1:12 PM
>> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
>> Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>; Guo, Junfeng
>> <junfeng.guo@intel.com>; Su, Simei <simei.su@intel.com>
>> Subject: [PATCH v2 1/3] ethdev: add new RSS offload types
>>
>> This patch defines new RSS offload types for PPPoE. Typically, session id
>> would be the RSS input set for a PPPoE packet, but as a hint, each driver may
>> have different default behaviors.
>>
>> Signed-off-by: Simei Su <simei.su@intel.com>
>> ---
>>  lib/librte_ethdev/rte_ethdev.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
>> index a49242b..631b146 100644
>> --- a/lib/librte_ethdev/rte_ethdev.h
>> +++ b/lib/librte_ethdev/rte_ethdev.h
>> @@ -521,7 +521,7 @@ struct rte_eth_rss_conf {
>>  #define ETH_RSS_AH                 (1ULL << 28)
>>  #define ETH_RSS_L2TPV3             (1ULL << 29)
>>  #define ETH_RSS_PFCP               (1ULL << 30)
>> -
>> +#define ETH_RSS_PPPOE		   (1ULL << 31)
>>
>>  /*
>>   * We use the following macros to combine with above ETH_RSS_* for
>> --
>> 1.8.3.1
> 
> Reviewed-by: Qi Zhang <qi.z.zhang@intel.com>
> 

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Patch
diff mbox series

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index a49242b..631b146 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -521,7 +521,7 @@  struct rte_eth_rss_conf {
 #define ETH_RSS_AH                 (1ULL << 28)
 #define ETH_RSS_L2TPV3             (1ULL << 29)
 #define ETH_RSS_PFCP               (1ULL << 30)
-
+#define ETH_RSS_PPPOE		   (1ULL << 31)
 
 /*
  * We use the following macros to combine with above ETH_RSS_* for