[v2] meter: remove inline functions from export list
Checks
Commit Message
The code didn't compile when using exported meter functions under windows.
error LNK2001: unresolved external symbol
rte_meter_srtcm_color_aware_check
error LNK2001: unresolved external symbol
rte_meter_srtcm_color_blind_check
error LNK2001: unresolved external symbol
rte_meter_trtcm_color_aware_check
error LNK2001: unresolved external symbol
rte_meter_trtcm_color_blind_check
error LNK2001: unresolved external symbol
rte_meter_trtcm_rfc4115_color_aware_check
error LNK2001: unresolved external symbol
rte_meter_trtcm_rfc4115_color_blind_check
The cause was that there were some inline functions that were included in
the export list.
To solve this the functions were removed from rte_meter_version.map export
list which are implemented in the header and shouldn't be exported.
Fixes: 655796d2b5fb3d44166e172 ("meter: support RFC4115 trTCM")
Fixes: 9d41beed24b01666913de30 ("lib: provide initial versioning")
Cc: stable@dpdk.org
Signed-off-by: Fady Bader <fady@mellanox.com>
---
v2: fixed commit message style issue
---
lib/librte_meter/rte_meter_version.map | 6 ------
1 file changed, 6 deletions(-)
Comments
17/06/2020 10:24, Fady Bader:
> The code didn't compile when using exported meter functions under windows.
>
> error LNK2001: unresolved external symbol
> rte_meter_srtcm_color_aware_check
> error LNK2001: unresolved external symbol
> rte_meter_srtcm_color_blind_check
> error LNK2001: unresolved external symbol
> rte_meter_trtcm_color_aware_check
> error LNK2001: unresolved external symbol
> rte_meter_trtcm_color_blind_check
> error LNK2001: unresolved external symbol
> rte_meter_trtcm_rfc4115_color_aware_check
> error LNK2001: unresolved external symbol
> rte_meter_trtcm_rfc4115_color_blind_check
>
> The cause was that there were some inline functions that were included in
> the export list.
> To solve this the functions were removed from rte_meter_version.map export
> list which are implemented in the header and shouldn't be exported.
>
> Fixes: 655796d2b5fb3d44166e172 ("meter: support RFC4115 trTCM")
> Fixes: 9d41beed24b01666913de30 ("lib: provide initial versioning")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fady Bader <fady@mellanox.com>
Applied, thanks
@@ -1,12 +1,8 @@
DPDK_20.0 {
global:
- rte_meter_srtcm_color_aware_check;
- rte_meter_srtcm_color_blind_check;
rte_meter_srtcm_config;
rte_meter_srtcm_profile_config;
- rte_meter_trtcm_color_aware_check;
- rte_meter_trtcm_color_blind_check;
rte_meter_trtcm_config;
rte_meter_trtcm_profile_config;
@@ -16,8 +12,6 @@ DPDK_20.0 {
DPDK_21 {
global:
- rte_meter_trtcm_rfc4115_color_aware_check;
- rte_meter_trtcm_rfc4115_color_blind_check;
rte_meter_trtcm_rfc4115_config;
rte_meter_trtcm_rfc4115_profile_config;