[v4,1/1] cryptodev: fix SHA-1 digest enum comment
diff mbox series

Message ID 20200521144853.4680-2-adamx.dybkowski@intel.com
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • cryptodev: fix SHA-1 digest enum comment
Related show

Checks

Context Check Description
ci/iol-testing fail Testing issues
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation fail Compilation issues
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Adam Dybkowski May 21, 2020, 2:48 p.m. UTC
This patch fixes improper SHA-1 digest size in the enum comment
and also adds the note about HMAC-SHA-1-96.

Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations")
Cc: stable@dpdk.org

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
---
 lib/librte_cryptodev/rte_crypto_sym.h | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Akhil Goyal May 21, 2020, 3:32 p.m. UTC | #1
> 
> This patch fixes improper SHA-1 digest size in the enum comment
> and also adds the note about HMAC-SHA-1-96.
> 
> Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
> ---

Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Thomas,
Can you pick this patch directly on master for this release? The patch is only fixing the comments.

Regards,
Akhil
Thomas Monjalon May 24, 2020, 9:54 a.m. UTC | #2
21/05/2020 17:32, Akhil Goyal:
> > 
> > This patch fixes improper SHA-1 digest size in the enum comment
> > and also adds the note about HMAC-SHA-1-96.
> > 
> > Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> > Acked-by: Anoob Joseph <anoobj@marvell.com>
> > ---
> 
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> 
> Thomas,
> Can you pick this patch directly on master for this release? The patch is only fixing the comments.

Applied, thanks

Patch
diff mbox series

diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h
index d9585ecd6..da961a19d 100644
--- a/lib/librte_cryptodev/rte_crypto_sym.h
+++ b/lib/librte_cryptodev/rte_crypto_sym.h
@@ -269,9 +269,12 @@  enum rte_crypto_auth_algorithm {
 	/**< HMAC using MD5 algorithm */
 
 	RTE_CRYPTO_AUTH_SHA1,
-	/**< 128 bit SHA algorithm. */
+	/**< 160 bit SHA algorithm. */
 	RTE_CRYPTO_AUTH_SHA1_HMAC,
-	/**< HMAC using 128 bit SHA algorithm. */
+	/**< HMAC using 160 bit SHA algorithm.
+	 * HMAC-SHA-1-96 can be generated by setting
+	 * digest_length to 12 bytes in auth/aead xforms.
+	 */
 	RTE_CRYPTO_AUTH_SHA224,
 	/**< 224 bit SHA algorithm. */
 	RTE_CRYPTO_AUTH_SHA224_HMAC,