diff mbox series

net/ice/base: fix FDIR rule completion report value

Message ID 1588901810-381405-1-git-send-email-simei.su@intel.com (mailing list archive)
State Accepted, archived
Delegated to: xiaolong ye
Headers
Series net/ice/base: fix FDIR rule completion report value |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-testing fail Testing issues

Commit Message

Simei Su May 8, 2020, 1:36 a.m. UTC 
  IAVF FDIR needs to check program status from FD completion descriptors
for both successful and failed case, rather than only ask for completion
on error. This patch corrects completion report value so that the called
can determine whether to report completion on error or other cases.

Fixes: 55daca4e45fc ("net/ice/base: change function to static")

Signed-off-by: Simei Su <simei.su@intel.com>
---
 drivers/net/ice/base/ice_fdir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Qi Zhang May 8, 2020, 1:43 a.m. UTC | #1 
> -----Original Message-----
> From: Su, Simei <simei.su@intel.com>
> Sent: Friday, May 8, 2020 9:37 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: dev@dpdk.org; Cao, Yahui <yahui.cao@intel.com>; Su, Simei
> <simei.su@intel.com>
> Subject: [PATCH] net/ice/base: fix FDIR rule completion report value
> 
> IAVF FDIR needs to check program status from FD completion descriptors for
> both successful and failed case, rather than only ask for completion on error.
> This patch corrects completion report value so that the called can determine
> whether to report completion on error or other cases.
> 
> Fixes: 55daca4e45fc ("net/ice/base: change function to static")
> 
> Signed-off-by: Simei Su <simei.su@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Xiaolong Ye May 8, 2020, 2:34 a.m. UTC | #2 
On 05/08, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: Su, Simei <simei.su@intel.com>
>> Sent: Friday, May 8, 2020 9:37 AM
>> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
>> Cc: dev@dpdk.org; Cao, Yahui <yahui.cao@intel.com>; Su, Simei
>> <simei.su@intel.com>
>> Subject: [PATCH] net/ice/base: fix FDIR rule completion report value
>> 
>> IAVF FDIR needs to check program status from FD completion descriptors for
>> both successful and failed case, rather than only ask for completion on error.
>> This patch corrects completion report value so that the called can determine
>> whether to report completion on error or other cases.
>> 
>> Fixes: 55daca4e45fc ("net/ice/base: change function to static")
>> 
>> Signed-off-by: Simei Su <simei.su@intel.com>
>
>Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
>

Applied to dpdk-next-net-intel, Thanks.
Zeng, XiaoxiaoX May 8, 2020, 9:31 a.m. UTC | #3 
Tested-by: Zeng,Xiaoxiao<xiaoxiaox.zeng@intel.com>


Best regards,
Zeng,xiaoxiao


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ye, Xiaolong
> Sent: Friday, May 8, 2020 10:35 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: Su, Simei <simei.su@intel.com>; dev@dpdk.org; Cao, Yahui
> <yahui.cao@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule completion
> report value
> 
> On 05/08, Zhang, Qi Z wrote:
> >
> >
> >> -----Original Message-----
> >> From: Su, Simei <simei.su@intel.com>
> >> Sent: Friday, May 8, 2020 9:37 AM
> >> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Ye, Xiaolong
> >> <xiaolong.ye@intel.com>
> >> Cc: dev@dpdk.org; Cao, Yahui <yahui.cao@intel.com>; Su, Simei
> >> <simei.su@intel.com>
> >> Subject: [PATCH] net/ice/base: fix FDIR rule completion report value
> >>
> >> IAVF FDIR needs to check program status from FD completion
> >> descriptors for both successful and failed case, rather than only ask for
> completion on error.
> >> This patch corrects completion report value so that the called can
> >> determine whether to report completion on error or other cases.
> >>
> >> Fixes: 55daca4e45fc ("net/ice/base: change function to static")
> >>
> >> Signed-off-by: Simei Su <simei.su@intel.com>
> >
> >Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> >
> >
> 
> Applied to dpdk-next-net-intel, Thanks.
diff mbox series

Patch

diff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ice/base/ice_fdir.c
index 33a1732..f899641 100644
--- a/drivers/net/ice/base/ice_fdir.c
+++ b/drivers/net/ice/base/ice_fdir.c
@@ -488,7 +488,7 @@ 
 		ICE_FXD_FLTR_QW1_PCMD_REMOVE;
 	fdir_fltr_ctx.swap = ICE_FXD_FLTR_QW1_SWAP_NOT_SET;
 	fdir_fltr_ctx.comp_q = ICE_FXD_FLTR_QW0_COMP_Q_ZERO;
-	fdir_fltr_ctx.comp_report = ICE_FXD_FLTR_QW0_COMP_REPORT_SW_FAIL;
+	fdir_fltr_ctx.comp_report = ICE_FXD_FLTR_QW0_COMP_REPORT_SW;
 	fdir_fltr_ctx.fdid_prio = input->fdid_prio;
 	fdir_fltr_ctx.desc_prof = 1;
 	fdir_fltr_ctx.desc_prof_prio = 3;