[1/2] l3fwd-power: exit if initializing power library failed
diff mbox series

Message ID 854770a880777e7ad200481294a7aa5ac9a45f2d.1586361368.git.anatoly.burakov@intel.com
State Superseded, archived
Delegated to: David Marchand
Headers show
Series
  • [1/2] l3fwd-power: exit if initializing power library failed
Related show

Checks

Context Check Description
ci/iol-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Burakov, Anatoly April 8, 2020, 3:56 p.m. UTC
Currently, if power library initialization fails, only a log message is
displayed. This is suboptimal for a number of reasons, but the main one
is that telemetry mode does not depend on the power library and can
therefore run in environments where l3fwd-power would normally not run
correctly (such as inside a VM). This will lead to attempts to
deinitialize the power library on exit, with a subsequent forced unclean
shutdown of DPDK.

Fix this by only initializing the power library in modes that actually
need it, and change a log message to a failure to initialize.

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 examples/l3fwd-power/main.c | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

Comments

Hunt, David April 9, 2020, 8:42 a.m. UTC | #1
Hi Anatoly,

On 8/4/2020 4:56 PM, Anatoly Burakov wrote:
> Currently, if power library initialization fails, only a log message is
> displayed. This is suboptimal for a number of reasons, but the main one
> is that telemetry mode does not depend on the power library and can
> therefore run in environments where l3fwd-power would normally not run
> correctly (such as inside a VM). This will lead to attempts to
> deinitialize the power library on exit, with a subsequent forced unclean
> shutdown of DPDK.
>
> Fix this by only initializing the power library in modes that actually
> need it, and change a log message to a failure to initialize.
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>   examples/l3fwd-power/main.c | 20 +++++++++++---------
>   1 file changed, 11 insertions(+), 9 deletions(-)
>

Acked-by: David Hunt <david.hunt@intel.com>
Pattan, Reshma April 9, 2020, 9:23 a.m. UTC | #2
> -----Original Message-----
> From: Burakov, Anatoly <anatoly.burakov@intel.com>
> Subject: [PATCH 1/2] l3fwd-power: exit if initializing power library failed
> 
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---


Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>

Patch
diff mbox series

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index c7fe0ec034..0e5fe42a64 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -2065,15 +2065,17 @@  static int check_ptype(uint16_t portid)
 static int
 init_power_library(void)
 {
-	int ret = 0, lcore_id;
-	for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
-		if (rte_lcore_is_enabled(lcore_id)) {
-			/* init power management library */
-			ret = rte_power_init(lcore_id);
-			if (ret)
-				RTE_LOG(ERR, POWER,
+	unsigned int lcore_id;
+	int ret = 0;
+
+	RTE_LCORE_FOREACH(lcore_id) {
+		/* init power management library */
+		ret = rte_power_init(lcore_id);
+		if (ret) {
+			RTE_LOG(ERR, POWER,
 				"Library initialization failed on core %u\n",
 				lcore_id);
+			return ret;
 		}
 	}
 	return ret;
@@ -2224,8 +2226,8 @@  main(int argc, char **argv)
 	if (ret < 0)
 		rte_exit(EXIT_FAILURE, "Invalid L3FWD parameters\n");
 
-	if (init_power_library())
-		RTE_LOG(ERR, L3FWD_POWER, "init_power_library failed\n");
+	if (app_mode != APP_MODE_TELEMETRY && init_power_library())
+		rte_exit(EXIT_FAILURE, "init_power_library failed\n");
 
 	if (update_lcore_params() < 0)
 		rte_exit(EXIT_FAILURE, "update_lcore_params failed\n");