[v2,10/13] net/ice: add more flow support for permit mode

Message ID 20200402064620.47668-11-wei.zhao1@intel.com (mailing list archive)
State Superseded, archived
Delegated to: xiaolong ye
Headers
Series add switch filter support for intel DCF |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Zhao1, Wei April 2, 2020, 6:46 a.m. UTC
  This patch add switch filter permit mode support
for more flow pattern in pf only mode.

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/ice/ice_switch_filter.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
  

Comments

Qi Zhang April 2, 2020, 8:45 a.m. UTC | #1
> -----Original Message-----
> From: Zhao1, Wei <wei.zhao1@intel.com>
> Sent: Thursday, April 2, 2020 2:46 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Peng, Yuan <yuan.peng@intel.com>;
> Lu, Nannan <nannan.lu@intel.com>; Fu, Qi <qi.fu@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v2 10/13] net/ice: add more flow support for permit mode
> 
It should be "permission stage" but not "permit mode"

> This patch add switch filter permit mode support for more flow pattern in pf
> only mode.
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
>  drivers/net/ice/ice_switch_filter.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/net/ice/ice_switch_filter.c
> b/drivers/net/ice/ice_switch_filter.c
> index 4248b8911..81d069e99 100644
> --- a/drivers/net/ice/ice_switch_filter.c
> +++ b/drivers/net/ice/ice_switch_filter.c
> @@ -200,6 +200,8 @@ ice_pattern_match_item ice_switch_pattern_dist_os[]
> = {
> 
>  static struct
>  ice_pattern_match_item ice_switch_pattern_perm[] = {
> +	{pattern_ethertype,
> +			ICE_SW_INSET_ETHER, ICE_INSET_NONE},
>  	{pattern_ethertype_vlan,
>  			ICE_SW_INSET_MAC_VLAN, ICE_INSET_NONE},
>  	{pattern_eth_ipv4,
> @@ -226,6 +228,18 @@ ice_pattern_match_item ice_switch_pattern_perm[]
> = {
>  			ICE_SW_INSET_PERM_TUNNEL_IPV4_UDP, ICE_INSET_NONE},
>  	{pattern_eth_ipv4_nvgre_eth_ipv4_tcp,
>  			ICE_SW_INSET_PERM_TUNNEL_IPV4_TCP, ICE_INSET_NONE},
> +	{pattern_eth_pppoed,
> +			ICE_SW_INSET_MAC_PPPOE, ICE_INSET_NONE},
> +	{pattern_eth_vlan_pppoed,
> +			ICE_SW_INSET_MAC_PPPOE, ICE_INSET_NONE},
> +	{pattern_eth_pppoes,
> +			ICE_SW_INSET_MAC_PPPOE, ICE_INSET_NONE},
> +	{pattern_eth_vlan_pppoes,
> +			ICE_SW_INSET_MAC_PPPOE, ICE_INSET_NONE},
> +	{pattern_eth_pppoes_proto,
> +			ICE_SW_INSET_MAC_PPPOE_PROTO, ICE_INSET_NONE},
> +	{pattern_eth_vlan_pppoes_proto,
> +			ICE_SW_INSET_MAC_PPPOE_PROTO, ICE_INSET_NONE},
>  	{pattern_eth_ipv6_esp,
>  			ICE_INSET_NONE, ICE_INSET_NONE},
>  	{pattern_eth_ipv6_udp_esp,
> --
> 2.19.1
  
Zhao1, Wei April 2, 2020, 9:41 a.m. UTC | #2
Ok 

> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Thursday, April 2, 2020 4:46 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>; Lu, Nannan <nannan.lu@intel.com>;
> Fu, Qi <qi.fu@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> Subject: RE: [PATCH v2 10/13] net/ice: add more flow support for permit mode
> 
> 
> 
> > -----Original Message-----
> > From: Zhao1, Wei <wei.zhao1@intel.com>
> > Sent: Thursday, April 2, 2020 2:46 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Peng, Yuan
> > <yuan.peng@intel.com>; Lu, Nannan <nannan.lu@intel.com>; Fu, Qi
> > <qi.fu@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH v2 10/13] net/ice: add more flow support for permit
> > mode
> >
> It should be "permission stage" but not "permit mode"
> 
> > This patch add switch filter permit mode support for more flow pattern
> > in pf only mode.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> >  drivers/net/ice/ice_switch_filter.c | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/net/ice/ice_switch_filter.c
> > b/drivers/net/ice/ice_switch_filter.c
> > index 4248b8911..81d069e99 100644
> > --- a/drivers/net/ice/ice_switch_filter.c
> > +++ b/drivers/net/ice/ice_switch_filter.c
> > @@ -200,6 +200,8 @@ ice_pattern_match_item
> > ice_switch_pattern_dist_os[] = {
> >
> >  static struct
> >  ice_pattern_match_item ice_switch_pattern_perm[] = {
> > +	{pattern_ethertype,
> > +			ICE_SW_INSET_ETHER, ICE_INSET_NONE},
> >  	{pattern_ethertype_vlan,
> >  			ICE_SW_INSET_MAC_VLAN, ICE_INSET_NONE},
> >  	{pattern_eth_ipv4,
> > @@ -226,6 +228,18 @@ ice_pattern_match_item
> ice_switch_pattern_perm[]
> > = {
> >  			ICE_SW_INSET_PERM_TUNNEL_IPV4_UDP, ICE_INSET_NONE},
> >  	{pattern_eth_ipv4_nvgre_eth_ipv4_tcp,
> >  			ICE_SW_INSET_PERM_TUNNEL_IPV4_TCP, ICE_INSET_NONE},
> > +	{pattern_eth_pppoed,
> > +			ICE_SW_INSET_MAC_PPPOE, ICE_INSET_NONE},
> > +	{pattern_eth_vlan_pppoed,
> > +			ICE_SW_INSET_MAC_PPPOE, ICE_INSET_NONE},
> > +	{pattern_eth_pppoes,
> > +			ICE_SW_INSET_MAC_PPPOE, ICE_INSET_NONE},
> > +	{pattern_eth_vlan_pppoes,
> > +			ICE_SW_INSET_MAC_PPPOE, ICE_INSET_NONE},
> > +	{pattern_eth_pppoes_proto,
> > +			ICE_SW_INSET_MAC_PPPOE_PROTO, ICE_INSET_NONE},
> > +	{pattern_eth_vlan_pppoes_proto,
> > +			ICE_SW_INSET_MAC_PPPOE_PROTO, ICE_INSET_NONE},
> >  	{pattern_eth_ipv6_esp,
> >  			ICE_INSET_NONE, ICE_INSET_NONE},
> >  	{pattern_eth_ipv6_udp_esp,
> > --
> > 2.19.1
  

Patch

diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c
index 4248b8911..81d069e99 100644
--- a/drivers/net/ice/ice_switch_filter.c
+++ b/drivers/net/ice/ice_switch_filter.c
@@ -200,6 +200,8 @@  ice_pattern_match_item ice_switch_pattern_dist_os[] = {
 
 static struct
 ice_pattern_match_item ice_switch_pattern_perm[] = {
+	{pattern_ethertype,
+			ICE_SW_INSET_ETHER, ICE_INSET_NONE},
 	{pattern_ethertype_vlan,
 			ICE_SW_INSET_MAC_VLAN, ICE_INSET_NONE},
 	{pattern_eth_ipv4,
@@ -226,6 +228,18 @@  ice_pattern_match_item ice_switch_pattern_perm[] = {
 			ICE_SW_INSET_PERM_TUNNEL_IPV4_UDP, ICE_INSET_NONE},
 	{pattern_eth_ipv4_nvgre_eth_ipv4_tcp,
 			ICE_SW_INSET_PERM_TUNNEL_IPV4_TCP, ICE_INSET_NONE},
+	{pattern_eth_pppoed,
+			ICE_SW_INSET_MAC_PPPOE, ICE_INSET_NONE},
+	{pattern_eth_vlan_pppoed,
+			ICE_SW_INSET_MAC_PPPOE, ICE_INSET_NONE},
+	{pattern_eth_pppoes,
+			ICE_SW_INSET_MAC_PPPOE, ICE_INSET_NONE},
+	{pattern_eth_vlan_pppoes,
+			ICE_SW_INSET_MAC_PPPOE, ICE_INSET_NONE},
+	{pattern_eth_pppoes_proto,
+			ICE_SW_INSET_MAC_PPPOE_PROTO, ICE_INSET_NONE},
+	{pattern_eth_vlan_pppoes_proto,
+			ICE_SW_INSET_MAC_PPPOE_PROTO, ICE_INSET_NONE},
 	{pattern_eth_ipv6_esp,
 			ICE_INSET_NONE, ICE_INSET_NONE},
 	{pattern_eth_ipv6_udp_esp,