diff mbox series

config: update MAX_FRAG to support jumbo packets

Message ID 20200401083532.13658-1-apeksha.gupta@nxp.com (mailing list archive)
State Rejected, archived
Delegated to: Thomas Monjalon
Headers
Series config: update MAX_FRAG to support jumbo packets |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/iol-intel-Performance fail Performance Testing issues
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/travis-robot warning Travis build: failed

Commit Message

Apeksha Gupta April 1, 2020, 8:35 a.m. UTC 
  RTE_LIBRTE_IP_FRAG_MAX_FRAG flag value increased from 4 to 8. By this
pkt size greater than 6000 is supported in ip-fragmentation and
ip-reassembly.

Fixes: 9788b93b9d5 ("config: MAX_FRAG updated to support the jumbo
packets")
Cc: stable@dpdk.org

Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
---
 config/common_base  | 2 +-
 config/rte_config.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Ananyev, Konstantin April 6, 2020, 4:55 p.m. UTC | #1 
> 
> RTE_LIBRTE_IP_FRAG_MAX_FRAG flag value increased from 4 to 8. By this
> pkt size greater than 6000 is supported in ip-fragmentation and
> ip-reassembly.
> 
> Fixes: 9788b93b9d5 ("config: MAX_FRAG updated to support the jumbo
> packets")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
> ---
>  config/common_base  | 2 +-
>  config/rte_config.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/config/common_base b/config/common_base
> index e231384e88..be4a6bafb5 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -950,7 +950,7 @@ CONFIG_RTE_LIBRTE_NET=y
>  #
>  CONFIG_RTE_LIBRTE_IP_FRAG=y
>  CONFIG_RTE_LIBRTE_IP_FRAG_DEBUG=n
> -CONFIG_RTE_LIBRTE_IP_FRAG_MAX_FRAG=4
> +CONFIG_RTE_LIBRTE_IP_FRAG_MAX_FRAG=8
>  CONFIG_RTE_LIBRTE_IP_FRAG_TBL_STAT=n
> 
>  #
> diff --git a/config/rte_config.h b/config/rte_config.h
> index d30786bc08..f5cdc3ddbe 100644
> --- a/config/rte_config.h
> +++ b/config/rte_config.h
> @@ -82,7 +82,7 @@
>  #define RTE_RAWDEV_MAX_DEVS 64
> 
>  /* ip_fragmentation defines */
> -#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 4
> +#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8
>  #undef RTE_LIBRTE_IP_FRAG_TBL_STAT

Not sure it is a good idea - it will double size of reassembly table
(and number of required mbufs) for users who use default value. 
The proper way would be, I think to restructure reassemble code,
to make max_frag_num an extra parameter for rte_ip_frag_table_create(). 

> 
>  /* rte_power defines */
> --
> 2.17.1
diff mbox series

Patch

diff --git a/config/common_base b/config/common_base
index e231384e88..be4a6bafb5 100644
--- a/config/common_base
+++ b/config/common_base
@@ -950,7 +950,7 @@  CONFIG_RTE_LIBRTE_NET=y
 #
 CONFIG_RTE_LIBRTE_IP_FRAG=y
 CONFIG_RTE_LIBRTE_IP_FRAG_DEBUG=n
-CONFIG_RTE_LIBRTE_IP_FRAG_MAX_FRAG=4
+CONFIG_RTE_LIBRTE_IP_FRAG_MAX_FRAG=8
 CONFIG_RTE_LIBRTE_IP_FRAG_TBL_STAT=n
 
 #
diff --git a/config/rte_config.h b/config/rte_config.h
index d30786bc08..f5cdc3ddbe 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -82,7 +82,7 @@ 
 #define RTE_RAWDEV_MAX_DEVS 64
 
 /* ip_fragmentation defines */
-#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 4
+#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8
 #undef RTE_LIBRTE_IP_FRAG_TBL_STAT
 
 /* rte_power defines */