From patchwork Wed Mar 18 20:51:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 66893 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FCF8A057D; Wed, 18 Mar 2020 21:51:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF7C71C07E; Wed, 18 Mar 2020 21:51:23 +0100 (CET) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 14C6D1C02D for ; Wed, 18 Mar 2020 21:51:20 +0100 (CET) Received: by mail-pf1-f196.google.com with SMTP id u68so134115pfb.2 for ; Wed, 18 Mar 2020 13:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d4prE4SN6ZkDoTHAHNXtLgoL+X3q4iJTfZM8yaxA7Qc=; b=Uc+YAXjbmrzca4yAv/di2yk50Z82Mn/WAR6ig1Uc/X4/SldKxjp86ZpN7trr5GETMo oa9vU7Jej2XvmuyJEeYgZH8nT8AgAeCJSKDYXWBpYs7ZDB89TvSaDW64ipAN8d2ODbrN PH8D/9+K3gFaNsGkoc0+3B5CmAGiQ17PmYakD9rwOVG5OQcixayWwZ6axKdPELw8D/2L agcRsBIsvyoias4Ybu3AAr+MrVdX3198nSGNecoXbJzyPoz80VsQMVdkcubdZszwA911 98a9+XC76VOWyMtRZNxZb1AnX7xPTn3LItpJ+7t2sImzWessv/AeYPZ9winHyn+QHJjV NFXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d4prE4SN6ZkDoTHAHNXtLgoL+X3q4iJTfZM8yaxA7Qc=; b=JN3lDrkPnPhUsgYi7cefOzzmlv84zZmAjVb9kYfB7VQbPMzdiitm0SjPrhQn5OQVOr LoEmsBWgJjN4l1h7fZZ2I69RNFkAYgDAe+rUApHEXYzK4uBKuLffJyIKNovIs9UsukGN FoidTOIBLMO7oSqRq0NFsbI3oxTSnYgZ8bO2A7IWXH5aWkcsJpdy62b13oGtcoaEwc+r DXr3zJP8Hkh75n0dB9E23rXUz/RkVZynuLfcak7HqUAIbPjsd4sQlbF+i2JbISAftBm/ ij8pzNI38QRCDbLkIv3jzPKLxwTBu1BbuRX3TlAVclq17ZX1dYTQD/kOwYc77cCB41uH SL/w== X-Gm-Message-State: ANhLgQ0YhaW0V+cik8+HXM6VSH1FWTMZ8Q3xEHRQv37uML/FdAIHwuIU 7gk8GWE5jFfhYp6596QvcvbXaXLclq8= X-Google-Smtp-Source: ADFU+vvumez3J0dN533xBoa3nGuiMbnwKp0ToIEIZ3wGNiDO4sLI0NQdYvP2yaaM0RdPFvYnVOFuzw== X-Received: by 2002:a63:ec42:: with SMTP id r2mr6645537pgj.386.1584564678839; Wed, 18 Mar 2020 13:51:18 -0700 (PDT) Received: from hermes.corp.microsoft.com (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id e80sm7800150pfh.117.2020.03.18.13.51.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2020 13:51:17 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org Date: Wed, 18 Mar 2020 13:51:04 -0700 Message-Id: <20200318205104.22486-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200318205104.22486-1-stephen@networkplumber.org> References: <20200316235612.29854-1-stephen@networkplumber.org> <20200318205104.22486-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 4/4] net/netvsc: don't enable RSS if only single receive queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If application has multiple transmit queues but only a single receive queue, then do not enable RSS. Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index ac6610838008..85f43996a623 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -597,11 +597,14 @@ static int hn_dev_configure(struct rte_eth_dev *dev) return err; } - err = hn_rndis_conf_rss(hv, 0); - if (err) { - PMD_DRV_LOG(NOTICE, - "initial RSS config failed"); - return err; + if ((dev_conf->rxmode.offloads & DEV_RX_OFFLOAD_RSS_HASH) && + dev->data->nb_rx_queues > 1) { + err = hn_rndis_conf_rss(hv, 0); + if (err) { + PMD_DRV_LOG(NOTICE, + "initial RSS config failed"); + return err; + } } }