net/sfc: fix incorrect fail label placement
Checks
Commit Message
From: Igor Romanov <igor.romanov@oktetlabs.ru>
NIC deinitialization should not happen after a failed NIC
initialization.
Fixes: 91831d4068c8 ("net/sfc: estimate available resources")
Cc: stable@dpdk.org
Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/sfc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 3/5/2020 10:38 AM, Andrew Rybchenko wrote:
> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>
> NIC deinitialization should not happen after a failed NIC
> initialization.
>
> Fixes: 91831d4068c8 ("net/sfc: estimate available resources")
> Cc: stable@dpdk.org
>
> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Applied to dpdk-next-net/master, thanks.
@@ -241,8 +241,8 @@ sfc_estimate_resource_limits(struct sfc_adapter *sa)
return 0;
fail_get_vi_pool:
-fail_nic_init:
efx_nic_fini(sa->nic);
+fail_nic_init:
return rc;
}