From patchwork Mon Mar 2 10:55:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tonghao Zhang X-Patchwork-Id: 66190 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 551B2A0566; Mon, 2 Mar 2020 11:55:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3D1151BFF9; Mon, 2 Mar 2020 11:55:25 +0100 (CET) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by dpdk.org (Postfix) with ESMTP id DF5E22BB8; Mon, 2 Mar 2020 11:55:23 +0100 (CET) Received: by mail-pj1-f65.google.com with SMTP id f2so5889609pjq.1; Mon, 02 Mar 2020 02:55:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=zMzuGb7bsZ1eyOk4QzM54ArgMB+q1ApyYFO5tSaULq0=; b=NZUPMtU7yYgkeaXKqrtsYRcCGlY44ZrQoNsUybVq5nneVROHKgR6wo71ezj2cE6pLU TVw/NgkmCZRH5BaPvT2uBMTsCnnWn+JC+nkg2SZH1XS8G7vhSJ1ewGLjdJat2eYwG3Lh CiF0EKYvNClbpiEJ/GFE3SmU29C+7eukrJrEJ5nJX3XPxHPjagSwKwoiuTMcj8dl3STs vyryxEFREuO9PQT47heNEHObZUgR4pRZlNVT/QL6W43A7ybFW8UCoknHCde26sRR4MJM wm+QUvGhlERPy0I1odJSq8muLk2OL5pvQtbHbmOFR1CNBNzOthxg3TSDBN4wGc0osh18 9u2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zMzuGb7bsZ1eyOk4QzM54ArgMB+q1ApyYFO5tSaULq0=; b=CbqI8XOkPOlFzFb7iEzyrUxoBpY5oiMcjJrKZPiEEIzuj3CLZcmaTGtHA/CLSwREAY eLxnmTHr+Hw5xj5dOl7FHsjls1CJQv/rBdDpc+V+LeGsQHd7eKvSEJ1LG+DxjQ623YIT yWvoi2EuKZSHEYfDKqfAAMzKnQ4GwSRCmScFscUdwWIIJoUu+269aBrXfxNzbZ2rsBvK 32t2fnRuvCQ+ScwGCbJRtvmdmQe5P15x6GrxOHEzLWz/ZKoISkKpwSeW5aSRkBpQ1bBk 6JIQOAcEgt2apVb7NPSO/X6KRtd9rRXpDthJd16xtf29z9AInzBtOmSPOhtru2t7dvre OB6g== X-Gm-Message-State: APjAAAVVxZ0iUyRC1eTKvZR0z2V5vuGOPuSG5IuUBZIyWLWodIEah6KN GVfWIzCznk9ZsoExJX2ylkw= X-Google-Smtp-Source: APXvYqwGDG/uQN+02ewYJZxheQyTDpLvB3Tidvqs+hyzWdMv9425zd2BTc4EvO2k4nHca7pTUU1hlQ== X-Received: by 2002:a17:90a:30a3:: with SMTP id h32mr20923185pjb.48.1583146523110; Mon, 02 Mar 2020 02:55:23 -0800 (PST) Received: from local.opencloud.tech.localdomain ([219.143.129.147]) by smtp.gmail.com with ESMTPSA id k3sm20599710pgh.34.2020.03.02.02.55.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Mar 2020 02:55:22 -0800 (PST) From: xiangxia.m.yue@gmail.com To: matan@mellanox.com, rasland@mellanox.com, alialnu@mellanox.com Cc: dev@dpdk.org, Tonghao Zhang , stable@dpdk.org Date: Mon, 2 Mar 2020 18:55:17 +0800 Message-Id: <1583146517-7079-1-git-send-email-xiangxia.m.yue@gmail.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-dev] [PATCH dpdk-dev v2] common/mlx5: fix possible building error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Tonghao Zhang When setting the CONFIG_RTE_BUILD_SHARED_LIB to y, and build the mlx5 pmd, there is a building error. To fix it, add RTE_IBVERBS_LINK_DLOPEN to include relative codes. > mlx5_common.o: In function `mlx5_glue_init': > drivers/common/mlx5/mlx5_common.c:324: undefined reference to `dlclose' Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library") Cc: stable@dpdk.org Signed-off-by: Tonghao Zhang Tested-by: Ali Alnubani --- drivers/common/mlx5/mlx5_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/common/mlx5/mlx5_common.c b/drivers/common/mlx5/mlx5_common.c index 610fb48..570a3f4 100644 --- a/drivers/common/mlx5/mlx5_common.c +++ b/drivers/common/mlx5/mlx5_common.c @@ -209,8 +209,6 @@ enum mlx5_class */ RTE_INIT_PRIO(mlx5_glue_init, CLASS) { - void *handle = NULL; - /* Initialize common log type. */ mlx5_common_logtype = rte_log_register("pmd.common.mlx5"); if (mlx5_common_logtype >= 0) @@ -249,6 +247,7 @@ enum mlx5_class mlx5_glue_path(glue_path, sizeof(glue_path)) : ""), }; unsigned int i = 0; + void *handle = NULL; void **sym; const char *dlmsg; @@ -320,8 +319,10 @@ enum mlx5_class mlx5_glue->fork_init(); return; glue_error: +#ifdef RTE_IBVERBS_LINK_DLOPEN if (handle) dlclose(handle); +#endif DRV_LOG(WARNING, "Cannot initialize MLX5 common due to missing" " run-time dependency on rdma-core libraries (libibverbs," " libmlx5)");