[v2,3/3] ci: add travis ci support for native ppc64le

Message ID 20200219011007.8611-4-dwilder@us.ibm.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series add travis ci support for ppc64le |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply issues
ci/travis-robot success Travis build: passed

Commit Message

David Wilder Feb. 19, 2020, 1:10 a.m. UTC
  This change follows the example of aarch64 Travis support
by adding support for ppc64le gcc builds.  Limitations for
ppc64le are the same as aarch64 as described in commit
31bb45bcfd.

Signed-off-by: David Wilder <dwilder@us.ibm.com>
Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>
---
 .travis.yml | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
  

Comments

Thomas Monjalon Feb. 19, 2020, 7:55 a.m. UTC | #1
19/02/2020 02:10, David Wilder:
> This change follows the example of aarch64 Travis support
> by adding support for ppc64le gcc builds.  Limitations for
> ppc64le are the same as aarch64 as described in commit
> 31bb45bcfd.
> 
> Signed-off-by: David Wilder <dwilder@us.ibm.com>
> Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>
> ---
> --- a/.travis.yml
> +++ b/.travis.yml
> +  - env: DEF_LIB="static"
> +    arch: ppc64le
> +    compiler: gcc
> +    addons:
> +      apt:
> +        packages:
> +          - *required_packages
> +  - env: DEF_LIB="shared"
> +    arch: ppc64le
> +    compiler: gcc
> +    addons:
> +      apt:
> +        packages:
> +          - *required_packages
> +  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" BUILD_DOCS=1

kmods are already disabled by default.

> +    arch: ppc64le
> +    compiler: gcc
> +    addons:
> +      apt:
> +        packages:
> +          - *required_packages
> +          - *doc_packages

Why testing without EXTRA_PACKAGES?

> +  - env: DEF_LIB="shared" EXTRA_PACKAGES=1 ABI_CHECKS=1
> +    arch: ppc64le
> +    compiler: gcc
> +    addons:
> +      apt:
> +        packages:
> +          - *extra_packages
> +          - *libabigail_build_packages
  
David Marchand Feb. 19, 2020, 1:46 p.m. UTC | #2
On Wed, Feb 19, 2020 at 2:10 AM David Wilder <dwilder@us.ibm.com> wrote:
>
> This change follows the example of aarch64 Travis support
> by adding support for ppc64le gcc builds.  Limitations for
> ppc64le are the same as aarch64 as described in commit
> 31bb45bcfd.

checkpatch did not catch it because of the \n (?).
When referring to other commits, please use the format 'commit <12+
chars of sha1> ("<title line>")'.


>
> Signed-off-by: David Wilder <dwilder@us.ibm.com>
> Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>

I can see no clang compilation.
Is it unsupported? forgotten? unwanted?


> ---
>  .travis.yml | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/.travis.yml b/.travis.yml
> index 1d43f16ae..c15bf4f07 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -153,5 +153,35 @@ matrix:
>          packages:
>            - *extra_packages
>            - *libabigail_build_packages
> +  - env: DEF_LIB="static"
> +    arch: ppc64le
> +    compiler: gcc
> +    addons:
> +      apt:
> +        packages:
> +          - *required_packages

Copy/pasting this part is useless.
The addons: global node would make all jobs use this required_packages
as a default.
I have a patch cleaning this for arm.


> +  - env: DEF_LIB="shared"
> +    arch: ppc64le
> +    compiler: gcc
> +    addons:
> +      apt:
> +        packages:
> +          - *required_packages
> +  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" BUILD_DOCS=1
> +    arch: ppc64le
> +    compiler: gcc
> +    addons:
> +      apt:
> +        packages:
> +          - *required_packages
> +          - *doc_packages
> +  - env: DEF_LIB="shared" EXTRA_PACKAGES=1 ABI_CHECKS=1
> +    arch: ppc64le
> +    compiler: gcc
> +    addons:
> +      apt:
> +        packages:
> +          - *extra_packages
> +          - *libabigail_build_packages
>
>  script: ./.ci/${TRAVIS_OS_NAME}-build.sh
> --
> 2.25.0
>
  
David Wilder Feb. 19, 2020, 8:32 p.m. UTC | #3
On 2020-02-19 05:46, David Marchand wrote:
> On Wed, Feb 19, 2020 at 2:10 AM David Wilder <dwilder@us.ibm.com> 
> wrote:
>> 
>> This change follows the example of aarch64 Travis support
>> by adding support for ppc64le gcc builds.  Limitations for
>> ppc64le are the same as aarch64 as described in commit
>> 31bb45bcfd.
> 
> checkpatch did not catch it because of the \n (?).
> When referring to other commits, please use the format 'commit <12+
> chars of sha1> ("<title line>")'.
> 

Ok

> 
>> 
>> Signed-off-by: David Wilder <dwilder@us.ibm.com>
>> Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>
> 
> I can see no clang compilation.
> Is it unsupported? forgotten? unwanted?
> 

Unsupported for now (issues with altivec).

> 
>> ---
>>  .travis.yml | 30 ++++++++++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>> 
>> diff --git a/.travis.yml b/.travis.yml
>> index 1d43f16ae..c15bf4f07 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -153,5 +153,35 @@ matrix:
>>          packages:
>>            - *extra_packages
>>            - *libabigail_build_packages
>> +  - env: DEF_LIB="static"
>> +    arch: ppc64le
>> +    compiler: gcc
>> +    addons:
>> +      apt:
>> +        packages:
>> +          - *required_packages
> 
> Copy/pasting this part is useless.
> The addons: global node would make all jobs use this required_packages
> as a default.
> I have a patch cleaning this for arm.

I see your cleanup patch now.  I will refactor the ppc support on top 
and let you know if I have issues.

Thanks for the review.
  

Patch

diff --git a/.travis.yml b/.travis.yml
index 1d43f16ae..c15bf4f07 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -153,5 +153,35 @@  matrix:
         packages:
           - *extra_packages
           - *libabigail_build_packages
+  - env: DEF_LIB="static"
+    arch: ppc64le
+    compiler: gcc
+    addons:
+      apt:
+        packages:
+          - *required_packages
+  - env: DEF_LIB="shared"
+    arch: ppc64le
+    compiler: gcc
+    addons:
+      apt:
+        packages:
+          - *required_packages
+  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" BUILD_DOCS=1
+    arch: ppc64le
+    compiler: gcc
+    addons:
+      apt:
+        packages:
+          - *required_packages
+          - *doc_packages
+  - env: DEF_LIB="shared" EXTRA_PACKAGES=1 ABI_CHECKS=1
+    arch: ppc64le
+    compiler: gcc
+    addons:
+      apt:
+        packages:
+          - *extra_packages
+          - *libabigail_build_packages
 
 script: ./.ci/${TRAVIS_OS_NAME}-build.sh