[v3] doc: add inline protocol in feature list

Message ID 1581953983-18994-1-git-send-email-anoobj@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [v3] doc: add inline protocol in feature list |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot warning Travis build: failed
ci/Intel-compilation success Compilation OK

Commit Message

Anoob Joseph Feb. 17, 2020, 3:39 p.m. UTC
  Update feature list to include inline protocol offload.

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---
v3
* Added inline protocol in octeontx2_vf.ini

v2
* Reworded doc following suggestions from Akhil

 doc/guides/nics/features.rst              | 27 ++++++++++++++++++++++++++-
 doc/guides/nics/features/default.ini      |  1 +
 doc/guides/nics/features/octeontx2.ini    |  1 +
 doc/guides/nics/features/octeontx2_vf.ini |  1 +
 4 files changed, 29 insertions(+), 1 deletion(-)
  

Comments

Akhil Goyal Feb. 18, 2020, 7:40 a.m. UTC | #1
> 
> Update feature list to include inline protocol offload.
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> ---
> v3
> * Added inline protocol in octeontx2_vf.ini
> 
> v2
> * Reworded doc following suggestions from Akhil
> 
>  doc/guides/nics/features.rst              | 27 ++++++++++++++++++++++++++-
>  doc/guides/nics/features/default.ini      |  1 +
>  doc/guides/nics/features/octeontx2.ini    |  1 +
>  doc/guides/nics/features/octeontx2_vf.ini |  1 +
>  4 files changed, 29 insertions(+), 1 deletion(-)
> 
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Ferruh,
Do you want me to take this patch on crypto tree or you would be taking it.

Regards,
Akhil
  
Ferruh Yigit Feb. 18, 2020, 9:28 a.m. UTC | #2
On 2/18/2020 7:40 AM, Akhil Goyal wrote:
> 
>>
>> Update feature list to include inline protocol offload.
>>
>> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
>> ---
>> v3
>> * Added inline protocol in octeontx2_vf.ini
>>
>> v2
>> * Reworded doc following suggestions from Akhil
>>
>>  doc/guides/nics/features.rst              | 27 ++++++++++++++++++++++++++-
>>  doc/guides/nics/features/default.ini      |  1 +
>>  doc/guides/nics/features/octeontx2.ini    |  1 +
>>  doc/guides/nics/features/octeontx2_vf.ini |  1 +
>>  4 files changed, 29 insertions(+), 1 deletion(-)
>>
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> 
> Ferruh,
> Do you want me to take this patch on crypto tree or you would be taking it.
> 

Thanks Akhil, both are OK for me, but there are already a few patches merged in
next-net so let me get this one too to simply merging to main repo.
  
Ferruh Yigit Feb. 18, 2020, 10:02 a.m. UTC | #3
On 2/18/2020 9:28 AM, Ferruh Yigit wrote:
> On 2/18/2020 7:40 AM, Akhil Goyal wrote:
>>
>>>
>>> Update feature list to include inline protocol offload.
>>>
>>> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
>>> ---
>>> v3
>>> * Added inline protocol in octeontx2_vf.ini
>>>
>>> v2
>>> * Reworded doc following suggestions from Akhil
>>>
>>>  doc/guides/nics/features.rst              | 27 ++++++++++++++++++++++++++-
>>>  doc/guides/nics/features/default.ini      |  1 +
>>>  doc/guides/nics/features/octeontx2.ini    |  1 +
>>>  doc/guides/nics/features/octeontx2_vf.ini |  1 +
>>>  4 files changed, 29 insertions(+), 1 deletion(-)
>>>
>> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
>>
>> Ferruh,
>> Do you want me to take this patch on crypto tree or you would be taking it.
>>
> 
> Thanks Akhil, both are OK for me, but there are already a few patches merged in
> next-net so let me get this one too to simply merging to main repo.
> 

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index 8394a65..edd21c4 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -421,7 +421,9 @@  Supports adding traffic mirroring rules.
 Inline crypto
 -------------
 
-Supports inline crypto processing (e.g. inline IPsec). See Security library and PMD documentation for more details.
+Supports inline crypto processing defined by rte_security library to perform crypto
+operations of security protocol while packet is received in NIC. NIC is not aware
+of protocol operations. See Security library and PMD documentation for more details.
 
 * **[uses]       rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_SECURITY``,
 * **[uses]       rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_SECURITY``.
@@ -431,6 +433,29 @@  Supports inline crypto processing (e.g. inline IPsec). See Security library and
   ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``.
 * **[provides]   mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``,
   ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``, ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
+* **[provides]   rte_security_ops, capabilities_get**:  ``action: RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO``
+
+
+.. _nic_features_inline_protocol_doc:
+
+Inline protocol
+---------------
+
+Supports inline protocol processing defined by rte_security library to perform
+protocol processing for the security protocol (e.g. IPsec, MACSEC) while the
+packet is received at NIC. The NIC is capable of understanding the security
+protocol operations. See security library and PMD documentation for more details.
+
+* **[uses]       rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_SECURITY``,
+* **[uses]       rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_SECURITY``.
+* **[implements] rte_security_ops**: ``session_create``, ``session_update``,
+  ``session_stats_get``, ``session_destroy``, ``set_pkt_metadata``, ``get_userdata``,
+  ``capabilities_get``.
+* **[provides] rte_eth_dev_info**: ``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_SECURITY``,
+  ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``.
+* **[provides]   mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``,
+  ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``, ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``.
+* **[provides]   rte_security_ops, capabilities_get**:  ``action: RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL``
 
 
 .. _nic_features_crc_offload:
diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
index 91ec619..4d0ad32 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -42,6 +42,7 @@  Flow API             =
 Rate limitation      =
 Traffic mirroring    =
 Inline crypto        =
+Inline protocol      =
 CRC offload          =
 VLAN offload         =
 QinQ offload         =
diff --git a/doc/guides/nics/features/octeontx2.ini b/doc/guides/nics/features/octeontx2.ini
index c2a3f47b..473fe56 100644
--- a/doc/guides/nics/features/octeontx2.ini
+++ b/doc/guides/nics/features/octeontx2.ini
@@ -27,6 +27,7 @@  RSS hash             = Y
 RSS key update       = Y
 RSS reta update      = Y
 Inner RSS            = Y
+Inline protocol      = Y
 VLAN filter          = Y
 Flow control         = Y
 Flow API             = Y
diff --git a/doc/guides/nics/features/octeontx2_vf.ini b/doc/guides/nics/features/octeontx2_vf.ini
index a70d195..96ef098 100644
--- a/doc/guides/nics/features/octeontx2_vf.ini
+++ b/doc/guides/nics/features/octeontx2_vf.ini
@@ -21,6 +21,7 @@  RSS hash             = Y
 RSS key update       = Y
 RSS reta update      = Y
 Inner RSS            = Y
+Inline protocol      = Y
 VLAN filter          = Y
 Flow API             = Y
 Jumbo frame          = Y