build: remove function versioning from meson files

Message ID 20200129162347.27975-1-aostruszka@marvell.com (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers
Series build: remove function versioning from meson files |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing fail Testing issues
ci/travis-robot warning Travis build: failed
ci/Intel-compilation fail apply issues

Commit Message

Andrzej Ostruszka [C] Jan. 29, 2020, 4:23 p.m. UTC
  Timer, LPM and Distributor libraries no longer use function versioning
and therefore do not need separate build for static and shared version
of libraries.

This patch removes use_function_versioning from their meson build files.

Signed-off-by: Andrzej Ostruszka <aostruszka@marvell.com>
Fixes: f2fb215843a9 ("timer: remove deprecated code")
Fixes: 6e5b51676176 ("distributor: remove deprecated code")
Fixes: c381a8d554b7 ("lpm: remove deprecated code")
Cc: marcinx.baran@intel.com
---
 lib/librte_distributor/meson.build | 1 -
 lib/librte_lpm/meson.build         | 1 -
 lib/librte_timer/meson.build       | 1 -
 3 files changed, 3 deletions(-)
  

Comments

Bruce Richardson Jan. 29, 2020, 4:30 p.m. UTC | #1
> -----Original Message-----
> From: Andrzej Ostruszka <aostruszka@marvell.com>
> Sent: Wednesday, January 29, 2020 4:24 PM
> To: dev@dpdk.org; Hunt, David <david.hunt@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Medvedkin, Vladimir
> <vladimir.medvedkin@intel.com>; Robert Sanford <rsanford@akamai.com>;
> Carrillo, Erik G <erik.g.carrillo@intel.com>
> Cc: Baran, MarcinX <marcinx.baran@intel.com>
> Subject: [PATCH] build: remove function versioning from meson files
> 
> Timer, LPM and Distributor libraries no longer use function versioning
> and therefore do not need separate build for static and shared version
> of libraries.
> 
> This patch removes use_function_versioning from their meson build files.
> 
> Signed-off-by: Andrzej Ostruszka <aostruszka@marvell.com>
> Fixes: f2fb215843a9 ("timer: remove deprecated code")
> Fixes: 6e5b51676176 ("distributor: remove deprecated code")
> Fixes: c381a8d554b7 ("lpm: remove deprecated code")
> Cc: marcinx.baran@intel.com
> ---

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
  

Patch

diff --git a/lib/librte_distributor/meson.build b/lib/librte_distributor/meson.build
index 50b91887b..266af6434 100644
--- a/lib/librte_distributor/meson.build
+++ b/lib/librte_distributor/meson.build
@@ -9,7 +9,6 @@  else
 endif
 headers = files('rte_distributor.h')
 deps += ['mbuf']
-use_function_versioning = true
 
 # for clang 32-bit compiles we need libatomic for 64-bit atomic ops
 if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false
diff --git a/lib/librte_lpm/meson.build b/lib/librte_lpm/meson.build
index 27ce45b53..021ac6d8d 100644
--- a/lib/librte_lpm/meson.build
+++ b/lib/librte_lpm/meson.build
@@ -7,4 +7,3 @@  headers = files('rte_lpm.h', 'rte_lpm6.h')
 # without worrying about which architecture we actually need
 headers += files('rte_lpm_altivec.h', 'rte_lpm_neon.h', 'rte_lpm_sse.h')
 deps += ['hash']
-use_function_versioning = true
diff --git a/lib/librte_timer/meson.build b/lib/librte_timer/meson.build
index b7edfe2e7..d3b828ce9 100644
--- a/lib/librte_timer/meson.build
+++ b/lib/librte_timer/meson.build
@@ -4,4 +4,3 @@ 
 sources = files('rte_timer.c')
 headers = files('rte_timer.h')
 allow_experimental_apis = true
-use_function_versioning = true