[v2,1/1] test/crypto: remove repeated test and enable on QAT
diff mbox series

Message ID 20200122144207.14091-2-adamx.dybkowski@intel.com
State Accepted
Delegated to: akhil goyal
Headers show
Series
  • test/crypto: remove repeated test and enable on QAT
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Dybkowski, AdamX Jan. 22, 2020, 2:42 p.m. UTC
Remove one AES GCM scatter-gather unit test repetition
and enable this test on QAT (after a fix included in the commit
b26ef1a11f21).

Fixes: 157d0b11d204 ("test/crypto: add capability checks")
Fixes: b26ef1a11f21 ("test/crypto: fix missing operation status check")

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
 app/test/test_cryptodev.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Trahe, Fiona Jan. 22, 2020, 2:48 p.m. UTC | #1
> -----Original Message-----
> From: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Sent: Wednesday, January 22, 2020 2:42 PM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [PATCH v2 1/1] test/crypto: remove repeated test and enable on QAT
> 
> Remove one AES GCM scatter-gather unit test repetition
> and enable this test on QAT (after a fix included in the commit
> b26ef1a11f21).
> 
> Fixes: 157d0b11d204 ("test/crypto: add capability checks")
> Fixes: b26ef1a11f21 ("test/crypto: fix missing operation status check")
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Akhil Goyal Jan. 28, 2020, 6:18 a.m. UTC | #2
> >
> > Remove one AES GCM scatter-gather unit test repetition
> > and enable this test on QAT (after a fix included in the commit
> > b26ef1a11f21).
> >
> > Fixes: 157d0b11d204 ("test/crypto: add capability checks")
> > Fixes: b26ef1a11f21 ("test/crypto: fix missing operation status check")
> >
> > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Squashed to original commit as they were not applied to Master

Thanks.

Patch
diff mbox series

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 749c3c1b2..12c113848 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -11158,11 +11158,6 @@  test_AES_GCM_auth_encrypt_SGL_out_of_place_1500B_2000B(void)
 static int
 test_AES_GCM_auth_encrypt_SGL_out_of_place_400B_1seg(void)
 {
-	/* This test is not for QAT PMD */
-	if (gbl_driver_id == rte_cryptodev_driver_id_get(
-			RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD)))
-		return -ENOTSUP;
-
 	return test_authenticated_encryption_SGL(
 			&gcm_test_case_8, OUT_OF_PLACE, 400,
 			gcm_test_case_8.plaintext.len);
@@ -11617,8 +11612,6 @@  static struct unit_test_suite cryptodev_testsuite  = {
 		/** AES GCM Authenticated Encryption */
 		TEST_CASE_ST(ut_setup, ut_teardown,
 			test_AES_GCM_auth_encrypt_SGL_in_place_1500B),
-		TEST_CASE_ST(ut_setup, ut_teardown,
-			test_AES_GCM_auth_encrypt_SGL_out_of_place_400B_1seg),
 		TEST_CASE_ST(ut_setup, ut_teardown,
 			test_AES_GCM_auth_encrypt_SGL_out_of_place_400B_400B),
 		TEST_CASE_ST(ut_setup, ut_teardown,