[v2] config: disable all kmods by default from v20.02
diff mbox series

Message ID 20200117191400.893118-1-jerinj@marvell.com
State Accepted
Delegated to: Thomas Monjalon
Headers show
Series
  • [v2] config: disable all kmods by default from v20.02
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/travis-robot warning Travis build: failed
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Jerin Jacob Kollanukkaran Jan. 17, 2020, 7:14 p.m. UTC
From: Jerin Jacob <jerinj@marvell.com>

Based on the techboard meeting held on 2019-11-06,
It's been decided to disable all kmods by default from v20.02.

http://mails.dpdk.org/archives/dev/2019-November/151763.html

Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
v2:
- Updated meson config file to disable the kmods by default(Maxime)
- Updated the release notes(Honnappa)

I am not sure, in which section, we need to update the release notes for
this specific case.I have updated on the "New Features" section.
Thoughts ?

 config/common_linux                    | 2 --
 doc/guides/rel_notes/release_20_02.rst | 5 +++++
 meson_options.txt                      | 2 +-
 3 files changed, 6 insertions(+), 3 deletions(-)

Comments

Thomas Monjalon Jan. 20, 2020, 5:42 p.m. UTC | #1
17/01/2020 20:14, jerinj@marvell.com:
> From: Jerin Jacob <jerinj@marvell.com>
> 
> Based on the techboard meeting held on 2019-11-06,
> It's been decided to disable all kmods by default from v20.02.
> 
> http://mails.dpdk.org/archives/dev/2019-November/151763.html
> 
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> v2:
> - Updated meson config file to disable the kmods by default(Maxime)
> - Updated the release notes(Honnappa)
> 
> I am not sure, in which section, we need to update the release notes for
> this specific case.I have updated on the "New Features" section.
> Thoughts ?

I moved (and reworded a bit) in "Removed Items".

Applied, thanks
Lipiec, Herakliusz Feb. 12, 2020, 5:18 p.m. UTC | #2
This change also affects usertools/dpdk-setup.sh
When following this: https://doc.dpdk.org/guides/linux_gsg/quick_start.html
And trying to insert igb_uio, it gives following error:

## ERROR: Target does not have the DPDK UIO Kernel Module.
       To fix, please try to rebuild target.

Should this script (and docs) be changed too?

Regards,
Herakliusz

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of jerinj@marvell.com
> Sent: Friday, January 17, 2020 7:14 PM
> To: dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>; Mcnamara,
> John <john.mcnamara@intel.com>; Kovacevic, Marko
> <marko.kovacevic@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>
> Cc: techboard@dpdk.org; Jerin Jacob <jerinj@marvell.com>
> Subject: [dpdk-dev] [PATCH v2] config: disable all kmods by default from
> v20.02
> 
> From: Jerin Jacob <jerinj@marvell.com>
> 
> Based on the techboard meeting held on 2019-11-06, It's been decided to
> disable all kmods by default from v20.02.
> 
> http://mails.dpdk.org/archives/dev/2019-November/151763.html
> 
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> v2:
> - Updated meson config file to disable the kmods by default(Maxime)
> - Updated the release notes(Honnappa)
> 
> I am not sure, in which section, we need to update the release notes for this
> specific case.I have updated on the "New Features" section.
> Thoughts ?
> 
>  config/common_linux                    | 2 --
>  doc/guides/rel_notes/release_20_02.rst | 5 +++++
>  meson_options.txt                      | 2 +-
>  3 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/config/common_linux b/config/common_linux index
> c5cf3d662..583efadc7 100644
> --- a/config/common_linux
> +++ b/config/common_linux
> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
> CONFIG_RTE_EXEC_ENV_LINUXAPP=y
> 
>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> -CONFIG_RTE_EAL_IGB_UIO=y
>  CONFIG_RTE_EAL_VFIO=y
> -CONFIG_RTE_KNI_KMOD=y
>  CONFIG_RTE_LIBRTE_KNI=y
>  CONFIG_RTE_LIBRTE_PMD_KNI=y
>  CONFIG_RTE_LIBRTE_VHOST=y
> diff --git a/doc/guides/rel_notes/release_20_02.rst
> b/doc/guides/rel_notes/release_20_02.rst
> index 9cc257168..afd645e7a 100644
> --- a/doc/guides/rel_notes/release_20_02.rst
> +++ b/doc/guides/rel_notes/release_20_02.rst
> @@ -61,6 +61,11 @@ New Features
>    A new API has been added to wait for a memory location to be updated
> with a
>    16-bit, 32-bit, 64-bit value.
> 
> +* **Disabled all the Linux kernel modules build by default.**
> +
> +  In order to remove the build time dependency with Linux kernel,  The
> + techboard decided to disable all the kernel modules build by  default
> + from v20.02 version.
> 
>  Removed Items
>  -------------
> diff --git a/meson_options.txt b/meson_options.txt index
> bc369d06c..53dfe13c3 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -6,7 +6,7 @@ option('drivers_install_subdir', type: 'string', value:
> 'dpdk/pmds-<VERSION>',
>  	description: 'Subdirectory of libdir where to install PMDs. Defaults to
> using a versioned subdirectory.')  option('enable_docs', type: 'boolean',
> value: false,
>  	description: 'build documentation')
> -option('enable_kmods', type: 'boolean', value: true,
> +option('enable_kmods', type: 'boolean', value: false,
>  	description: 'build kernel modules')
>  option('examples', type: 'string', value: '',
>  	description: 'Comma-separated list of examples to build by default')
> --
> 2.24.1
Thomas Monjalon Feb. 12, 2020, 5:39 p.m. UTC | #3
12/02/2020 18:18, Lipiec, Herakliusz:
> This change also affects usertools/dpdk-setup.sh
> When following this: https://doc.dpdk.org/guides/linux_gsg/quick_start.html
> And trying to insert igb_uio, it gives following error:
> 
> ## ERROR: Target does not have the DPDK UIO Kernel Module.
>        To fix, please try to rebuild target.
> 
> Should this script (and docs) be changed too?

Yes, please update scripts and docs to recommend using VFIO.

Patch
diff mbox series

diff --git a/config/common_linux b/config/common_linux
index c5cf3d662..583efadc7 100644
--- a/config/common_linux
+++ b/config/common_linux
@@ -8,9 +8,7 @@  CONFIG_RTE_EXEC_ENV_LINUX=y
 CONFIG_RTE_EXEC_ENV_LINUXAPP=y
 
 CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
-CONFIG_RTE_EAL_IGB_UIO=y
 CONFIG_RTE_EAL_VFIO=y
-CONFIG_RTE_KNI_KMOD=y
 CONFIG_RTE_LIBRTE_KNI=y
 CONFIG_RTE_LIBRTE_PMD_KNI=y
 CONFIG_RTE_LIBRTE_VHOST=y
diff --git a/doc/guides/rel_notes/release_20_02.rst b/doc/guides/rel_notes/release_20_02.rst
index 9cc257168..afd645e7a 100644
--- a/doc/guides/rel_notes/release_20_02.rst
+++ b/doc/guides/rel_notes/release_20_02.rst
@@ -61,6 +61,11 @@  New Features
   A new API has been added to wait for a memory location to be updated with a
   16-bit, 32-bit, 64-bit value.
 
+* **Disabled all the Linux kernel modules build by default.**
+
+  In order to remove the build time dependency with Linux kernel,
+  The techboard decided to disable all the kernel modules build by
+  default from v20.02 version.
 
 Removed Items
 -------------
diff --git a/meson_options.txt b/meson_options.txt
index bc369d06c..53dfe13c3 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -6,7 +6,7 @@  option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>',
 	description: 'Subdirectory of libdir where to install PMDs. Defaults to using a versioned subdirectory.')
 option('enable_docs', type: 'boolean', value: false,
 	description: 'build documentation')
-option('enable_kmods', type: 'boolean', value: true,
+option('enable_kmods', type: 'boolean', value: false,
 	description: 'build kernel modules')
 option('examples', type: 'string', value: '',
 	description: 'Comma-separated list of examples to build by default')