net/ice: fix wrong GTP-U fdir profile
diff mbox series

Message ID 20200117062033.12298-1-qi.z.zhang@intel.com
State Rejected
Delegated to: xiaolong ye
Headers show
Series
  • net/ice: fix wrong GTP-U fdir profile
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/checkpatch success coding style OK

Commit Message

Qi Zhang Jan. 17, 2020, 6:20 a.m. UTC
A GTP-U fdir profile should be regarded as a tunnel type,
or the profile target to inner IPv4 will also cover inner IPv6
packet type due to some side effect.

Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel")
Cc: stable@dpdk.org

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/ice/ice_fdir_filter.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Beilei Xing Jan. 17, 2020, 7:07 a.m. UTC | #1
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Friday, January 17, 2020 2:21 PM
> To: Cao, Yahui <yahui.cao@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ice: fix wrong GTP-U fdir profile
> 
> A GTP-U fdir profile should be regarded as a tunnel type, or the profile target
> to inner IPv4 will also cover inner IPv6 packet type due to some side effect.
> 
> Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>  drivers/net/ice/ice_fdir_filter.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
> index fa8707455..4c5ddfbdb 100644
> --- a/drivers/net/ice/ice_fdir_filter.c
> +++ b/drivers/net/ice/ice_fdir_filter.c
> @@ -987,6 +987,7 @@ ice_fdir_input_set_conf(struct ice_pf *pf, enum
> ice_fltr_ptype flow,
>  		ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_GTPU_EH |
>  				       ICE_FLOW_SEG_HDR_GTPU_IP |
>  				  ICE_FLOW_SEG_HDR_IPV4);
> +		is_tunnel = true;

I think we should fix in ice_fdir_is_tunnel_profile function.

BR,
Beilei

>  		break;
>  	default:
>  		PMD_DRV_LOG(ERR, "not supported filter type.");
> --
> 2.13.6
Qi Zhang Jan. 20, 2020, 5:08 a.m. UTC | #2
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Friday, January 17, 2020 2:21 PM
> To: Cao, Yahui <yahui.cao@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ice: fix wrong GTP-U fdir profile
> 
> A GTP-U fdir profile should be regarded as a tunnel type, or the profile
> target to inner IPv4 will also cover inner IPv6 packet type due to some side
> effect.
> 
> Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>

Nacked-by: Qi Zhang <qi.z.zhang@intel.com>

https://patches.dpdk.org/patch/64903/
should be the prefer fix.

> ---
>  drivers/net/ice/ice_fdir_filter.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ice/ice_fdir_filter.c
> b/drivers/net/ice/ice_fdir_filter.c
> index fa8707455..4c5ddfbdb 100644
> --- a/drivers/net/ice/ice_fdir_filter.c
> +++ b/drivers/net/ice/ice_fdir_filter.c
> @@ -987,6 +987,7 @@ ice_fdir_input_set_conf(struct ice_pf *pf, enum
> ice_fltr_ptype flow,
>  		ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_GTPU_EH |
>  				       ICE_FLOW_SEG_HDR_GTPU_IP |
>  				  ICE_FLOW_SEG_HDR_IPV4);
> +		is_tunnel = true;
>  		break;
>  	default:
>  		PMD_DRV_LOG(ERR, "not supported filter type.");
> --
> 2.13.6

Patch
diff mbox series

diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
index fa8707455..4c5ddfbdb 100644
--- a/drivers/net/ice/ice_fdir_filter.c
+++ b/drivers/net/ice/ice_fdir_filter.c
@@ -987,6 +987,7 @@  ice_fdir_input_set_conf(struct ice_pf *pf, enum ice_fltr_ptype flow,
 		ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_GTPU_EH |
 				       ICE_FLOW_SEG_HDR_GTPU_IP |
 				  ICE_FLOW_SEG_HDR_IPV4);
+		is_tunnel = true;
 		break;
 	default:
 		PMD_DRV_LOG(ERR, "not supported filter type.");