From patchwork Tue Jan 7 15:51:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Roldan X-Patchwork-Id: 64277 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE144A04F3; Tue, 7 Jan 2020 16:51:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9E0C51D9E9; Tue, 7 Jan 2020 16:51:45 +0100 (CET) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 7C4C31D9E0 for ; Tue, 7 Jan 2020 16:51:44 +0100 (CET) Received: by mail-wm1-f67.google.com with SMTP id b19so19449572wmj.4 for ; Tue, 07 Jan 2020 07:51:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bequant-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xcL4wD5lIL9QlOTSr/yoQHsD3EqZfE6gKi2QpdY4tm8=; b=M7NugrbKEkpFi3cgZW75wccGsMrh2eHH37VGuGmvDcJVCk4FGhqUaE0aPYMa1mHJa8 zIuvKmN5j8K29JXLe7UXhjd5KvlDn2ta/7RkuCpdDNAXjWRaEztpPxUxCQuBBx/HfmOl qvoV8FunC+aibXuAoLS29DZ5Si7oh2+BrE3PGur6uiHBc2JYKi5AOIGJtPcVvs5bgC1p rjyoBaOdFnVvAnQKe0vKqbHIR/Ki8o39ONhlRoIeBAbPauJZ/EgBSTCdwvjLnyU3SQSo AYh0f9geqwLW/rgVsBQ/MaWadiky3He6eOm/VxEmIYk6+Gxy04Kf/QvcoV6i632IBTgX NXzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xcL4wD5lIL9QlOTSr/yoQHsD3EqZfE6gKi2QpdY4tm8=; b=aY6YQp8pkeIWci9VkNQTtO8eY8aQ3dsmDviomkY4OTAtaJVDYGIVw5XXPf7d5+pNXG 5SYBbRO7pD6moIEDIO3QQyivD1QdmA1ba1MNg+FC76rxiYOHRESqoLune+w8Hv1sIh21 CJb9bVfXGpgGn/KTwZwYsderFkkExztXdMiEhj1j6oq2xX5f76EwLxoEZR42Wf7CIKba f28Dt3hZszgSIp6tYYspaE2SmBPaV8uIGm6/cLf1JpYSuJe9xvG0UEFLQc75k4DNz+6/ h8mEe27KtjNKmPuEC0eNvrKwTqLybkRUOdBxHWT5TfmuXD2C929NKBl5UsnY74YswuS9 Qq3A== X-Gm-Message-State: APjAAAXwfLStsSdzacuYiraZwtNYP00rArEOz1lS4P+hhMH7+HReYnz2 KX8YnCziEqKgIycQklsopsz1dmUoloc= X-Google-Smtp-Source: APXvYqyMcFFtYNzXugIytritobPWFN79fX6GzeUUAHkVA10/VuT1wryTL6HfKesWpLUTKl/5FKEIqQ== X-Received: by 2002:a7b:cc98:: with SMTP id p24mr39569101wma.139.1578412303917; Tue, 07 Jan 2020 07:51:43 -0800 (PST) Received: from hprr.bequant.com (static-166-190-26-46.ipcom.comunitel.net. [46.26.190.166]) by smtp.gmail.com with ESMTPSA id x6sm9356wmi.44.2020.01.07.07.51.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2020 07:51:43 -0800 (PST) From: Ricardo Roldan To: dev@dpdk.org Cc: Ricardo Roldan Date: Tue, 7 Jan 2020 16:51:36 +0100 Message-Id: <20200107155136.70237-1-rroldan@bequant.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] ethdev: rte_eth_dev_callback_unregister() fails with cb_arg == -1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The function was checking -1 against the callback data instead of the given cb_arg parameter. Signed-off-by: Ricardo Roldan Reviewed-by: Ferruh Yigit --- lib/librte_ethdev/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 6e9cb243e..aec2d0f70 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -4039,7 +4039,7 @@ rte_eth_dev_callback_unregister(uint16_t port_id, next = TAILQ_NEXT(cb, next); if (cb->cb_fn != cb_fn || cb->event != event || - (cb->cb_arg != (void *)-1 && cb->cb_arg != cb_arg)) + (cb_arg != (void *)-1 && cb->cb_arg != cb_arg)) continue; /*