[12/14] ethdev: raise priority of old driver warning
diff mbox series

Message ID 20200104013341.19809-13-stephen@networkplumber.org
State Superseded, archived
Delegated to: David Marchand
Headers show
Series
  • cleanup resources on shutdown
Related show

Checks

Context Check Description
ci/Intel-compilation fail Compilation issues
ci/checkpatch warning coding style issues

Commit Message

Stephen Hemminger Jan. 4, 2020, 1:33 a.m. UTC
The priority of the message about drivers not using new (correct)
behaviour on close was debug. And debug messages are typically surpressed
and never seen.  Raise the priority so that broken drivers are visible
and hopefully get developers to fix.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_ethdev/rte_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon April 25, 2020, 3:53 p.m. UTC | #1
04/01/2020 02:33, Stephen Hemminger:
> The priority of the message about drivers not using new (correct)
> behaviour on close was debug. And debug messages are typically surpressed
> and never seen.  Raise the priority so that broken drivers are visible
> and hopefully get developers to fix.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -1717,7 +1717,7 @@ rte_eth_dev_close(uint16_t port_id)
> -	RTE_ETHDEV_LOG(DEBUG, "Port closing is using an old behaviour.\n"
> +	RTE_ETHDEV_LOG(NOTICE, "Port closing is using an old behaviour.\n"

Acked-by: Thomas Monjalon <thomas@monjalon.net>

PS: I did not notice this patch earlier.
Please, next time, Cc maintainers with this git-send-email option:
	--cc-cmd devtools/get-maintainer.sh

Patch
diff mbox series

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 6e9cb243ea80..545687dbc5c9 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -1717,7 +1717,7 @@  rte_eth_dev_close(uint16_t port_id)
 		rte_eth_dev_release_port(dev);
 		return;
 	}
-	RTE_ETHDEV_LOG(DEBUG, "Port closing is using an old behaviour.\n"
+	RTE_ETHDEV_LOG(NOTICE, "Port closing is using an old behaviour.\n"
 			"The driver %s should migrate to the new behaviour.\n",
 			dev->device->driver->name);
 	/* old behaviour: only free queue arrays */