diff mbox series

net/ipn3ke: fix line side statistics register read

Message ID 1577775227-287186-1-git-send-email-andy.pei@intel.com (mailing list archive)
State Accepted, archived
Delegated to: xiaolong ye
Headers
Series net/ipn3ke: fix line side statistics register read |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Pei, Andy Dec. 31, 2019, 6:53 a.m. UTC 
  To read line side statistics register, eth_group_sel
args in function ipn3ke_indirect_mac_read should be 0.
When eth_group_sel is 1, the nic side register is read.

Fixes: 5a6d883878db ("net/ipn3ke: implement statistics")
Cc: andy.pei@intel.com
Cc: stable@dpdk.org

Signed-off-by: Andy Pei <andy.pei@intel.com>
---
Cc: ferruh.yigit@intel.com
Cc: rosen.xu@intel.com
Cc: xiaolong.ye@intel.com

 drivers/net/ipn3ke/ipn3ke_representor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Xu, Rosen Jan. 2, 2020, 12:36 a.m. UTC | #1 
Hi,

> -----Original Message-----
> From: Pei, Andy <andy.pei@intel.com>
> Sent: Tuesday, December 31, 2019 14:54
> To: dev@dpdk.org
> Cc: Pei, Andy <andy.pei@intel.com>; stable@dpdk.org; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Xu, Rosen <rosen.xu@intel.com>; Ye, Xiaolong
> <xiaolong.ye@intel.com>
> Subject: [PATCH] net/ipn3ke: fix line side statistics register read
> 
> To read line side statistics register, eth_group_sel args in function
> ipn3ke_indirect_mac_read should be 0.
> When eth_group_sel is 1, the nic side register is read.
> 
> Fixes: 5a6d883878db ("net/ipn3ke: implement statistics")
> Cc: andy.pei@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
> Cc: ferruh.yigit@intel.com
> Cc: rosen.xu@intel.com
> Cc: xiaolong.ye@intel.com
> 
>  drivers/net/ipn3ke/ipn3ke_representor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c
> b/drivers/net/ipn3ke/ipn3ke_representor.c
> index 8d9ebef..80122e3 100644
> --- a/drivers/net/ipn3ke/ipn3ke_representor.c
> +++ b/drivers/net/ipn3ke/ipn3ke_representor.c
> @@ -701,7 +701,7 @@ struct ipn3ke_rpst_hw_port_stats *hw_stats)
>  		&tmp,
>  		IPN3KE_25G_TX_STATISTICS_STATUS,
>  		port_id,
> -		1);
> +		0);
>  	if (tmp &
> IPN3KE_25G_TX_STATISTICS_STATUS_SHADOW_REQUEST_MASK) {
>  		tmp = 0x00000000;
>  		(*hw->f_mac_read)(hw,
> --
> 1.8.3.1

Acked-by: Rosen Xu <rosen.xu@intel.com>
Xiaolong Ye Jan. 3, 2020, 7:43 a.m. UTC | #2 
On 12/31, Andy Pei wrote:
>To read line side statistics register, eth_group_sel
>args in function ipn3ke_indirect_mac_read should be 0.
>When eth_group_sel is 1, the nic side register is read.
>
>Fixes: 5a6d883878db ("net/ipn3ke: implement statistics")
>Cc: andy.pei@intel.com
>Cc: stable@dpdk.org
>
>Signed-off-by: Andy Pei <andy.pei@intel.com>
>---
>Cc: ferruh.yigit@intel.com
>Cc: rosen.xu@intel.com
>Cc: xiaolong.ye@intel.com
>
> drivers/net/ipn3ke/ipn3ke_representor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c
>index 8d9ebef..80122e3 100644
>--- a/drivers/net/ipn3ke/ipn3ke_representor.c
>+++ b/drivers/net/ipn3ke/ipn3ke_representor.c
>@@ -701,7 +701,7 @@ struct ipn3ke_rpst_hw_port_stats *hw_stats)
> 		&tmp,
> 		IPN3KE_25G_TX_STATISTICS_STATUS,
> 		port_id,
>-		1);
>+		0);
> 	if (tmp & IPN3KE_25G_TX_STATISTICS_STATUS_SHADOW_REQUEST_MASK) {
> 		tmp = 0x00000000;
> 		(*hw->f_mac_read)(hw,
>-- 
>1.8.3.1
>

Applied to dpdk-next-net-intel, Thanks.
diff mbox series

Patch

diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c
index 8d9ebef..80122e3 100644
--- a/drivers/net/ipn3ke/ipn3ke_representor.c
+++ b/drivers/net/ipn3ke/ipn3ke_representor.c
@@ -701,7 +701,7 @@  struct ipn3ke_rpst_hw_port_stats *hw_stats)
 		&tmp,
 		IPN3KE_25G_TX_STATISTICS_STATUS,
 		port_id,
-		1);
+		0);
 	if (tmp & IPN3KE_25G_TX_STATISTICS_STATUS_SHADOW_REQUEST_MASK) {
 		tmp = 0x00000000;
 		(*hw->f_mac_read)(hw,