diff mbox series

examples/ethtool: fix unchecked return value

Message ID 20191209063756.26790-1-gargi.sau@intel.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series examples/ethtool: fix unchecked return value |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Gargi Sau Dec. 9, 2019, 6:37 a.m. UTC 
  This checks the return value from the function
rte_eth_dev_set_vlan_offload.

Coverity issue: 350358
Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
Cc: stable@dpdk.org

Signed-off-by: Gargi Sau <gargi.sau@intel.com>
---
 examples/ethtool/lib/rte_ethtool.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Bruce Richardson Dec. 9, 2019, 12:07 p.m. UTC | #1 
On Mon, Dec 09, 2019 at 06:37:56AM +0000, Gargi Sau wrote:
> This checks the return value from the function
> rte_eth_dev_set_vlan_offload.
> 
> Coverity issue: 350358
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gargi Sau <gargi.sau@intel.com>
> ---
>  examples/ethtool/lib/rte_ethtool.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c
> index 667d7eaf2..db8150efd 100644
> --- a/examples/ethtool/lib/rte_ethtool.c
> +++ b/examples/ethtool/lib/rte_ethtool.c
> @@ -402,7 +402,9 @@ rte_ethtool_net_set_rx_mode(uint16_t port_id)
>  	}
>  
>  	/* Enable Rx vlan filter, VF unspport status is discard */
> -	rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
> +	ret = rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
> +	if (ret != 0)
> +		return ret;
>  
Looks ok to me.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
David Marchand Feb. 13, 2020, 1:59 p.m. UTC | #2 
On Mon, Dec 9, 2019 at 1:07 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Mon, Dec 09, 2019 at 06:37:56AM +0000, Gargi Sau wrote:
> > This checks the return value from the function
> > rte_eth_dev_set_vlan_offload.
> >
> > Coverity issue: 350358
> > Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Gargi Sau <gargi.sau@intel.com>
> > ---
> >  examples/ethtool/lib/rte_ethtool.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c
> > index 667d7eaf2..db8150efd 100644
> > --- a/examples/ethtool/lib/rte_ethtool.c
> > +++ b/examples/ethtool/lib/rte_ethtool.c
> > @@ -402,7 +402,9 @@ rte_ethtool_net_set_rx_mode(uint16_t port_id)
> >       }
> >
> >       /* Enable Rx vlan filter, VF unspport status is discard */
> > -     rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
> > +     ret = rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
> > +     if (ret != 0)
> > +             return ret;
> >
> Looks ok to me.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c
index 667d7eaf2..db8150efd 100644
--- a/examples/ethtool/lib/rte_ethtool.c
+++ b/examples/ethtool/lib/rte_ethtool.c
@@ -402,7 +402,9 @@  rte_ethtool_net_set_rx_mode(uint16_t port_id)
 	}
 
 	/* Enable Rx vlan filter, VF unspport status is discard */
-	rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
+	ret = rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
+	if (ret != 0)
+		return ret;
 
 	return 0;
 }