net/i40e: fix flow control broken
diff mbox series

Message ID 20191206154118.4401-1-guinanx.sun@intel.com
State Rejected, archived
Delegated to: xiaolong ye
Headers show
Series
  • net/i40e: fix flow control broken
Related show

Checks

Context Check Description
ci/travis-robot warning Travis build: failed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Guinan Sun Dec. 6, 2019, 3:41 p.m. UTC
Repeat switching flow control on or off during receiving traffic,
testpmd reports "failed to switch Tx queue occurs" after quit.
The patch fixes the issue.

Fixes: f53577f06925 ("i40e: support flow control")
Cc: stable@dpdk.org

Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zhang, Qi Z Dec. 8, 2019, 11:51 p.m. UTC | #1
> -----Original Message-----
> From: Sun, GuinanX <guinanx.sun@intel.com>
> Sent: Friday, December 6, 2019 11:41 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Yang, Qiming <qiming.yang@intel.com>; Sun, GuinanX
> <guinanx.sun@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/i40e: fix flow control broken
> 
> Repeat switching flow control on or off during receiving traffic, testpmd reports
> "failed to switch Tx queue occurs" after quit.
> The patch fixes the issue.

The explain more about the root cause and the fix.

> 
> Fixes: f53577f06925 ("i40e: support flow control")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 5999c964b..5507f6c39 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -53,7 +53,7 @@
> 
>  /* Wait count and interval */
>  #define I40E_CHK_Q_ENA_COUNT       1000
> -#define I40E_CHK_Q_ENA_INTERVAL_US 1000
> +#define I40E_CHK_Q_ENA_INTERVAL_US 50000
> 
>  /* Maximun number of VSI */
>  #define I40E_MAX_NUM_VSIS          (384UL)
> --
> 2.17.1
Xiaolong Ye Dec. 16, 2019, 5:06 a.m. UTC | #2
On 12/06, Guinan Sun wrote:
>Repeat switching flow control on or off during receiving traffic,
>testpmd reports "failed to switch Tx queue occurs" after quit.
>The patch fixes the issue.
>
>Fixes: f53577f06925 ("i40e: support flow control")
>Cc: stable@dpdk.org
>
>Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
>---
> drivers/net/i40e/i40e_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>index 5999c964b..5507f6c39 100644
>--- a/drivers/net/i40e/i40e_ethdev.c
>+++ b/drivers/net/i40e/i40e_ethdev.c
>@@ -53,7 +53,7 @@
> 
> /* Wait count and interval */
> #define I40E_CHK_Q_ENA_COUNT       1000
>-#define I40E_CHK_Q_ENA_INTERVAL_US 1000
>+#define I40E_CHK_Q_ENA_INTERVAL_US 50000
> 
> /* Maximun number of VSI */
> #define I40E_MAX_NUM_VSIS          (384UL)
>-- 
>2.17.1
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel, Thanks.
Xiaolong Ye Dec. 16, 2019, 5:22 a.m. UTC | #3
On 12/16, Ye Xiaolong wrote:
>On 12/06, Guinan Sun wrote:
>>Repeat switching flow control on or off during receiving traffic,
>>testpmd reports "failed to switch Tx queue occurs" after quit.
>>The patch fixes the issue.
>>
>>Fixes: f53577f06925 ("i40e: support flow control")
>>Cc: stable@dpdk.org
>>
>>Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
>>---
>> drivers/net/i40e/i40e_ethdev.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>>index 5999c964b..5507f6c39 100644
>>--- a/drivers/net/i40e/i40e_ethdev.c
>>+++ b/drivers/net/i40e/i40e_ethdev.c
>>@@ -53,7 +53,7 @@
>> 
>> /* Wait count and interval */
>> #define I40E_CHK_Q_ENA_COUNT       1000
>>-#define I40E_CHK_Q_ENA_INTERVAL_US 1000
>>+#define I40E_CHK_Q_ENA_INTERVAL_US 50000
>> 
>> /* Maximun number of VSI */
>> #define I40E_MAX_NUM_VSIS          (384UL)
>>-- 
>>2.17.1
>>
>
>Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
>Applied to dpdk-next-net-intel, Thanks.

Sorry, there is still concern about this patch, drop it from next-net-intel first.

Patch
diff mbox series

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 5999c964b..5507f6c39 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -53,7 +53,7 @@ 
 
 /* Wait count and interval */
 #define I40E_CHK_Q_ENA_COUNT       1000
-#define I40E_CHK_Q_ENA_INTERVAL_US 1000
+#define I40E_CHK_Q_ENA_INTERVAL_US 50000
 
 /* Maximun number of VSI */
 #define I40E_MAX_NUM_VSIS          (384UL)