[v2] examples/ioat: resolve unchecked return value
diff mbox series

Message ID 20191128112715.26283-1-praveen.shetty@intel.com
State Accepted
Delegated to: David Marchand
Headers show
Series
  • [v2] examples/ioat: resolve unchecked return value
Related show

Checks

Context Check Description
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-compilation success Compile Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Praveen Shetty Nov. 28, 2019, 11:27 a.m. UTC
patch checks the return value of function rte_eth_dev_info_get,
if return value is negative error message printed on the console.

Coverity issue: 350361
Fixes: c8e6ceecebc1 ("examples/ioat: add new sample app for ioat driver")
Cc: pawelx.modrak@intel.com

Signed-off-by: Praveen Shetty <praveen.shetty@intel.com>
---
 examples/ioat/ioatfwd.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Bruce Richardson Nov. 28, 2019, 11:32 a.m. UTC | #1
On Thu, Nov 28, 2019 at 11:27:14AM +0000, Praveen Shetty wrote:
> patch checks the return value of function rte_eth_dev_info_get,
> if return value is negative error message printed on the console.
> 
> Coverity issue: 350361
> Fixes: c8e6ceecebc1 ("examples/ioat: add new sample app for ioat driver")
> Cc: pawelx.modrak@intel.com
> 
> Signed-off-by: Praveen Shetty <praveen.shetty@intel.com>
> ---
>  examples/ioat/ioatfwd.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Thanks for the fix.
This is non-critical so merge can be deferred to 20.02
David Marchand Feb. 13, 2020, 2 p.m. UTC | #2
On Thu, Nov 28, 2019 at 12:32 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Thu, Nov 28, 2019 at 11:27:14AM +0000, Praveen Shetty wrote:
> > patch checks the return value of function rte_eth_dev_info_get,
> > if return value is negative error message printed on the console.
> >
> > Coverity issue: 350361
> > Fixes: c8e6ceecebc1 ("examples/ioat: add new sample app for ioat driver")

Cc: stable@dpdk.org

> >
> > Signed-off-by: Praveen Shetty <praveen.shetty@intel.com>
> > ---
> >  examples/ioat/ioatfwd.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks.

Patch
diff mbox series

diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c
index e9117718f..b39a098ec 100644
--- a/examples/ioat/ioatfwd.c
+++ b/examples/ioat/ioatfwd.c
@@ -824,7 +824,11 @@  port_init(uint16_t portid, struct rte_mempool *mbuf_pool, uint16_t nb_queues)
 	/* Init port */
 	printf("Initializing port %u... ", portid);
 	fflush(stdout);
-	rte_eth_dev_info_get(portid, &dev_info);
+	ret = rte_eth_dev_info_get(portid, &dev_info);
+	if (ret < 0)
+		rte_exit(EXIT_FAILURE, "Cannot get device info: %s, port=%u\n",
+			rte_strerror(-ret), portid);
+
 	local_port_conf.rx_adv_conf.rss_conf.rss_hf &=
 		dev_info.flow_type_rss_offloads;
 	if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)