From patchwork Wed Nov 6 01:36:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simei Su X-Patchwork-Id: 62498 X-Patchwork-Delegate: xiaolong.ye@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A993FA04A2; Wed, 6 Nov 2019 02:36:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 163B81BFCE; Wed, 6 Nov 2019 02:36:21 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id DB3F11BFCD for ; Wed, 6 Nov 2019 02:36:18 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2019 17:36:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,272,1569308400"; d="scan'208";a="205694238" Received: from npg-dpdk-cvl-simeisu-118d193.sh.intel.com ([10.67.110.183]) by orsmga006.jf.intel.com with ESMTP; 05 Nov 2019 17:36:09 -0800 From: Simei Su To: qi.z.zhang@intel.com, xiaolong.ye@intel.com, qiming.yang@intel.com Cc: dev@dpdk.org, simei.su@intel.com Date: Wed, 6 Nov 2019 09:36:01 +0800 Message-Id: <1573004161-6693-1-git-send-email-simei.su@intel.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-dev] [PATCH] net/ice: change RSS rule destroy API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch changes RSS rule destroy API from ice_rem_vsi_rss_cfg() to ice_rem_rss_cfg(). ice_rem_vsi_rss_cfg() removes RSS configurations associated with VSI. ice_rem_rss_cfg() remove an existing RSS configuration with matching hashed fields. To support input set change, we should adopt ice_rem_rss_cfg(). This patch also fixes logic error otherwise ice_rem_rss_cfg() is never be carried out. Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS") Signed-off-by: Simei Su --- drivers/net/ice/ice_hash.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index 3381b45..ba83a12 100644 --- a/drivers/net/ice/ice_hash.c +++ b/drivers/net/ice/ice_hash.c @@ -464,6 +464,7 @@ struct ice_hash_match_type ice_hash_type_list[] = { "No memory for filter_ptr"); return -ENOMEM; } + filter_ptr->symm = 1; if (hash_function == RTE_ETH_HASH_FUNCTION_SIMPLE_XOR) { /* Enable registers for simple_xor hash function. */ @@ -528,7 +529,8 @@ struct ice_hash_match_type ice_hash_type_list[] = { (1 << VSIQF_HASH_CTL_HASH_SCHEME_S); ICE_WRITE_REG(hw, VSIQF_HASH_CTL(vsi->vsi_id), reg); } else { - ret = ice_rem_vsi_rss_cfg(hw, vsi->idx); + ret = ice_rem_rss_cfg(hw, vsi->idx, + filter_ptr->hashed_flds, filter_ptr->packet_hdr); if (ret) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_HANDLE, NULL,