diff mbox series

[v3,8/9] examples/guest_cli: fix type of cmdline token

Message ID	20191022154310.41238-9-bruce.richardson@intel.com (mailing list archive)
State	Accepted, archived
Headers	From: Bruce Richardson <bruce.richardson@intel.com> To: dev@dpdk.org Cc: Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org Date: Tue, 22 Oct 2019 16:43:09 +0100 Message-Id: <20191022154310.41238-9-bruce.richardson@intel.com> In-Reply-To: <20191022154310.41238-1-bruce.richardson@intel.com> References: <20191014113448.7442-1-bruce.richardson@intel.com> <20191022154310.41238-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 8/9] examples/guest_cli: fix type of cmdline token Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	support all examples in a meson build \| [v3,0/9] support all examples in a meson build [v3,1/9] examples/bpf: remove from list of examples to build [v3,2/9] examples/ethtool: allow building as part of meson build [v3,3/9] examples/performance-thread: remove warning disabling [v3,4/9] examples/performance-thread: add l3fwd-thread to meson [v3,5/9] examples/performance-thread: add pthread shim to meson [v3,6/9] examples/server_node_efd: add node binary to meson build [v3,7/9] examples/server_node_efd: add server binary to meson build [v3,8/9] examples/guest_cli: fix type of cmdline token [v3,9/9] examples/guest_cli: add power manager guest cli to meson

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	success	Compilation OK

Commit Message

Bruce Richardson Oct. 22, 2019, 3:43 p.m. UTC

  Building the example with clang gives the error:

  error: expression which evaluates to zero treated as a null pointer
  constant of type 'const char *' [-Werror,-Wnon-literal-null-conversion]
                        lcore_id, UINT8);
                                  ^~~~~

This error is due to the wrong data type being given for the
cmd_set_cpu_freq_core_num value - it was specified as string rather than
numeric type.

Fixes: f5e5c3347ae3 ("examples/vm_power: cli in guest")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hunt, David Oct. 23, 2019, 10:40 a.m. UTC | #1

On 22/10/2019 16:43, Bruce Richardson wrote:
> Building the example with clang gives the error:
>
>    error: expression which evaluates to zero treated as a null pointer
>    constant of type 'const char *' [-Werror,-Wnon-literal-null-conversion]
>                          lcore_id, UINT8);
>                                    ^~~~~
>
> This error is due to the wrong data type being given for the
> cmd_set_cpu_freq_core_num value - it was specified as string rather than
> numeric type.
>
> Fixes: f5e5c3347ae3 ("examples/vm_power: cli in guest")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---


Acked-by: David Hunt <david.hunt@intel.com>

diff mbox series

Patch

diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
index fe09b0778..610d9aeac 100644
--- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
+++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
@@ -171,7 +171,7 @@  cmd_set_cpu_freq_parsed(void *parsed_result, struct cmdline *cl,
 cmdline_parse_token_string_t cmd_set_cpu_freq =
 	TOKEN_STRING_INITIALIZER(struct cmd_set_cpu_freq_result,
 			set_cpu_freq, "set_cpu_freq");
-cmdline_parse_token_string_t cmd_set_cpu_freq_core_num =
+cmdline_parse_token_num_t cmd_set_cpu_freq_core_num =
 	TOKEN_NUM_INITIALIZER(struct cmd_set_cpu_freq_result,
 			lcore_id, UINT8);
 cmdline_parse_token_string_t cmd_set_cpu_freq_cmd_cmd =