| Message ID | 1571318513-7100-1-git-send-email-anand.sunkad@benisontech.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Ferruh Yigit |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B24F11C11E; Thu, 17 Oct 2019 15:20:54 +0200 (CEST) Received: from IND01-BO1-obe.outbound.protection.outlook.com (mail-eopbgr1390052.outbound.protection.outlook.com [40.107.139.52]) by dpdk.org (Postfix) with ESMTP id 3498D1C0D1 for <dev@dpdk.org>; Thu, 17 Oct 2019 15:20:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j8YiU+pliC1PnBQAcj4WtdG4gPTd/h+v3bSHZ1SD5idcUH8iOW+JMNURO8X8hDEq5o45mHtKcgX4dImNhKcI5tybbDMroE3oL6QlvhD4a+9Uol/UtMGKNubIaHAKwlkY+b6yIHwcwduW5RtYLlyVChq+iTDkTeG0ACxGcUNSgJR1ZZSAdb09bYo2Sljq6SxRRSPPVci/n5A490AVOhChw0RNYs5BCw3OpLsHHNLjZs2b06mjjznwrPEOW+0ZqpgGGUbLwqSmCXGE1yXO1mUwmCxwVnK1SN5tRGeTuScrsyywVe6exuh6exPG6bSurZvlnLeYEXpN4UW5SSRsVqroFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gy3KQObdYRcUKb77PVAKHAuDK1nJAbW5Bj55t9WSTik=; b=WzIbeUhl2vnJ+NhXgkN/WImh78G60++pNCqQcnycAcjg52k88pDKb2tNkmCtXdK3kdwiC38XELWVa5QI97xDrIG/lLRm5XiS2vnS1h5AWiLcM5ZvIy/rqlZ4BKwyXUTnzR07mh0WmwdKI0lI0wjl/ACBMr3k3zJ8hDGm+Gad1pZtOGTM9Gfsb6V70vljice4yV+/FS5g6Te1olof3U6xIfUlZV44l5SRLa6ASYtGIrJ5dstf21oYHw/Z6dFUKfO7EGMYylNkq+G9HxfyX12797BY0gnio6xkNNerzge4eq6tjbhPYAv6z+61rUA5ju8cNtDQkhSqnNVedd4+JYni3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=benisontech.com; dmarc=pass action=none header.from=benisontech.com; dkim=pass header.d=benisontech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=benisontech.onmicrosoft.com; s=selector2-benisontech-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gy3KQObdYRcUKb77PVAKHAuDK1nJAbW5Bj55t9WSTik=; b=aEx5wdHLwEvhfL5ZPOC6Bgr85qqpWwzWhPHPKbqrf1qoB0DdlXzstY/R2TWKR4nACmpv7fkTAKZE4tVbsvBzkF4QG9JLg4GvoOl8duh9eILuMjlqAniVDAnGjJXuoXx3Gss1oJn4BDrMHhfWG5qu9HfOHB7gJvPZwUb7MhhQzKQ= Received: from BM1PR0101MB1492.INDPRD01.PROD.OUTLOOK.COM (52.133.128.140) by BM1PR0101MB1521.INDPRD01.PROD.OUTLOOK.COM (10.174.223.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.22; Thu, 17 Oct 2019 13:20:50 +0000 Received: from BM1PR0101MB1492.INDPRD01.PROD.OUTLOOK.COM ([fe80::cc3f:3130:34ad:6130]) by BM1PR0101MB1492.INDPRD01.PROD.OUTLOOK.COM ([fe80::cc3f:3130:34ad:6130%11]) with mapi id 15.20.2347.023; Thu, 17 Oct 2019 13:20:50 +0000 From: Anand Sunkad <anand.sunkad@benisontech.com> To: Jakub Grajciar <jgrajcia@cisco.com> CC: "dev@dpdk.org" <dev@dpdk.org>, Vivek Gupta <vivekg@benisontech.com>, Thomas Mulamangalath <thomas.mulamangalath@benisontech.com>, Anand Sunkad <anand.sunkad@benisontech.com> Thread-Topic: [PATCH] net/memif: add multiple memif data transmission support Thread-Index: AQHVhCS3QhB6QP0RNke/c6zAlcP55ade02SA Date: Thu, 17 Oct 2019 13:20:50 +0000 Message-ID: <1571318513-7100-1-git-send-email-anand.sunkad@benisontech.com> References: <1571232181-5874-1-git-send-email-anand.sunkad@benisontech.com> In-Reply-To: <1571232181-5874-1-git-send-email-anand.sunkad@benisontech.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BMXPR01CA0050.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:2c::14) To BM1PR0101MB1492.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:21::12) authentication-results: spf=none (sender IP is ) smtp.mailfrom=anand.sunkad@benisontech.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 1.9.1 x-originating-ip: [106.51.39.163] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dca03254-84c3-48ee-8224-08d75304d44b x-ms-traffictypediagnostic: BM1PR0101MB1521: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <BM1PR0101MB15214CC75C32D770A11FBAFF916D0@BM1PR0101MB1521.INDPRD01.PROD.OUTLOOK.COM> x-ms-oob-tlc-oobclassifiers: OLM:3173; x-forefront-prvs: 01930B2BA8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(39830400003)(366004)(396003)(136003)(199004)(189003)(9456002)(14454004)(486006)(5660300002)(446003)(44832011)(11346002)(476003)(107886003)(50226002)(2616005)(8936002)(86362001)(508600001)(81156014)(81166006)(7736002)(6512007)(36756003)(6486002)(305945005)(256004)(6436002)(66946007)(64756008)(66556008)(66476007)(66446008)(8676002)(26005)(186003)(4326008)(52116002)(76176011)(99286004)(55236004)(66066001)(6506007)(386003)(102836004)(71190400001)(2906002)(71200400001)(25786009)(316002)(6116002)(3846002)(54906003)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:BM1PR0101MB1521; H:BM1PR0101MB1492.INDPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: benisontech.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K0ZYN8OMfZcZg82GDZ5a0CoIyvGEo/EYtZwk+EAGU8/I2EDNQry+LjfeOZMjdeYejKWaPTP/rhAp14I2BjMOgjsBIqtqO2E3q4b0qVpiJZsFo0gLTJ3IJ8GuANM7igunDcAsM17bp/E38iG/xmonJSorEREXnGVpdCdjhqCeWnVQ8zjDcE1hxoRMYHhVRsDii2Xy+JjNEDdtsqh9UibA+OubkoPdHqLFDiA9LAQhlDyFNqcP0cGs3Yy19rUt9QY9tzUW/FcS013dO1ZGXQzb/IT0hK5iMIUJgClBEcyC5vpTtt67ECb1qUJ4+Z1ifAxEoPX+U8MbWy/XV2/4Vjdfak1jhgmVFc/HuRxTdDkGUGD1VwrWeUZS6//h0DiqGjOOJJAuhwRZZKmfiWfPLGuNQ6lMRJS393mU8Gn5NnvsyZQ= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: benisontech.com X-MS-Exchange-CrossTenant-Network-Message-Id: dca03254-84c3-48ee-8224-08d75304d44b X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2019 13:20:50.6715 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 9e8138c9-2fcf-4503-a2f2-bd5cb21da406 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Wto00y+fpps3HUvJGpoq5SQVoCq8EcGDxKVhxlhwkmJ6w8zmZ5nC2bTBBLQCtnMLwCpG3Zjcgzl8pxuc39YzOnocQnIfy5XtsAwAEzOT9nk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BM1PR0101MB1521 Subject: [dpdk-dev] [PATCH] net/memif: add multiple memif data transmission support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
net/memif: add multiple memif data transmission support
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/Intel-compilation | success | Compilation OK |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-compilation | success | Compile Testing PASS |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/travis-robot | success | Travis build: passed |
Commit Message
Anand Sunkad
Oct. 17, 2019, 1:20 p.m. UTC
When Multiple slave/master Memif's interfaces are created in single
process data transmission over second connection is not successful.
Issue is because of "mq->in_port" is not initialized with
"dev->data->port_id" in memif_tx_queue_setup() function, and while
transmitting packets over second connection in eth_memif_tx function
it refer "mq->in_port" which is always zero, which leads to data
transmission always in 0th port.
To mitigate the issue,"mq->in_port" is initialized with
"dev->data->port_id" in memif_tx_queue_setup() function.
Signed-off-by: Anand Sunkad <anand.sunkad@benisontech.com>
---
drivers/net/memif/rte_eth_memif.c | 1 +
1 file changed, 1 insertion(+)
Comments
Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
Oct. 23, 2019, 8:45 a.m. UTC |
#1
Addressed
Unaddressed
> -----Original Message----- > From: Anand Sunkad <anand.sunkad@benisontech.com> > Sent: Thursday, October 17, 2019 3:21 PM > To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) > <jgrajcia@cisco.com> > Cc: dev@dpdk.org; Vivek Gupta <vivekg@benisontech.com>; Thomas > Mulamangalath <thomas.mulamangalath@benisontech.com>; Anand Sunkad > <anand.sunkad@benisontech.com> > Subject: [PATCH] net/memif: add multiple memif data transmission support > > When Multiple slave/master Memif's interfaces are created in single > process data transmission over second connection is not successful. > > Issue is because of "mq->in_port" is not initialized with > "dev->data->port_id" in memif_tx_queue_setup() function, and while > transmitting packets over second connection in eth_memif_tx function > it refer "mq->in_port" which is always zero, which leads to data > transmission always in 0th port. > > To mitigate the issue,"mq->in_port" is initialized with > "dev->data->port_id" in memif_tx_queue_setup() function. > > Signed-off-by: Anand Sunkad <anand.sunkad@benisontech.com> Reviewed-by: Jakub Grajciar <jgrajcia@cisco.com>
On 10/23/2019 9:45 AM, Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) wrote: > > >> -----Original Message----- >> From: Anand Sunkad <anand.sunkad@benisontech.com> >> Sent: Thursday, October 17, 2019 3:21 PM >> To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) >> <jgrajcia@cisco.com> >> Cc: dev@dpdk.org; Vivek Gupta <vivekg@benisontech.com>; Thomas >> Mulamangalath <thomas.mulamangalath@benisontech.com>; Anand Sunkad >> <anand.sunkad@benisontech.com> >> Subject: [PATCH] net/memif: add multiple memif data transmission support >> >> When Multiple slave/master Memif's interfaces are created in single >> process data transmission over second connection is not successful. >> >> Issue is because of "mq->in_port" is not initialized with >> "dev->data->port_id" in memif_tx_queue_setup() function, and while >> transmitting packets over second connection in eth_memif_tx function >> it refer "mq->in_port" which is always zero, which leads to data >> transmission always in 0th port. >> >> To mitigate the issue,"mq->in_port" is initialized with >> "dev->data->port_id" in memif_tx_queue_setup() function. >> >> Signed-off-by: Anand Sunkad <anand.sunkad@benisontech.com> > > Reviewed-by: Jakub Grajciar <jgrajcia@cisco.com> > Applied to dpdk-next-net/master, thanks.
diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index b86d7da..af7f7f8 100644 --- a/drivers/net/memif/rte_eth_memif.c +++ b/drivers/net/memif/rte_eth_memif.c @@ -873,6 +873,7 @@ struct mp_region_msg { mq->n_bytes = 0; mq->intr_handle.fd = -1; mq->intr_handle.type = RTE_INTR_HANDLE_EXT; + mq->in_port = dev->data->port_id; dev->data->tx_queues[qid] = mq; return 0;