[3/4] net/hns3: Renew command and desc structure
diff mbox series

Message ID 20191009141653.39364-4-xavier.huwei@tom.com
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers show
Series
  • updates for hns3 ethernet pmd driver
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply issues

Commit Message

Wei Hu (Xavier) Oct. 9, 2019, 2:16 p.m. UTC
From: humin <humin29@huawei.com>

This patch adds commands and modifies descriptor structures for
accessing manage table and mac table.

Signed-off-by: humin <humin29@huawei.com>
Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
---
 drivers/net/hns3/hns3_cmd.h | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Comments

Ferruh Yigit Oct. 15, 2019, 8:45 a.m. UTC | #1
On 10/9/2019 3:16 PM, Wei Hu (Xavier) wrote:
> From: humin <humin29@huawei.com>
> 
> This patch adds commands and modifies descriptor structures for
> accessing manage table and mac table.
> 
> Signed-off-by: humin <humin29@huawei.com>

Can you please provide a "Name Surname <email@address.com>" format?

> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
> ---
>  drivers/net/hns3/hns3_cmd.h | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/hns3/hns3_cmd.h b/drivers/net/hns3/hns3_cmd.h
> index be0ecbe86..13a3b87d5 100644
> --- a/drivers/net/hns3/hns3_cmd.h
> +++ b/drivers/net/hns3/hns3_cmd.h
> @@ -217,6 +217,8 @@ enum hns3_opcode_type {
>  	/* PPP module intr commands */
>  	HNS3_PPP_CMD0_INT_CMD                   = 0x2100,
>  	HNS3_PPP_CMD1_INT_CMD                   = 0x2101,
> +	HNS3_PPP_MAC_VLAN_IDX_RD                = 0x2104,
> +	HNS3_MAC_ETHERTYPE_IDX_RD               = 0x2105,
>  };
>  
>  #define HNS3_CMD_FLAG_IN	BIT(0)
> @@ -642,7 +644,7 @@ struct hns3_mac_mgr_tbl_entry_cmd {
>  	uint16_t  vlan_tag;
>  	uint32_t  mac_addr_hi32;
>  	uint16_t  mac_addr_lo16;
> -	uint16_t  rsv1;
> +	uint16_t  index;
>  	uint16_t  ethter_type;
>  	uint16_t  egress_port;
>  	uint16_t  egress_queue;
> @@ -707,12 +709,13 @@ struct hns3_mac_vlan_tbl_entry_cmd {
>  	uint16_t  vlan_tag;
>  	uint32_t  mac_addr_hi32;
>  	uint16_t  mac_addr_lo16;
> -	uint16_t  rsv1;
> +	uint16_t  port;
>  	uint8_t   entry_type;
>  	uint8_t   mc_mac_en;
>  	uint16_t  egress_port;
>  	uint16_t  egress_queue;
> -	uint8_t   rsv2[6];
> +	uint8_t   rsv2[2];
> +	uint32_t  index;
>  };
>  

Aren't these new fields and defines used at all? If not why added?
Wei Hu (Xavier) Oct. 25, 2019, 12:34 p.m. UTC | #2
Hi, Ferruh Yigit


On 2019/10/15 16:45, Ferruh Yigit wrote:
> On 10/9/2019 3:16 PM, Wei Hu (Xavier) wrote:
>> From: humin <humin29@huawei.com>
>>
>> This patch adds commands and modifies descriptor structures for
>> accessing manage table and mac table.
>>
>> Signed-off-by: humin <humin29@huawei.com>
> Can you please provide a "Name Surname <email@address.com>" format?
>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>> ---
>>  drivers/net/hns3/hns3_cmd.h | 9 ++++++---
>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/hns3/hns3_cmd.h b/drivers/net/hns3/hns3_cmd.h
>> index be0ecbe86..13a3b87d5 100644
>> --- a/drivers/net/hns3/hns3_cmd.h
>> +++ b/drivers/net/hns3/hns3_cmd.h
>> @@ -217,6 +217,8 @@ enum hns3_opcode_type {
>>  	/* PPP module intr commands */
>>  	HNS3_PPP_CMD0_INT_CMD                   = 0x2100,
>>  	HNS3_PPP_CMD1_INT_CMD                   = 0x2101,
>> +	HNS3_PPP_MAC_VLAN_IDX_RD                = 0x2104,
>> +	HNS3_MAC_ETHERTYPE_IDX_RD               = 0x2105,
>>  };
>>  
>>  #define HNS3_CMD_FLAG_IN	BIT(0)
>> @@ -642,7 +644,7 @@ struct hns3_mac_mgr_tbl_entry_cmd {
>>  	uint16_t  vlan_tag;
>>  	uint32_t  mac_addr_hi32;
>>  	uint16_t  mac_addr_lo16;
>> -	uint16_t  rsv1;
>> +	uint16_t  index;
>>  	uint16_t  ethter_type;
>>  	uint16_t  egress_port;
>>  	uint16_t  egress_queue;
>> @@ -707,12 +709,13 @@ struct hns3_mac_vlan_tbl_entry_cmd {
>>  	uint16_t  vlan_tag;
>>  	uint32_t  mac_addr_hi32;
>>  	uint16_t  mac_addr_lo16;
>> -	uint16_t  rsv1;
>> +	uint16_t  port;
>>  	uint8_t   entry_type;
>>  	uint8_t   mc_mac_en;
>>  	uint16_t  egress_port;
>>  	uint16_t  egress_queue;
>> -	uint8_t   rsv2[6];
>> +	uint8_t   rsv2[2];
>> +	uint32_t  index;
>>  };
>>  
> Aren't these new fields and defines used at all? If not why added?
In fact ,this patch used for some query function in future.
We will remove this patch from this series.
Thanks for your comments.

    Regards
Xavier
>
>

Patch
diff mbox series

diff --git a/drivers/net/hns3/hns3_cmd.h b/drivers/net/hns3/hns3_cmd.h
index be0ecbe86..13a3b87d5 100644
--- a/drivers/net/hns3/hns3_cmd.h
+++ b/drivers/net/hns3/hns3_cmd.h
@@ -217,6 +217,8 @@  enum hns3_opcode_type {
 	/* PPP module intr commands */
 	HNS3_PPP_CMD0_INT_CMD                   = 0x2100,
 	HNS3_PPP_CMD1_INT_CMD                   = 0x2101,
+	HNS3_PPP_MAC_VLAN_IDX_RD                = 0x2104,
+	HNS3_MAC_ETHERTYPE_IDX_RD               = 0x2105,
 };
 
 #define HNS3_CMD_FLAG_IN	BIT(0)
@@ -642,7 +644,7 @@  struct hns3_mac_mgr_tbl_entry_cmd {
 	uint16_t  vlan_tag;
 	uint32_t  mac_addr_hi32;
 	uint16_t  mac_addr_lo16;
-	uint16_t  rsv1;
+	uint16_t  index;
 	uint16_t  ethter_type;
 	uint16_t  egress_port;
 	uint16_t  egress_queue;
@@ -707,12 +709,13 @@  struct hns3_mac_vlan_tbl_entry_cmd {
 	uint16_t  vlan_tag;
 	uint32_t  mac_addr_hi32;
 	uint16_t  mac_addr_lo16;
-	uint16_t  rsv1;
+	uint16_t  port;
 	uint8_t   entry_type;
 	uint8_t   mc_mac_en;
 	uint16_t  egress_port;
 	uint16_t  egress_queue;
-	uint8_t   rsv2[6];
+	uint8_t   rsv2[2];
+	uint32_t  index;
 };
 
 #define HNS3_TQP_RESET_B	0