diff mbox series

net/mlx4: remove dependency on libmnl in meson

Message ID 1570026250-3582-1-git-send-email-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series net/mlx4: remove dependency on libmnl in meson |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-compilation success Compile Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

David Marchand Oct. 2, 2019, 2:24 p.m. UTC 
  There is no dependency on this library for mlx4.

Fixes: 1dd7c7e38c19 ("net/mlx4: support meson build")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/net/mlx4/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon Oct. 2, 2019, 3:17 p.m. UTC | #1 
02/10/2019 16:24, David Marchand:
> There is no dependency on this library for mlx4.
> 
> Fixes: 1dd7c7e38c19 ("net/mlx4: support meson build")
> Cc: stable@dpdk.org

It seems this dependency was added by mistake.
It was used in mlx5 for TC Flower, and has been dropped recently.
David Marchand Oct. 2, 2019, 3:23 p.m. UTC | #2 
On Wed, Oct 2, 2019 at 5:18 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 02/10/2019 16:24, David Marchand:
> > There is no dependency on this library for mlx4.
> >
> > Fixes: 1dd7c7e38c19 ("net/mlx4: support meson build")
> > Cc: stable@dpdk.org
>
> It seems this dependency was added by mistake.
> It was used in mlx5 for TC Flower, and has been dropped recently.

Yes, most likely a copy/paste from mlx5 at the time of 1dd7c7e38c19.
Raslan Darawsheh Oct. 20, 2019, 7:53 a.m. UTC | #3 
Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of David Marchand
> Sent: Wednesday, October 2, 2019 5:24 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Matan Azrad <matan@mellanox.com>; Shahaf Shuler
> <shahafs@mellanox.com>
> Subject: [dpdk-dev] [PATCH] net/mlx4: remove dependency on libmnl in
> meson
> 
> There is no dependency on this library for mlx4.
> 
> Fixes: 1dd7c7e38c19 ("net/mlx4: support meson build")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Raslan Darawsheh <rasland@mellanox.com>



Patch applied to next-net-mlx,

Kindest regards
Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build
index efee457..e6795ee 100644
--- a/drivers/net/mlx4/meson.build
+++ b/drivers/net/mlx4/meson.build
@@ -21,7 +21,7 @@  if pmd_dlopen
 	]
 endif
 
-libnames = [ 'mnl', 'mlx4', 'ibverbs' ]
+libnames = [ 'mlx4', 'ibverbs' ]
 libs = []
 foreach libname:libnames
 	lib = dependency('lib' + libname, required:false)