From patchwork Tue Jun 30 22:21:34 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 5994 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 1B89DC386; Wed, 1 Jul 2015 00:22:48 +0200 (CEST) Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id C80BDC386 for ; Wed, 1 Jul 2015 00:22:46 +0200 (CEST) Received: by wguu7 with SMTP id u7so21385056wgu.3 for ; Tue, 30 Jun 2015 15:22:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Y4pSPUWnE7Eg2gMDIZowpVp/YJ/9st2U9FZcHW8HXv8=; b=VPz8tHOSuN8h8AIx0FXrZss9c6lU5mlgy0XMrs+FxG1O6O0/y2eYyOrILAIlgpHZGH 2wLQmTsIJhHo0j2W742Pdkm0r0SAPCO81kpZ8tqqE22t6fnP0QYtIMNEtTqAsNKRxc+H nDiwOl8SIcZyovQS79WdO9QbjsY0OIkOjmCDgsKGe4La6PwThKwomP7koQaqVDbMnDH8 FE9KNklSikcXwYyAsqom2cTnPfOxv5ZJXJvOt4kaLHYzgEUagZwOFlckABRkWzJ+UmQN 0IKVhrU7E8A2QqIH7ICXfeAT6GP//4FJNXUE/NpCFKlbS7VyjBRHoNMT2qBoNf7qz4vZ ZiQA== X-Gm-Message-State: ALoCoQlvaUKTwa4bfzOZl6lDh5ZZ3I4AUaLP81ikqvoiqirqa978jf3RWoKxborln4M57BQm2enO X-Received: by 10.194.248.227 with SMTP id yp3mr45061526wjc.32.1435702966280; Tue, 30 Jun 2015 15:22:46 -0700 (PDT) Received: from XPS13.localdomain (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by mx.google.com with ESMTPSA id ef10sm71028366wjd.49.2015.06.30.15.22.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 30 Jun 2015 15:22:45 -0700 (PDT) From: Thomas Monjalon To: Rahul Lakkireddy Date: Wed, 1 Jul 2015 00:21:34 +0200 Message-Id: <1435702894-11781-1-git-send-email-thomas.monjalon@6wind.com> X-Mailer: git-send-email 2.4.2 Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH] cxgbe: fix build with clang X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" GCC_VERSION is empty in case of clang: /bin/sh: line 0: test: -ge: unary operator expected It cannot be quoted because an integer is expected. So the fix is to check empty value in a separate test. Signed-off-by: Thomas Monjalon --- drivers/net/cxgbe/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) This patch is already applied. diff --git a/drivers/net/cxgbe/Makefile b/drivers/net/cxgbe/Makefile index 4dfc6b0..ae12d75 100644 --- a/drivers/net/cxgbe/Makefile +++ b/drivers/net/cxgbe/Makefile @@ -52,9 +52,9 @@ ifeq ($(CC), icc) CFLAGS_BASE_DRIVER = -wd174 -wd593 -wd869 -wd981 -wd2259 else # -# CFLAGS for gcc +# CFLAGS for gcc/clang # -ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1) +ifeq ($(shell test $(CC) = gcc && test $(GCC_VERSION) -ge 44 && echo 1), 1) CFLAGS += -Wno-deprecated endif CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value