crypto/qat: fix digest length in XCBC capability

Message ID 1568133130-18757-1-git-send-email-fiona.trahe@intel.com
State Accepted
Delegated to: akhil goyal
Headers show
Series
  • crypto/qat: fix digest length in XCBC capability
Related show

Checks

Context Check Description
ci/mellanox-Performance success Performance Testing PASS
ci/intel-Performance success Performance Testing PASS
ci/iol-dpdk_compile_ovs success Compile Testing PASS
ci/iol-dpdk_compile success Compile Testing PASS
ci/iol-dpdk_compile_spdk success Compile Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Fiona Trahe Sept. 10, 2019, 4:32 p.m.
Digest length in RTE_CRYPTO_AUTH_AES_XCBC_MAC capability
was incorrectly marked 16 bytes, should be 12.

Fixes: 6a3c87bc6a6c ("crypto/qat: refactor capabilities infrastructure")
cc: stable@dpdk.org

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
---
 drivers/crypto/qat/qat_sym_capabilities.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Kusztal, ArkadiuszX Sept. 13, 2019, 11:03 a.m. | #1
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Tuesday, September 10, 2019 6:32 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; Kusztal,
> ArkadiuszX <arkadiuszx.kusztal@intel.com>; stable@dpdk.org
> Subject: [PATCH] crypto/qat: fix digest length in XCBC capability
> 
> Digest length in RTE_CRYPTO_AUTH_AES_XCBC_MAC capability was
> incorrectly marked 16 bytes, should be 12.
> 
> Fixes: 6a3c87bc6a6c ("crypto/qat: refactor capabilities infrastructure")
> cc: stable@dpdk.org
> 
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
>  drivers/crypto/qat/qat_sym_capabilities.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/qat/qat_sym_capabilities.h
> b/drivers/crypto/qat/qat_sym_capabilities.h
> index 6df12b9..a7fb6a0 100644
> --- a/drivers/crypto/qat/qat_sym_capabilities.h
> +++ b/drivers/crypto/qat/qat_sym_capabilities.h
> @@ -145,8 +145,8 @@
>  					.increment = 0			\
>  				},					\
>  				.digest_size = {			\
> -					.min = 16,			\
> -					.max = 16,			\
> +					.min = 12,			\
> +					.max = 12,			\
>  					.increment = 0			\
>  				},					\
>  				.aad_size = { 0 },			\
> --
> 1.7.0.7

Acked-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Akhil Goyal Sept. 19, 2019, 3:12 p.m. | #2
> >
> > Digest length in RTE_CRYPTO_AUTH_AES_XCBC_MAC capability was
> > incorrectly marked 16 bytes, should be 12.
> >
> > Fixes: 6a3c87bc6a6c ("crypto/qat: refactor capabilities infrastructure")
> > cc: stable@dpdk.org
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> > ---
> Acked-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>

Applied to dpdk-next-crypto

Thanks.

Patch

diff --git a/drivers/crypto/qat/qat_sym_capabilities.h b/drivers/crypto/qat/qat_sym_capabilities.h
index 6df12b9..a7fb6a0 100644
--- a/drivers/crypto/qat/qat_sym_capabilities.h
+++ b/drivers/crypto/qat/qat_sym_capabilities.h
@@ -145,8 +145,8 @@ 
 					.increment = 0			\
 				},					\
 				.digest_size = {			\
-					.min = 16,			\
-					.max = 16,			\
+					.min = 12,			\
+					.max = 12,			\
 					.increment = 0			\
 				},					\
 				.aad_size = { 0 },			\