vhost: remove rte_vhost_va_from_guest_pa from map file

Message ID 156621948797.9571.17549862831374094643.stgit@jrharri1-skx
State Superseded
Headers show
Series
  • vhost: remove rte_vhost_va_from_guest_pa from map file
Related show

Checks

Context Check Description
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/iol-Compile-Testing success Compile Testing PASS
ci/Intel-compilation fail Compilation issues
ci/checkpatch success coding style OK

Commit Message

Jim Harris Aug. 19, 2019, 12:58 p.m.
This function is declared __rte_always_inline so it
seems unnecessary to include it in the map file.  In
addition, it was included in the EXPERIMENTAL section
even though the function itself is not marked
__rte_experimental.

Found by check-experimental-syms.sh when trying to compile
DPDK with -finstrument-functions.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
---
 lib/librte_vhost/rte_vhost_version.map |    1 -
 1 file changed, 1 deletion(-)

Comments

Tiwei Bie Aug. 20, 2019, 5:14 a.m. | #1
On Mon, Aug 19, 2019 at 05:58:08AM -0700, Jim Harris wrote:
> This function is declared __rte_always_inline so it
> seems unnecessary to include it in the map file.  In
> addition, it was included in the EXPERIMENTAL section
> even though the function itself is not marked
> __rte_experimental.
> 
> Found by check-experimental-syms.sh when trying to compile
> DPDK with -finstrument-functions.
> 
> Signed-off-by: Jim Harris <james.r.harris@intel.com>
> ---
>  lib/librte_vhost/rte_vhost_version.map |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map
> index 5f1d4a75c..4908b9b21 100644
> --- a/lib/librte_vhost/rte_vhost_version.map
> +++ b/lib/librte_vhost/rte_vhost_version.map
> @@ -82,7 +82,6 @@ EXPERIMENTAL {
>  	rte_vhost_crypto_fetch_requests;
>  	rte_vhost_crypto_finalize_requests;
>  	rte_vhost_crypto_set_zero_copy;
> -	rte_vhost_va_from_guest_pa;
>  	rte_vhost_host_notifier_ctrl;
>  	rte_vdpa_relay_vring_used;
>  	rte_vhost_extern_callback_register;
> 

It might be better to mark this function with __rte_experimental
to fix the build with -finstrument-functions, as in this way we can
also get warned when using it with ALLOW_EXPERIMENTAL_API undefined.
And we can have another patch to promote it to stable.

Thanks,
Tiwei
David Marchand Aug. 20, 2019, 1:08 p.m. | #2
On Tue, Aug 20, 2019 at 7:16 AM Tiwei Bie <tiwei.bie@intel.com> wrote:
>
> On Mon, Aug 19, 2019 at 05:58:08AM -0700, Jim Harris wrote:
> > This function is declared __rte_always_inline so it
> > seems unnecessary to include it in the map file.  In
> > addition, it was included in the EXPERIMENTAL section
> > even though the function itself is not marked
> > __rte_experimental.
> >
> > Found by check-experimental-syms.sh when trying to compile
> > DPDK with -finstrument-functions.
> >
> > Signed-off-by: Jim Harris <james.r.harris@intel.com>
> > ---
> >  lib/librte_vhost/rte_vhost_version.map |    1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map
> > index 5f1d4a75c..4908b9b21 100644
> > --- a/lib/librte_vhost/rte_vhost_version.map
> > +++ b/lib/librte_vhost/rte_vhost_version.map
> > @@ -82,7 +82,6 @@ EXPERIMENTAL {
> >       rte_vhost_crypto_fetch_requests;
> >       rte_vhost_crypto_finalize_requests;
> >       rte_vhost_crypto_set_zero_copy;
> > -     rte_vhost_va_from_guest_pa;
> >       rte_vhost_host_notifier_ctrl;
> >       rte_vdpa_relay_vring_used;
> >       rte_vhost_extern_callback_register;
> >
>
> It might be better to mark this function with __rte_experimental
> to fix the build with -finstrument-functions, as in this way we can
> also get warned when using it with ALLOW_EXPERIMENTAL_API undefined.
> And we can have another patch to promote it to stable.

+1.


--
David Marchand

Patch

diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map
index 5f1d4a75c..4908b9b21 100644
--- a/lib/librte_vhost/rte_vhost_version.map
+++ b/lib/librte_vhost/rte_vhost_version.map
@@ -82,7 +82,6 @@  EXPERIMENTAL {
 	rte_vhost_crypto_fetch_requests;
 	rte_vhost_crypto_finalize_requests;
 	rte_vhost_crypto_set_zero_copy;
-	rte_vhost_va_from_guest_pa;
 	rte_vhost_host_notifier_ctrl;
 	rte_vdpa_relay_vring_used;
 	rte_vhost_extern_callback_register;