net/vmxnet3: remove IP checksum from Tx/Rx offload capa
diff mbox series

Message ID 20190813132947.13047-1-maxime.leroy@6wind.com
State Accepted
Delegated to: Ferruh Yigit
Headers show
Series
  • net/vmxnet3: remove IP checksum from Tx/Rx offload capa
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-Compile-Testing success Compile Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

Maxime Leroy Aug. 13, 2019, 1:29 p.m. UTC
The vmxnet3_prep_pkts function set rte_errno to ENOTSUP for any packets
having PKT_TX_IP_CHECKSUM set in ol_flags. But the vmxnet3 has
DEV_TX_OFFLOAD_IPV4_CKSUM set in this tx offload capa.

This issue has been introduced with the new Rx offload
API. DEV_TX_OFFLOAD_IPV4_CKSUM and DEV_RX_OFFLOAD_IPV4_CKSUM has been
added to the tx/rx offloads capa, but the vmxnet3 driver doesn't support
it.

To fix the issue, DEV_TX/RX_OFFLOAD_IPV4_CKSUM needs to be removed from
tx/rx offload capa.

Fixes: 95e4a96ccbf1 ("net/vmxnet3: convert to new Rx offload API")
Cc: llouis@vmware.com
Cc: stable@dpdk.org

Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Louis Luo Aug. 19, 2019, 9:56 p.m. UTC | #1
Hi Maxime,

Thanks for the fix. Actually Yong and I had some discussion about removing TX IP CSUM offload flag last August and I did prepare a fix but later forgot to submit. Anyway your fix is fine.

Thanks,
Louis

On 8/13/19, 6:30 AM, "Maxime Leroy" <maxime.leroy@6wind.com> wrote:

    The vmxnet3_prep_pkts function set rte_errno to ENOTSUP for any packets
    having PKT_TX_IP_CHECKSUM set in ol_flags. But the vmxnet3 has
    DEV_TX_OFFLOAD_IPV4_CKSUM set in this tx offload capa.
    
    This issue has been introduced with the new Rx offload
    API. DEV_TX_OFFLOAD_IPV4_CKSUM and DEV_RX_OFFLOAD_IPV4_CKSUM has been
    added to the tx/rx offloads capa, but the vmxnet3 driver doesn't support
    it.
    
    To fix the issue, DEV_TX/RX_OFFLOAD_IPV4_CKSUM needs to be removed from
    tx/rx offload capa.
    
    Fixes: 95e4a96ccbf1 ("net/vmxnet3: convert to new Rx offload API")
    Cc: llouis@vmware.com
    Cc: stable@dpdk.org
    
    Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
    ---
     drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 --
     1 file changed, 2 deletions(-)
    
    diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    index 57feb377..9cd5eb65 100644
    --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
    +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    @@ -44,7 +44,6 @@
     
     #define VMXNET3_TX_OFFLOAD_CAP		\
     	(DEV_TX_OFFLOAD_VLAN_INSERT |	\
    -	 DEV_TX_OFFLOAD_IPV4_CKSUM |	\
     	 DEV_TX_OFFLOAD_TCP_CKSUM |	\
     	 DEV_TX_OFFLOAD_UDP_CKSUM |	\
     	 DEV_TX_OFFLOAD_TCP_TSO |	\
    @@ -54,7 +53,6 @@
     	(DEV_RX_OFFLOAD_VLAN_STRIP |	\
     	 DEV_RX_OFFLOAD_VLAN_FILTER |   \
     	 DEV_RX_OFFLOAD_SCATTER |	\
    -	 DEV_RX_OFFLOAD_IPV4_CKSUM |	\
     	 DEV_RX_OFFLOAD_UDP_CKSUM |	\
     	 DEV_RX_OFFLOAD_TCP_CKSUM |	\
     	 DEV_RX_OFFLOAD_TCP_LRO |	\
    -- 
    2.11.0
Ferruh Yigit Sept. 4, 2019, 8:17 a.m. UTC | #2
On 8/19/2019 10:56 PM, Louis Luo wrote:
> Hi Maxime,
> 
> Thanks for the fix. Actually Yong and I had some discussion about removing TX IP CSUM offload flag last August and I did prepare a fix but later forgot to submit. Anyway your fix is fine.
> 
> Thanks,
> Louis
> 
> On 8/13/19, 6:30 AM, "Maxime Leroy" <maxime.leroy@6wind.com> wrote:
> 
>     The vmxnet3_prep_pkts function set rte_errno to ENOTSUP for any packets
>     having PKT_TX_IP_CHECKSUM set in ol_flags. But the vmxnet3 has
>     DEV_TX_OFFLOAD_IPV4_CKSUM set in this tx offload capa.
>     
>     This issue has been introduced with the new Rx offload
>     API. DEV_TX_OFFLOAD_IPV4_CKSUM and DEV_RX_OFFLOAD_IPV4_CKSUM has been
>     added to the tx/rx offloads capa, but the vmxnet3 driver doesn't support
>     it.
>     
>     To fix the issue, DEV_TX/RX_OFFLOAD_IPV4_CKSUM needs to be removed from
>     tx/rx offload capa.
>     
>     Fixes: 95e4a96ccbf1 ("net/vmxnet3: convert to new Rx offload API")
>     Cc: llouis@vmware.com
>     Cc: stable@dpdk.org
>     
>     Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>

Acked-by: Yong Wang <yongwang@vmware.com>

Applied to dpdk-next-net/master, thanks.

(Carried the ack from another email)

Patch
diff mbox series

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 57feb377..9cd5eb65 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -44,7 +44,6 @@ 
 
 #define VMXNET3_TX_OFFLOAD_CAP		\
 	(DEV_TX_OFFLOAD_VLAN_INSERT |	\
-	 DEV_TX_OFFLOAD_IPV4_CKSUM |	\
 	 DEV_TX_OFFLOAD_TCP_CKSUM |	\
 	 DEV_TX_OFFLOAD_UDP_CKSUM |	\
 	 DEV_TX_OFFLOAD_TCP_TSO |	\
@@ -54,7 +53,6 @@ 
 	(DEV_RX_OFFLOAD_VLAN_STRIP |	\
 	 DEV_RX_OFFLOAD_VLAN_FILTER |   \
 	 DEV_RX_OFFLOAD_SCATTER |	\
-	 DEV_RX_OFFLOAD_IPV4_CKSUM |	\
 	 DEV_RX_OFFLOAD_UDP_CKSUM |	\
 	 DEV_RX_OFFLOAD_TCP_CKSUM |	\
 	 DEV_RX_OFFLOAD_TCP_LRO |	\