From patchwork Mon Aug 12 23:03:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 57628 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 82A021BE82; Tue, 13 Aug 2019 01:04:14 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 9224F1BDFD; Tue, 13 Aug 2019 01:04:13 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 1A1D8489; Mon, 12 Aug 2019 19:04:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 12 Aug 2019 19:04:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=inMJ0UPQZc t2BdqUntUgjfFwltYEr0m0XlIFQHz3cGc=; b=dvqR4f7q3thn40lpYzbYK8lCwD MDe14qz4PRXKcWtb3PDkXovtP3CqHZEtpbuJctZqTVzOlB0MGRllt+3hamJf8bVY UUSdsu1+eam1DUiulsEUFIX3BNyflUzDyMn72Iu5g5uo85DtKRBaFT/usMM6UAoM R/64+cu6bOyHLBD4c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=inMJ0UPQZct2BdqUntUgjfFwltYEr0m0XlIFQHz3cGc=; b=Sn92zPAB wO/MLi2eP2qsfx/bkMbXx15og79wKeSkx1f313ZIJBbKNzM9bSagx33t09cuS5xD tpQSF++4hJObVVWpRk+sJw6kH36x0SOdaEQk2TdtIlNaxSSU3Ms+RHxW1vWCfCXd Wt+j7uEZqUXA9GLVBAuRNMO659nu+CaCTcFnIWUXwbP7Eic9aYZcWWsSQF97ZTVo jy4k9wujvtBOH7dj9jHGNFyz3mEOZqaXfPAt7xpXtOkX14zKEQb7/F+jnrc7Lx4x sgUpCeJhrHMGRnJfkbKbyrrTyJwCcVUiNiYWYoSWoZiAqmM5IqtJGwxy3YMnO20X lU4t/GpMKx8zYQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddruddvhedgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 078F780061; Mon, 12 Aug 2019 19:04:09 -0400 (EDT) From: Thomas Monjalon To: bruce.richardson@intel.com, Lee Daly , Fiona Trahe , Pablo de Lara , Ashish Gupta , Xiaolong Ye , Qi Zhang Cc: dev@dpdk.org, bluca@debian.org, stable@dpdk.org Date: Tue, 13 Aug 2019 01:03:53 +0200 Message-Id: <20190812230358.988-2-thomas@monjalon.net> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190812230358.988-1-thomas@monjalon.net> References: <20190812230358.988-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/6] build: remove redundant libs from pkgconfig X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" As explained in drivers/meson.build, " For the find_library() case (but not with dependency()) we also need to specify the "-l" flags in pkgconfig_extra_libs variable too, so that it can be reflected in the pkgconfig output for static builds. " The commit e30b4e566f47 ("build: improve dependency handling") must be followed up with this one in order to remove more occurences of pkgconfig_extra_libs redundant with use of dependency(). Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Cc: xiaolong.ye@intel.com Fixes: 3c32e89f68e1 ("compress/isal: add skeleton ISA-L compression PMD") Cc: lee.daly@intel.com Cc: bluca@debian.org Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon Acked-by: Luca Boccassi --- drivers/compress/isal/meson.build | 1 - drivers/net/af_xdp/meson.build | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/compress/isal/meson.build b/drivers/compress/isal/meson.build index 67b5c4aae..25578880d 100644 --- a/drivers/compress/isal/meson.build +++ b/drivers/compress/isal/meson.build @@ -10,6 +10,5 @@ endif deps += 'bus_vdev' sources = files('isal_compress_pmd.c', 'isal_compress_pmd_ops.c') ext_deps += dep -pkgconfig_extra_libs += '-lisal' allow_experimental_apis = true diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build index ac679b92b..307aa0e38 100644 --- a/drivers/net/af_xdp/meson.build +++ b/drivers/net/af_xdp/meson.build @@ -10,7 +10,6 @@ endif if bpf_dep.found() and cc.has_header('bpf/xsk.h') and cc.has_header('linux/if_xdp.h') ext_deps += bpf_dep - pkgconfig_extra_libs += '-lbpf' else build = false reason = 'missing dependency, "libbpf"'