From patchwork Thu Aug 8 01:42:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Congwen Zhang X-Patchwork-Id: 57552 X-Patchwork-Delegate: xiaolong.ye@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 512C02082; Thu, 8 Aug 2019 04:21:06 +0200 (CEST) Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.217.80.70]) by dpdk.org (Postfix) with ESMTP id E95E22AB; Thu, 8 Aug 2019 04:21:04 +0200 (CEST) Received: from mse-fl2.zte.com.cn (unknown [10.30.14.239]) by Forcepoint Email with ESMTPS id 88F784C5DD6EE1A42D5D; Thu, 8 Aug 2019 10:21:03 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse-fl2.zte.com.cn with ESMTP id x782L7oZ088138; Thu, 8 Aug 2019 10:21:07 +0800 (GMT-8) (envelope-from zhang.congwen@zte.com.cn) Received: from 99-99-1-100.lightspeed.wepbfl.sbcglobal.net ([10.43.166.165]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2019080810211482-2810240 ; Thu, 8 Aug 2019 10:21:14 +0800 From: Congwen Zhang To: wenzhuo.lu@intel.com Cc: dev@dpdk.org, stable@dpdk.org, Congwen Zhang Date: Thu, 8 Aug 2019 09:42:07 +0800 Message-Id: <1565228527-3969-1-git-send-email-zhang.congwen@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2019-08-08 10:21:14, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2019-08-08 10:20:56, Serialize complete at 2019-08-08 10:20:56 X-MAIL: mse-fl2.zte.com.cn x782L7oZ088138 Subject: [dpdk-dev] [PATCH v3] net/ixgbe: fix rss_conf sizeof argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In function ixgbe_parse_rss_filter, memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf)) is using memset(aaa, 0, sizeof(struct bbb)) format, maybe it's better to make it consistent with others. Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API") Cc: stable@dpdk.org Signed-off-by: Congwen Zhang Reviewed-by: Xiaolong Ye --- drivers/net/ixgbe/ixgbe_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c index 92377b8..b2a2bfc 100644 --- a/drivers/net/ixgbe/ixgbe_flow.c +++ b/drivers/net/ixgbe/ixgbe_flow.c @@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[]) /* check if the next not void item is END */ act = next_no_void_action(actions, act); if (act->type != RTE_FLOW_ACTION_TYPE_END) { - memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf)); + memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf)); rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, act, "Not supported action.");