compress/isal: create shorter qp name
diff mbox series

Message ID 20190806090954.15807-1-adamx.dybkowski@intel.com
State Accepted, archived
Delegated to: akhil goyal
Headers show
Series
  • compress/isal: create shorter qp name
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-Compile-Testing success Compile Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

Adam Dybkowski Aug. 6, 2019, 9:09 a.m. UTC
This patch shortens the queue pair name created when initializing
the queue pair of the ISAL PIM, based on the device and qp ids.
The patch idea of shortening the queue pair name was proposed
by Luse, Paul E <<paul.e.luse@intel.com>

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
 drivers/compress/isal/isal_compress_pmd_ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daly, Lee Aug. 6, 2019, 9:27 a.m. UTC | #1
Hi Adam,

Take care to add the maintainer of the code you are changing to your email, a list can be found in the MAINTAINERS file. 
This will hopefully ensure a response to the change. 
Thanks.
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Adam Dybkowski
> Sent: Tuesday, August 6, 2019 10:10 AM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Luse, Paul E
> <paul.e.luse@intel.com>
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [dpdk-dev] [PATCH] compress/isal: create shorter qp name
> 
> This patch shortens the queue pair name created when initializing the queue
> pair of the ISAL PIM, based on the device and qp ids.
> The patch idea of shortening the queue pair name was proposed by Luse,
> Paul E <<paul.e.luse@intel.com>
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> ---
>  drivers/compress/isal/isal_compress_pmd_ops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c
> b/drivers/compress/isal/isal_compress_pmd_ops.c
> index 77ac6fcf2..31c455991 100644
> --- a/drivers/compress/isal/isal_compress_pmd_ops.c
> +++ b/drivers/compress/isal/isal_compress_pmd_ops.c
> @@ -216,7 +216,7 @@ isal_comp_pmd_qp_set_unique_name(struct
> rte_compressdev *dev,  struct isal_comp_qp *qp)  {
>  	unsigned int n = snprintf(qp->name, sizeof(qp->name),
> -			"isal_compression_pmd_%u_qp_%u",
> +			"isal_comp_pmd_%u_qp_%u",
>  			dev->data->dev_id, qp->id);
> 
>  	if (n >= sizeof(qp->name))
> --
> 2.17.1
Acked-by: Lee Daly <lee.daly@intel.com>
Adam Dybkowski Aug. 6, 2019, 9:33 a.m. UTC | #2
> -----Original Message-----
> From: Daly, Lee
> Sent: Tuesday, 6 August, 2019 11:28
> To: Dybkowski, AdamX <adamx.dybkowski@intel.com>; dev@dpdk.org;
> Trahe, Fiona <fiona.trahe@intel.com>; Luse, Paul E <paul.e.luse@intel.com>
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] compress/isal: create shorter qp name
> 
> Hi Adam,
> 
> Take care to add the maintainer of the code you are changing to your email,
> a list can be found in the MAINTAINERS file.
> This will hopefully ensure a response to the change.
> Thanks.

Sure, will do next time.
Thanks for the quick ACK, Lee.
Trahe, Fiona Sept. 10, 2019, 3:29 p.m. UTC | #3
> -----Original Message-----
> From: Dybkowski, AdamX
> Sent: Tuesday, August 6, 2019 10:10 AM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Luse, Paul E <paul.e.luse@intel.com>
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [PATCH] compress/isal: create shorter qp name
> 
> This patch shortens the queue pair name created when initializing
> the queue pair of the ISAL PIM, based on the device and qp ids.
> The patch idea of shortening the queue pair name was proposed
> by Luse, Paul E <<paul.e.luse@intel.com>
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Akhil Goyal Sept. 19, 2019, 2:50 p.m. UTC | #4
> 
> 
> > -----Original Message-----
> > From: Dybkowski, AdamX
> > Sent: Tuesday, August 6, 2019 10:10 AM
> > To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Luse, Paul E
> <paul.e.luse@intel.com>
> > Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> > Subject: [PATCH] compress/isal: create shorter qp name
> >
> > This patch shortens the queue pair name created when initializing
> > the queue pair of the ISAL PIM, based on the device and qp ids.
> > The patch idea of shortening the queue pair name was proposed
> > by Luse, Paul E <<paul.e.luse@intel.com>
> >
> > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Applied to dpdk-next-crypto

Thanks.

Patch
diff mbox series

diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c b/drivers/compress/isal/isal_compress_pmd_ops.c
index 77ac6fcf2..31c455991 100644
--- a/drivers/compress/isal/isal_compress_pmd_ops.c
+++ b/drivers/compress/isal/isal_compress_pmd_ops.c
@@ -216,7 +216,7 @@  isal_comp_pmd_qp_set_unique_name(struct rte_compressdev *dev,
 struct isal_comp_qp *qp)
 {
 	unsigned int n = snprintf(qp->name, sizeof(qp->name),
-			"isal_compression_pmd_%u_qp_%u",
+			"isal_comp_pmd_%u_qp_%u",
 			dev->data->dev_id, qp->id);
 
 	if (n >= sizeof(qp->name))