net/memif: fix multi-process device probe error
diff mbox series

Message ID 1564655727-4142-1-git-send-email-phil.yang@arm.com
State Superseded, archived
Headers show
Series
  • net/memif: fix multi-process device probe error
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-Compile-Testing success Compile Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

Phil Yang (Arm Technology China) Aug. 1, 2019, 10:35 a.m. UTC
Fixes: c41a04958b ("net/memif: support multi-process")

Signed-off-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
 drivers/net/memif/rte_eth_memif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon Aug. 2, 2019, 9:01 p.m. UTC | #1
01/08/2019 12:35, Phil Yang:
> Fixes: c41a04958b ("net/memif: support multi-process")
> 
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
> --- a/drivers/net/memif/rte_eth_memif.c
> +++ b/drivers/net/memif/rte_eth_memif.c
> @@ -1265,7 +1265,7 @@ rte_pmd_memif_probe(struct rte_vdev_device *vdev)
>  		eth_dev->dev_ops = &ops;
>  		eth_dev->device = &vdev->device;
>  		eth_dev->rx_pkt_burst = eth_memif_rx;
> -		eth_dev->tx_pkt_burst = eth_memif_rx;
> +		eth_dev->tx_pkt_burst = eth_memif_tx;

It is not a probe error, but malfunctioning device, right?
What is the current behaviour? You could better explain
the symptom in the commit log, and the root cause (typo).
Thomas Monjalon Aug. 6, 2019, 8:08 a.m. UTC | #2
02/08/2019 23:01, Thomas Monjalon:
> 01/08/2019 12:35, Phil Yang:
> > Fixes: c41a04958b ("net/memif: support multi-process")
> > 
> > Signed-off-by: Phil Yang <phil.yang@arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> > ---
> > --- a/drivers/net/memif/rte_eth_memif.c
> > +++ b/drivers/net/memif/rte_eth_memif.c
> > @@ -1265,7 +1265,7 @@ rte_pmd_memif_probe(struct rte_vdev_device *vdev)
> >  		eth_dev->dev_ops = &ops;
> >  		eth_dev->device = &vdev->device;
> >  		eth_dev->rx_pkt_burst = eth_memif_rx;
> > -		eth_dev->tx_pkt_burst = eth_memif_rx;
> > +		eth_dev->tx_pkt_burst = eth_memif_tx;
> 
> It is not a probe error, but malfunctioning device, right?
> What is the current behaviour? You could better explain
> the symptom in the commit log, and the root cause (typo).

Nobody is replying or sending a v2?
Jakub?
Phil Yang (Arm Technology China) Aug. 6, 2019, 8:18 a.m. UTC | #3
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, August 6, 2019 4:08 PM
> To: Phil Yang (Arm Technology China) <Phil.Yang@arm.com>;
> jgrajcia@cisco.com
> Cc: dev@dpdk.org; anatoly.burakov@intel.com; ferruh.yigit@intel.com;
> Gavin Hu (Arm Technology China) <Gavin.Hu@arm.com>; Honnappa
> Nagarahalli <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>
> Subject: Re: [dpdk-dev] [PATCH] net/memif: fix multi-process device probe
> error
> 
> 02/08/2019 23:01, Thomas Monjalon:
> > 01/08/2019 12:35, Phil Yang:
> > > Fixes: c41a04958b ("net/memif: support multi-process")
> > >
> > > Signed-off-by: Phil Yang <phil.yang@arm.com>
> > > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> > > ---
> > > --- a/drivers/net/memif/rte_eth_memif.c
> > > +++ b/drivers/net/memif/rte_eth_memif.c
> > > @@ -1265,7 +1265,7 @@ rte_pmd_memif_probe(struct
> rte_vdev_device *vdev)
> > >  		eth_dev->dev_ops = &ops;
> > >  		eth_dev->device = &vdev->device;
> > >  		eth_dev->rx_pkt_burst = eth_memif_rx;
> > > -		eth_dev->tx_pkt_burst = eth_memif_rx;
> > > +		eth_dev->tx_pkt_burst = eth_memif_tx;
> >
Hi Thomas,

Sorry for the later response.

> > It is not a probe error, but malfunctioning device, right?
Yes, agree.

> > What is the current behaviour? You could better explain
> > the symptom in the commit log, and the root cause (typo).
Since testpmd has issues working as a secondary process, so I cannot get the typo for this issue.
But in logically, the memif PMD should use eth_memif_tx in the egress path.

I will update the commit log in v2.

> 
> Nobody is replying or sending a v2?
> Jakub?
>

Thanks,
Phil

Patch
diff mbox series

diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
index bcda426..a59f809 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b/drivers/net/memif/rte_eth_memif.c
@@ -1265,7 +1265,7 @@  rte_pmd_memif_probe(struct rte_vdev_device *vdev)
 		eth_dev->dev_ops = &ops;
 		eth_dev->device = &vdev->device;
 		eth_dev->rx_pkt_burst = eth_memif_rx;
-		eth_dev->tx_pkt_burst = eth_memif_rx;
+		eth_dev->tx_pkt_burst = eth_memif_tx;
 
 		if (!rte_eal_primary_proc_alive(NULL)) {
 			MIF_LOG(ERR, "Primary process is missing");