diff mbox series

[v2] net/enic: retain previous message logging

Message ID 20190726201246.26234-1-johndale@cisco.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [v2] net/enic: retain previous message logging |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-Compile-Testing success Compile Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

John Daley (johndale) July 26, 2019, 8:12 p.m. UTC 
  Prior to the fix, RTE_LOGTYPE_INFO messages were displayed by default.
After the fix, only NOTICE level and higher were displayed by default
and INFO level were not. There are INFO level vNIC config related
messages which customers and tech support currently depend on for
debugging and so on and to suddenly hide these messages is not a good
idea.

This patch changes the default log level to RTE_LOG_INFO for enic so
messages are printed as before the fix.

Fixes: bbd8ecc05434 ("net/enic: remove PMD log type references")

Signed-off-by: John Daley <johndale@cisco.com>
---

v2: Change default log level to 'RTE_LOG_INFO' instead of changing the
    'dev_info' messages to 'dev_notice'

 drivers/net/enic/enic_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit July 29, 2019, 11:03 a.m. UTC | #1 
On 7/26/2019 9:12 PM, John Daley wrote:
> Prior to the fix, RTE_LOGTYPE_INFO messages were displayed by default.
> After the fix, only NOTICE level and higher were displayed by default
> and INFO level were not. There are INFO level vNIC config related
> messages which customers and tech support currently depend on for
> debugging and so on and to suddenly hide these messages is not a good
> idea.
> 
> This patch changes the default log level to RTE_LOG_INFO for enic so
> messages are printed as before the fix.
> 
> Fixes: bbd8ecc05434 ("net/enic: remove PMD log type references")
> 
> Signed-off-by: John Daley <johndale@cisco.com>

Applied to dpdk-next-net/master, thanks.
diff mbox series

Patch

diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c
index 6051689a6..0ade57370 100644
--- a/drivers/net/enic/enic_ethdev.c
+++ b/drivers/net/enic/enic_ethdev.c
@@ -73,7 +73,7 @@  RTE_INIT(enicpmd_init_log)
 {
 	enic_pmd_logtype = rte_log_register("pmd.net.enic");
 	if (enic_pmd_logtype >= 0)
-		rte_log_set_level(enic_pmd_logtype, RTE_LOG_NOTICE);
+		rte_log_set_level(enic_pmd_logtype, RTE_LOG_INFO);
 }
 
 static int