lib/librte_eal: fix unrecongized telemetry eal arg

Message ID 20190715105434.18581-1-sean.morrissey@intel.com
State Accepted, archived
Headers show
Series
  • lib/librte_eal: fix unrecongized telemetry eal arg
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Morrissey, Sean July 15, 2019, 10:54 a.m.
Added telemetry to EAL long options so that when
--telemetry is passed as an EAL arg that there is
no unrecognized argument error message printed.

Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
Cc: ciara.power@intel.com
Cc: stable@dpdk.org

Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
---
 lib/librte_eal/common/eal_common_options.c | 3 +++
 lib/librte_eal/common/eal_options.h        | 4 ++++
 2 files changed, 7 insertions(+)

Comments

Morrissey, Sean July 15, 2019, 11 a.m. | #1
+Harry Van Haaren
--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.
Laatz, Kevin July 19, 2019, 10:04 a.m. | #2
On 15/07/2019 11:54, Sean Morrissey wrote:
> Added telemetry to EAL long options so that when
> --telemetry is passed as an EAL arg that there is
> no unrecognized argument error message printed.
>
> Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
> Cc: ciara.power@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
> ---
>   lib/librte_eal/common/eal_common_options.c | 3 +++
>   lib/librte_eal/common/eal_options.h        | 4 ++++
>   2 files changed, 7 insertions(+)
>
> diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
> index 512d5088e..24e36cf23 100644
> --- a/lib/librte_eal/common/eal_common_options.c
> +++ b/lib/librte_eal/common/eal_common_options.c
> @@ -81,6 +81,9 @@ eal_long_options[] = {
>   	{OPT_LEGACY_MEM,        0, NULL, OPT_LEGACY_MEM_NUM       },
>   	{OPT_SINGLE_FILE_SEGMENTS, 0, NULL, OPT_SINGLE_FILE_SEGMENTS_NUM},
>   	{OPT_MATCH_ALLOCATIONS, 0, NULL, OPT_MATCH_ALLOCATIONS_NUM},
> +#ifdef RTE_LIBRTE_TELEMETRY
> +	{OPT_TELEMETRY,         0, NULL, OPT_TELEMETRY_NUM        },
> +#endif
>   	{0,                     0, NULL, 0                        }
>   };
>   
> diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h
> index 9855429e5..e4c8e25c2 100644
> --- a/lib/librte_eal/common/eal_options.h
> +++ b/lib/librte_eal/common/eal_options.h
> @@ -69,6 +69,10 @@ enum {
>   	OPT_IOVA_MODE_NUM,
>   #define OPT_MATCH_ALLOCATIONS  "match-allocations"
>   	OPT_MATCH_ALLOCATIONS_NUM,
> +#ifdef RTE_LIBRTE_TELEMETRY
> +	#define OPT_TELEMETRY          "telemetry"
> +		OPT_TELEMETRY_NUM,
> +#endif
>   	OPT_LONG_MAX_NUM
>   };
>   
LGTM, thanks!

Acked-by: Kevin Laatz <kevin.laatz@intel.com>
Thomas Monjalon July 22, 2019, 4:40 p.m. | #3
19/07/2019 12:04, Laatz, Kevin:
> On 15/07/2019 11:54, Sean Morrissey wrote:
> > Added telemetry to EAL long options so that when
> > --telemetry is passed as an EAL arg that there is
> > no unrecognized argument error message printed.
> >
> > Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
> > Cc: ciara.power@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
> 
> Acked-by: Kevin Laatz <kevin.laatz@intel.com>

Applied, thanks

Patch

diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
index 512d5088e..24e36cf23 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -81,6 +81,9 @@  eal_long_options[] = {
 	{OPT_LEGACY_MEM,        0, NULL, OPT_LEGACY_MEM_NUM       },
 	{OPT_SINGLE_FILE_SEGMENTS, 0, NULL, OPT_SINGLE_FILE_SEGMENTS_NUM},
 	{OPT_MATCH_ALLOCATIONS, 0, NULL, OPT_MATCH_ALLOCATIONS_NUM},
+#ifdef RTE_LIBRTE_TELEMETRY
+	{OPT_TELEMETRY,         0, NULL, OPT_TELEMETRY_NUM        },
+#endif
 	{0,                     0, NULL, 0                        }
 };
 
diff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h
index 9855429e5..e4c8e25c2 100644
--- a/lib/librte_eal/common/eal_options.h
+++ b/lib/librte_eal/common/eal_options.h
@@ -69,6 +69,10 @@  enum {
 	OPT_IOVA_MODE_NUM,
 #define OPT_MATCH_ALLOCATIONS  "match-allocations"
 	OPT_MATCH_ALLOCATIONS_NUM,
+#ifdef RTE_LIBRTE_TELEMETRY
+	#define OPT_TELEMETRY          "telemetry"
+		OPT_TELEMETRY_NUM,
+#endif
 	OPT_LONG_MAX_NUM
 };