test: fix build without timer
diff mbox series

Message ID 59d6b403fd875f8dac9b4f3d85725b95cb462b17.1562254062.git.tredaelli@redhat.com
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • test: fix build without timer
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation fail apply issues

Commit Message

Timothy Redaelli July 4, 2019, 3:36 p.m. UTC
The action for timer_secondary_spawn_wait should be enabled only when
CONFIG_RTE_LIBRTE_TIMER is enabled.

Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process")
Cc: erik.g.carrillo@intel.com
Cc: stable@dpdk.org

Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
---
 app/test/test.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Bruce Richardson July 4, 2019, 4:27 p.m. UTC | #1
On Thu, Jul 04, 2019 at 05:36:08PM +0200, Timothy Redaelli wrote:
> The action for timer_secondary_spawn_wait should be enabled only when
> CONFIG_RTE_LIBRTE_TIMER is enabled.
> 
> Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process")
> Cc: erik.g.carrillo@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---

Is there a reason why DPDK can't always be built with the timer library? It
doesn't have any external dependencies, and having the ability to turn on
and off various libraries individually in the build makes validating the
combinations problematic.

/Bruce
Thomas Monjalon July 5, 2019, 8:48 a.m. UTC | #2
04/07/2019 18:27, Bruce Richardson:
> On Thu, Jul 04, 2019 at 05:36:08PM +0200, Timothy Redaelli wrote:
> > The action for timer_secondary_spawn_wait should be enabled only when
> > CONFIG_RTE_LIBRTE_TIMER is enabled.
> > 
> > Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process")
> > Cc: erik.g.carrillo@intel.com
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> > ---
> 
> Is there a reason why DPDK can't always be built with the timer library? It
> doesn't have any external dependencies, and having the ability to turn on
> and off various libraries individually in the build makes validating the
> combinations problematic.

Every libraries can be disabled in the "make" build system.
It allows to build a small DPDK.
Anyway, this capability is removed in the "meson" build system.

Applied, thanks

Patch
diff mbox series

diff --git a/app/test/test.c b/app/test/test.c
index 194a92a39..cd7aaf645 100644
--- a/app/test/test.c
+++ b/app/test/test.c
@@ -67,7 +67,9 @@  do_recursive_call(void)
 			{ "test_memory_flags", no_action },
 			{ "test_file_prefix", no_action },
 			{ "test_no_huge_flag", no_action },
+#ifdef RTE_LIBRTE_TIMER
 			{ "timer_secondary_spawn_wait", test_timer_secondary },
+#endif
 	};
 
 	if (recursive_call == NULL)