diff mbox series

[v3,1/3] net/mvneta: fix: ierror counted twice

Message ID 1561968024-16133-2-git-send-email-lironh@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/mvneta: minor updates |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation fail apply issues

Commit Message

Liron Himi July 1, 2019, 8 a.m. UTC 
  From: Liron Himi <lironh@marvell.com>

error packets were counted twice due to use
of redundant counters

Fixes: e9d5faff ("net/mvneta: support basic stats")

Signed-off-by: Liron Himi <lironh@marvell.com>
Reviewed-by: Yuri Chipchev <yuric@marvell.com>
Tested-by: Liron Himi <lironh@marvell.com>
---
 drivers/net/mvneta/mvneta_ethdev.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Jerin Jacob Kollanukkaran July 1, 2019, 5:45 p.m. UTC | #1 
> -----Original Message-----
> From: lironh@marvell.com <lironh@marvell.com>
> Sent: Monday, July 1, 2019 1:30 PM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: dev@dpdk.org; Liron Himi <lironh@marvell.com>
> Subject: [PATCH v3 1/3] net/mvneta: fix: ierror counted twice

No need to have ":" after fix.
Added Cc: stable@dpdk.orf

Corrected  following check-gitlog.sh errors
        net/mvneta: only use ol_flags for checksum generation offload
Headline too long:
        net/mvneta: only use ol_flags for checksum generation offload

Series applied to dpdk-next-net-mrvl/master. Thanks.
diff mbox series

Patch

diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c
index 9657444..d6e64a8 100644
--- a/drivers/net/mvneta/mvneta_ethdev.c
+++ b/drivers/net/mvneta/mvneta_ethdev.c
@@ -707,10 +707,7 @@  mvneta_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 	stats->imissed += ppio_stats.rx_discard +
 			  ppio_stats.rx_overrun -
 			  priv->prev_stats.imissed;
-
-	stats->ierrors = ppio_stats.rx_packets_err +
-			ppio_stats.rx_errors +
-			ppio_stats.rx_crc_error -
+	stats->ierrors = ppio_stats.rx_packets_err -
 			priv->prev_stats.ierrors;
 	stats->oerrors = ppio_stats.tx_errors - priv->prev_stats.oerrors;