From patchwork Mon Jun 24 16:47:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 55261 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 212721BD0E; Mon, 24 Jun 2019 18:47:40 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id CBA4C1BCEA for ; Mon, 24 Jun 2019 18:47:27 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id y72so7413922pgd.8 for ; Mon, 24 Jun 2019 09:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MaX/9U1VKQDRlwJP1eh9LKqP+HAkhTNljy8r1/SknpU=; b=VlybDhCa2IZgaQo+N5xEysg/i4y/7+by64zpSYiLmMmbFBFz2CTwyRvbPktQUUc5Rt 81iEG601qwLReKAN2fVYVB1K4vqXb1TykQssVghSZiXDvrqPkWTBZD4uC94Gds9ojbPh pwlrplieAd+/P9qiJNSALsvj8+OHU+jXw/Him8DmGQeZ2VUIRJHytUt5lpeABtBfmH5F KNB6ysWgoypMEo83geNlr8KEQOBIYh3Mz/VOntY2OtYOimtv0HzF0hX/5wgOKFsocceg mtVYHEk2gcm4etLMR4+WLcBewDW940zRxncBTmBWiLtKjCGX3HecetyiXvc1qd/JW55+ ivyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MaX/9U1VKQDRlwJP1eh9LKqP+HAkhTNljy8r1/SknpU=; b=R8kii7ZKvQDX2W/Ho9Y8Fgx8ufOToL44ckNWDts9jp6i19MmSjdmiwgY7jtOjWUSeF BVktZGVnVU/ychAfPA0hgq0Vp470GED7W5Dd4wiL1665EVxaVbourkRnumE3f8qg867L vd5ktfsNwoEu+PhssI9zv32hNyFI/HOLW1/bPhJSyf0JMD6hRj6Vf+I5p7YyVWesZu2Y bBp1s1Q6rE5e4a6N2JGO8aUn09rV9cWD8P4SWkR8SYWKtAB1KHdOJcTVeYrsFAQIkUcv hn8L+Z4dSJzxLOwQWWV+N6WFMzTogV0zUoYNWBmriV4KYm2PlggYkwgGomY4D/6peZgB OeNQ== X-Gm-Message-State: APjAAAVbTmxKuGcfjzlWpjgcLXFV0jaUXb5R+KI6RS2CyJtfLkw6TB9N rw4lOiTf7yySYl7y+RrHsgbR4/1gZXU= X-Google-Smtp-Source: APXvYqxl3D4D5pGrNfkpXYZk1Aj+DBEfGD8Tk/n39gOG1pJGBVxPUdtNiXzaSVOhcvEzJvMiXM73ig== X-Received: by 2002:a63:231c:: with SMTP id j28mr33375206pgj.430.1561394846638; Mon, 24 Jun 2019 09:47:26 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f7sm12814023pfd.43.2019.06.24.09.47.25 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 24 Jun 2019 09:47:25 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 24 Jun 2019 09:47:10 -0700 Message-Id: <20190624164714.6560-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190624164714.6560-1-stephen@networkplumber.org> References: <20190610175155.21374-1-stephen@networkplumber.org> <20190624164714.6560-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v6 5/9] kni: use proper type for kni fifo's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Using void * instead of proper type is unsafe practice. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h index f3e6c3ca4efa..ceba5f73c1d9 100644 --- a/kernel/linux/kni/kni_dev.h +++ b/kernel/linux/kni/kni_dev.h @@ -51,22 +51,22 @@ struct kni_dev { struct net_device *net_dev; /* queue for packets to be sent out */ - void *tx_q; + struct rte_kni_fifo *tx_q; /* queue for the packets received */ - void *rx_q; + struct rte_kni_fifo *rx_q; /* queue for the allocated mbufs those can be used to save sk buffs */ - void *alloc_q; + struct rte_kni_fifo *alloc_q; /* free queue for the mbufs to be freed */ - void *free_q; + struct rte_kni_fifo *free_q; /* request queue */ - void *req_q; + struct rte_kni_fifo *req_q; /* response queue */ - void *resp_q; + struct rte_kni_fifo *resp_q; void *sync_kva; void *sync_va;