From patchwork Mon Jun 24 16:47:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 55257 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E75BB1BD0F; Mon, 24 Jun 2019 18:47:26 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 271631BCDA for ; Mon, 24 Jun 2019 18:47:23 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id j2so7843271pfe.6 for ; Mon, 24 Jun 2019 09:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lx7mNNtKZOJfi54i/SUlINrC4myA0zQHh+IpidBgz5c=; b=YuETSDNmqsXwJ78AWFj/nbWXA1JHeCsQQtOl5jPg64F7xAY18k0dMkyX2zd58FhzYa xnzUUlQ52TpR5SBi4WP0BTBxpmZOLlXYU4exghlhnAqiQ6MAELvID+IqQdf+GPEfDKN+ D6+Ddep7zi/FiDPC9KcEgvf4XYmSdzGmIv4p8NR9/tLP7TllWx3XtFVS5TvkP7ZuX3zf LbytDwgCozQSSsByxi5Ep+p08bgPlXSuH2jh0wTpchjzdSf4T76UDNkyhtSPNXg3JiEz /ZUE1PWMyhuSnX9b2/+JEIQerpjQxCkWox8G7Ob0Zqu4N9pwwQKhWMa7OZvUi2/nUXrj l/3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lx7mNNtKZOJfi54i/SUlINrC4myA0zQHh+IpidBgz5c=; b=F5/QnyZ2ogVwFcqU/KfZZYBDAjSClyujvln+oOklSfTTrwUF20F3jSBg+eLmuDE7C4 lCx1F4L1IqtKSB5sdGZ3N0iD9fj5q++W66ryIxPaRwvuY4C0GaCnHFZb507bJTjPJkAD e0DgVTzHUvyj4h29GNyaWnVeamner/BpZBDsMdSFSTz64xvCjm0Kw4+5I1/XZpSO2mi5 QxnpNBxRHe25LeWJeQM7mOM0QOqUeKfMeKVDCbmZCo51Z3XU4QC6+cPcFlh564ktKofv u9ttU4N7v+6T59797uLyPk71wV6oOaMrq0p0iteIt2Uvp/NiuHAimk7/jQx5Oker7mGs NUig== X-Gm-Message-State: APjAAAV5rBFwPWJGdUjsyD6mHY1oi8NNvyjmjmKwmFbtb5XAijMoYBBQ 9U3UUB1TO7LnAg7aCVPtzatAHMd79Ds= X-Google-Smtp-Source: APXvYqyRhqwG5GQDIfm/7xUJT91jfRHm3oOcGI+OMMJgyZn6aW3moQOqqeLY9bWbCKpe0xPfBDmeig== X-Received: by 2002:a63:6004:: with SMTP id u4mr12644088pgb.453.1561394842104; Mon, 24 Jun 2019 09:47:22 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f7sm12814023pfd.43.2019.06.24.09.47.21 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 24 Jun 2019 09:47:21 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 24 Jun 2019 09:47:06 -0700 Message-Id: <20190624164714.6560-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190624164714.6560-1-stephen@networkplumber.org> References: <20190610175155.21374-1-stephen@networkplumber.org> <20190624164714.6560-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v6 1/9] kni: don't need stubs for rx_mode or ioctl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The netdev subsystem already handles case where network sevice does not support ioctl. If device has no rx_mode hook it is not called. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_net.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c index ad8365877cda..c86337d099ab 100644 --- a/kernel/linux/kni/kni_net.c +++ b/kernel/linux/kni/kni_net.c @@ -593,23 +593,6 @@ kni_net_tx_timeout(struct net_device *dev) netif_wake_queue(dev); } -/* - * Ioctl commands - */ -static int -kni_net_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) -{ - pr_debug("kni_net_ioctl group:%d cmd:%d\n", - ((struct kni_dev *)netdev_priv(dev))->group_id, cmd); - - return -EOPNOTSUPP; -} - -static void -kni_net_set_rx_mode(struct net_device *dev) -{ -} - static int kni_net_change_mtu(struct net_device *dev, int new_mtu) { @@ -758,8 +741,6 @@ static const struct net_device_ops kni_net_netdev_ops = { .ndo_change_rx_flags = kni_net_set_promiscusity, .ndo_start_xmit = kni_net_tx, .ndo_change_mtu = kni_net_change_mtu, - .ndo_do_ioctl = kni_net_ioctl, - .ndo_set_rx_mode = kni_net_set_rx_mode, .ndo_get_stats = kni_net_stats, .ndo_tx_timeout = kni_net_tx_timeout, .ndo_set_mac_address = kni_net_set_mac,