From patchwork Thu Jun 20 19:20:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 55136 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 38CA81D48A; Thu, 20 Jun 2019 21:21:17 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id DF6B31D46B for ; Thu, 20 Jun 2019 21:21:03 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id m4so1476316pgk.0 for ; Thu, 20 Jun 2019 12:21:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MaX/9U1VKQDRlwJP1eh9LKqP+HAkhTNljy8r1/SknpU=; b=0V577HkMMglYmsTImfFcLBXf+WL6OR5xpxsA4zTBFQnIMhpxto7mAPnfXd+hkOi7Og ltMWkp26SLhttLigFnOtc/enXGjFgO9Eh0LAt3axhcaLOMeXvpFUNewfcoGRcsgO6Bi1 txqmuts565ULlWmJfA0JvfZHVXI4DbG23iCbkacMFrIZPouV+SApA4eK4j4R1Ne43fs1 yqY/KjKqiZo7JADFRgq2ABu326xLzTsNALADakA1iXCKqgjA9VOijrWM2J0U5YQwo54T qYKv1TOFDfccy/xE0YV5gAQOE3vMR20rI86JSuIFwpowJNdOAiG6aMBJPQTB+RMhrV8Z vSKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MaX/9U1VKQDRlwJP1eh9LKqP+HAkhTNljy8r1/SknpU=; b=SnYIZjAI2ITD560BehFWrH5w3onFOROgBkEsWG6XTm4NE6iSnNYfr3ZwgAMs0F1WNH qCSMiHGwHRrLvWX+y9CSb/v10DgBjfpVCPtUPJ9YSd9RKu32yVR7B4limF1ckvQX+1Zs jungO7aFqhXftX7MsW4+++QVmipGeesz01JdmJjVFnJnERf8z37JvMnyYilysU+oKRLF VaVEXHOt/2OADLyCJci2IeF7AKxO5ZqeNF4QnXvIvElYyhnIA1n9GY+SRIsLRLDbBCoQ +ONYcIfbqdasv2XWXvsZHMVEiBVDBQDCylGfGe3qJTDVuOK7ejqJ87K9biwsCl9bP+Z0 mKPA== X-Gm-Message-State: APjAAAUN2JIMJErvTVNpJ1nSgMbUCFzl/6RgVe/OPcElhRqKtWyYLJHh 7KDvJst6zc6wDIO2/JYVEKw7LXcsJOg= X-Google-Smtp-Source: APXvYqyAa4rz1iYP/qBRufSOFZDeRapIDdHEkMPCXQ17oDL/QmTjFou4MGkw9rD5TNAIk6SAtMjebQ== X-Received: by 2002:a63:6ecf:: with SMTP id j198mr14192429pgc.437.1561058462826; Thu, 20 Jun 2019 12:21:02 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id j11sm255703pfa.2.2019.06.20.12.21.01 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 20 Jun 2019 12:21:02 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Thu, 20 Jun 2019 12:20:44 -0700 Message-Id: <20190620192048.13814-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190620192048.13814-1-stephen@networkplumber.org> References: <20190610175155.21374-1-stephen@networkplumber.org> <20190620192048.13814-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v5 5/9] kni: use proper type for kni fifo's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Using void * instead of proper type is unsafe practice. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h index f3e6c3ca4efa..ceba5f73c1d9 100644 --- a/kernel/linux/kni/kni_dev.h +++ b/kernel/linux/kni/kni_dev.h @@ -51,22 +51,22 @@ struct kni_dev { struct net_device *net_dev; /* queue for packets to be sent out */ - void *tx_q; + struct rte_kni_fifo *tx_q; /* queue for the packets received */ - void *rx_q; + struct rte_kni_fifo *rx_q; /* queue for the allocated mbufs those can be used to save sk buffs */ - void *alloc_q; + struct rte_kni_fifo *alloc_q; /* free queue for the mbufs to be freed */ - void *free_q; + struct rte_kni_fifo *free_q; /* request queue */ - void *req_q; + struct rte_kni_fifo *req_q; /* response queue */ - void *resp_q; + struct rte_kni_fifo *resp_q; void *sync_kva; void *sync_va;