From patchwork Wed Jun 19 18:57:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 55088 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D67E11D0EB; Wed, 19 Jun 2019 20:58:00 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 202C31D0BA for ; Wed, 19 Jun 2019 20:57:57 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id f21so181648pgi.3 for ; Wed, 19 Jun 2019 11:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LyNzsR8H+QQKPGmEhnn+f4xkaZgLMnwHGhB18LvT0Ro=; b=TDHLJk5SoEJHys6Kwh9oifNQfJW0luGXBXBjiEc+VZuR4JrUppdMqwbfq0cPq6l9YE 3qgd6+1ndNIU4cwiWvoRcWxr+Ey9Ir8VybvFC9+Z5BxyvnuSnHYWIIrMGvLJeO7YMXg3 CXT/Gcwa1/R7B9xadG4yIcdoo7+R/nefLRTL4Ye3N/8yZ/PZah/PeiBoSLWjc8+DPNF/ 05qP9RGsxZjYsEGodfUaegpw7OSI2rynamaDkeuhnTtG02X7/rub+vVEvC+9//B9kmG3 zkUd60X9AkaE4/ue2erhD0Lm0Ir6dTq5HjpioAFA1Q0Qp6RsaatSZNMwiaacchjJ+T54 NA9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LyNzsR8H+QQKPGmEhnn+f4xkaZgLMnwHGhB18LvT0Ro=; b=JtzqZySiavkVjRfzGOSF93yydWf1W2vGWwuqmni0FH/CgeVe/MCbPtAUhKNqAIX764 y31NyCzEEIoX7eyq7qI+J0mi3BOoD6J7clJJ6rDidCCiFHNv6z++yYHqq6YpqX2wVlQY iGQMhd39pkmkBEYSprxnQBjlqXIhImnPrj8dTsyRh5Wn7OvpIsExtFjnUZS/s2gAGbVt Z9qtVqIgqAckPF7/CcyTEcme+hWNruCyXcnvwalILyH5XcO6vj6bCvf0HDOFT0MqRqyp 7Ksft+8ScduPrFo3tq0NsVA3aoPwTK+FwWyNwhDgdKQQ3Mis0n9oXiMkZwjHcs1OEyPZ lO8Q== X-Gm-Message-State: APjAAAXjygxmJKe+0w4ZQcNvLA0QYpI84fjWaRSeBUQ5GZoo5tDz57b2 ogJ3r8hKXqG65ueR941c/sM+GJgXtsw= X-Google-Smtp-Source: APXvYqzc/fqeFoRMDlz6EQKyQeUhNwwrCFildLzSUJ53Ke/jPCwdKVeCL6Z97WPu6cG7e+Mrr9+msQ== X-Received: by 2002:a63:e4c:: with SMTP id 12mr9206736pgo.309.1560970675893; Wed, 19 Jun 2019 11:57:55 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id b8sm24774858pff.20.2019.06.19.11.57.54 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 19 Jun 2019 11:57:54 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Stephen Hemminger Date: Wed, 19 Jun 2019 11:57:39 -0700 Message-Id: <20190619185746.26866-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190619185746.26866-1-stephen@networkplumber.org> References: <20190610175155.21374-1-stephen@networkplumber.org> <20190619185746.26866-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 1/8] kni: don't need stubs for rx_mode or ioctl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Stephen Hemminger The netdev subsystem already handles case where network sevice does not support ioctl. If device has no rx_mode hook it is not called. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_net.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c index ad8365877cda..c86337d099ab 100644 --- a/kernel/linux/kni/kni_net.c +++ b/kernel/linux/kni/kni_net.c @@ -593,23 +593,6 @@ kni_net_tx_timeout(struct net_device *dev) netif_wake_queue(dev); } -/* - * Ioctl commands - */ -static int -kni_net_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) -{ - pr_debug("kni_net_ioctl group:%d cmd:%d\n", - ((struct kni_dev *)netdev_priv(dev))->group_id, cmd); - - return -EOPNOTSUPP; -} - -static void -kni_net_set_rx_mode(struct net_device *dev) -{ -} - static int kni_net_change_mtu(struct net_device *dev, int new_mtu) { @@ -758,8 +741,6 @@ static const struct net_device_ops kni_net_netdev_ops = { .ndo_change_rx_flags = kni_net_set_promiscusity, .ndo_start_xmit = kni_net_tx, .ndo_change_mtu = kni_net_change_mtu, - .ndo_do_ioctl = kni_net_ioctl, - .ndo_set_rx_mode = kni_net_set_rx_mode, .ndo_get_stats = kni_net_stats, .ndo_tx_timeout = kni_net_tx_timeout, .ndo_set_mac_address = kni_net_set_mac,