From patchwork Tue Jun 18 16:16:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 54919 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 36A9C1C219; Tue, 18 Jun 2019 18:16:49 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 1E9101C10C for ; Tue, 18 Jun 2019 18:16:46 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id n2so7945467pgp.11 for ; Tue, 18 Jun 2019 09:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lx7mNNtKZOJfi54i/SUlINrC4myA0zQHh+IpidBgz5c=; b=cUzmyQu3W5XUJI+sE/fxeNAxi289bSWfx/NNFtX8+dPLBxqdeUY1vFWtkzrYIt+P5c OHBZ3qt9wjX5qlyYxS0ih+9E/StWaoaS7Q8EyJxN7erZSXJf8BEK/tTxG50M0bahb8gJ Yb9TT4L18mLLzQaleUqqee9fM0N8h1BZHSg0frlX4AL49XCss7mxmuTcz5NIKgZPe/KM 11+tgrMXg0ufloXERCsXZKF6j5hLJMMJ5DDWUOdMLwpChPlWGauWccsLn92P0Poss7e8 NbMsqQuPNhfnDfNilk4lsSROArW5fJytjS7X3nG39NSpEY5MIGDrCN7F5vFdZuQ1+NnP XWdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lx7mNNtKZOJfi54i/SUlINrC4myA0zQHh+IpidBgz5c=; b=fKDtrqMVEi2nw/tizXHqHiE6Mw5C/RrwjCLsv6rT5ij+OmagFfSE8XkRBChazeo16G HZXT0+/aAUVK/8xlFQD8ByxqclxaUT4PSfF7WMv83E1b3eHYsjxpiZ/mFhU1bbiTAVoA tc4EJiODiA5R80geBmEnPIqRdc2jSHxI/BTS2XD3+u1DoaM+B0JKIeIQDYfzaHs2rlL8 F1qXu9rY/mkAnirHG/lShDAFzsexTVrBQZIjZ041FejjvIMnHdgZrhmR4jStNaEGVIYm FQLcaPA5q7rMFzJT2yKSesuqgBsRTdbvDfvMgwh4u1zbN3DJrOrKRe3qV8VWkkiB8lzq 28TQ== X-Gm-Message-State: APjAAAXVnyUtkd+cDE63dgXTJ9zDbaTkdp4ScFtszc6KzejX19WWLizu 5uAszlZcqj+SzoFxNAm4MTCAcj8qKYU= X-Google-Smtp-Source: APXvYqywg3FnjNY+OYMXzB7fMH/jCwCmOVFkWJc7WY74jFL0lJYbp4vAz6cB53KSXLS2+xwuO3p57w== X-Received: by 2002:a17:90a:19d:: with SMTP id 29mr6119777pjc.71.1560874604979; Tue, 18 Jun 2019 09:16:44 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 3sm15485385pfp.114.2019.06.18.09.16.43 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 18 Jun 2019 09:16:43 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Tue, 18 Jun 2019 09:16:29 -0700 Message-Id: <20190618161636.23748-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190618161636.23748-1-stephen@networkplumber.org> References: <20190610175155.21374-1-stephen@networkplumber.org> <20190618161636.23748-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 1/8] kni: don't need stubs for rx_mode or ioctl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The netdev subsystem already handles case where network sevice does not support ioctl. If device has no rx_mode hook it is not called. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_net.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c index ad8365877cda..c86337d099ab 100644 --- a/kernel/linux/kni/kni_net.c +++ b/kernel/linux/kni/kni_net.c @@ -593,23 +593,6 @@ kni_net_tx_timeout(struct net_device *dev) netif_wake_queue(dev); } -/* - * Ioctl commands - */ -static int -kni_net_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) -{ - pr_debug("kni_net_ioctl group:%d cmd:%d\n", - ((struct kni_dev *)netdev_priv(dev))->group_id, cmd); - - return -EOPNOTSUPP; -} - -static void -kni_net_set_rx_mode(struct net_device *dev) -{ -} - static int kni_net_change_mtu(struct net_device *dev, int new_mtu) { @@ -758,8 +741,6 @@ static const struct net_device_ops kni_net_netdev_ops = { .ndo_change_rx_flags = kni_net_set_promiscusity, .ndo_start_xmit = kni_net_tx, .ndo_change_mtu = kni_net_change_mtu, - .ndo_do_ioctl = kni_net_ioctl, - .ndo_set_rx_mode = kni_net_set_rx_mode, .ndo_get_stats = kni_net_stats, .ndo_tx_timeout = kni_net_tx_timeout, .ndo_set_mac_address = kni_net_set_mac,