examples/flow_filtering: remove out-of-date comment

Message ID 20190618134551.97906-1-xiaolong.ye@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series examples/flow_filtering: remove out-of-date comment |

Checks

Context Check Description
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation fail Compilation issues
ci/checkpatch success coding style OK

Commit Message

Xiaolong Ye June 18, 2019, 1:45 p.m. UTC
  Now we've setup both rx and tx queues.

Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
 examples/flow_filtering/main.c | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Ori Kam June 23, 2019, 5:22 a.m. UTC | #1
> -----Original Message-----
> From: Xiaolong Ye <xiaolong.ye@intel.com>
> Sent: Tuesday, June 18, 2019 4:46 PM
> To: Ferruh Yigit <ferruh.yigit@intel.com>; Marko Kovacevic
> <marko.kovacevic@intel.com>; Ori Kam <orika@mellanox.com>; Bruce
> Richardson <bruce.richardson@intel.com>; Pablo de Lara
> <pablo.de.lara.guarch@intel.com>; Radu Nicolau <radu.nicolau@intel.com>;
> Akhil Goyal <akhil.goyal@nxp.com>; Tomasz Kantecki
> <tomasz.kantecki@intel.com>
> Cc: dev@dpdk.org; Xiaolong Ye <xiaolong.ye@intel.com>
> Subject: [PATCH] examples/flow_filtering: remove out-of-date comment
> 
> Now we've setup both rx and tx queues.
> 
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>  examples/flow_filtering/main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c
> index 09dbbcea9..a0487be77 100644
> --- a/examples/flow_filtering/main.c
> +++ b/examples/flow_filtering/main.c
> @@ -149,7 +149,6 @@ init_port(void)
> 
>  	rxq_conf = dev_info.default_rxconf;
>  	rxq_conf.offloads = port_conf.rxmode.offloads;
> -	/* only set Rx queues: something we care only so far */
>  	for (i = 0; i < nr_queues; i++) {
>  		ret = rte_eth_rx_queue_setup(port_id, i, 512,
>  				     rte_eth_dev_socket_id(port_id),
> --
> 2.17.1

Acked-by: Ori Kam <orika@mellanox.com>
Thanks,
Ori Kam
  
Ferruh Yigit June 28, 2019, 7:03 p.m. UTC | #2
On 6/23/2019 6:22 AM, Ori Kam wrote:
> 
> 
>> -----Original Message-----
>> From: Xiaolong Ye <xiaolong.ye@intel.com>
>> Sent: Tuesday, June 18, 2019 4:46 PM
>> To: Ferruh Yigit <ferruh.yigit@intel.com>; Marko Kovacevic
>> <marko.kovacevic@intel.com>; Ori Kam <orika@mellanox.com>; Bruce
>> Richardson <bruce.richardson@intel.com>; Pablo de Lara
>> <pablo.de.lara.guarch@intel.com>; Radu Nicolau <radu.nicolau@intel.com>;
>> Akhil Goyal <akhil.goyal@nxp.com>; Tomasz Kantecki
>> <tomasz.kantecki@intel.com>
>> Cc: dev@dpdk.org; Xiaolong Ye <xiaolong.ye@intel.com>
>> Subject: [PATCH] examples/flow_filtering: remove out-of-date comment
>>
>> Now we've setup both rx and tx queues.
>>
>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> 
> Acked-by: Ori Kam <orika@mellanox.com>

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/examples/flow_filtering/main.c b/examples/flow_filtering/main.c
index 09dbbcea9..a0487be77 100644
--- a/examples/flow_filtering/main.c
+++ b/examples/flow_filtering/main.c
@@ -149,7 +149,6 @@  init_port(void)
 
 	rxq_conf = dev_info.default_rxconf;
 	rxq_conf.offloads = port_conf.rxmode.offloads;
-	/* only set Rx queues: something we care only so far */
 	for (i = 0; i < nr_queues; i++) {
 		ret = rte_eth_rx_queue_setup(port_id, i, 512,
 				     rte_eth_dev_socket_id(port_id),