From patchwork Mon Jun 10 17:51:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 54627 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8CC681C1A8; Mon, 10 Jun 2019 19:52:11 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id BA82E1C135 for ; Mon, 10 Jun 2019 19:52:04 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id 196so5429647pgc.6 for ; Mon, 10 Jun 2019 10:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1pSTZV4+/Q1KZc07u24BEg4URuj4PrYE5hFyVDmyCkQ=; b=ui6XvEq2HAhl+Mn4ZNUIR0+PIjTJQTGH5YiDNHnIooYkf4S85M75CJy1m2VSGe/vcp m3ybpBb2edBulJ/lkqn4d+KTS/ZyCnEYkFpTRcrNcLvOJBH7B74xsx9YqKJs+YGIJAha IDfb3pVgpAxdtZmf+o2ZIFuP+OnQuc1XzrwdSG92mjgO/ENKesKztFGO887Ti9rsGi5r 8rQnwOmFxmpWgOqHUGMaDmkJ2YclGTiBS/2lazHSV4j9bzGsvl7SUqUDSzzP9wn0tKwp +KivNS7lhNhIQ86wFz9NBidmOyUKkYEQq10ewGFJlzdOGLfvQf8ZFnAC4vmAqDoG9Gvd 1VgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1pSTZV4+/Q1KZc07u24BEg4URuj4PrYE5hFyVDmyCkQ=; b=I3rJj1yQ2uqM1+nOPOn9XQ+JbMg3aX0GuThn8hB+Wrc7H5oz2tYDy6xjMO5uw9pPPv 74OWDz0uXcp+txdjeiXmKmyB2py7V3nxwWeDDjLFFGTSHy5Py8xCvvn0f7LZYkRBOW4h IltqN/fRhVvPtUGnIEvEY4d0P3obMe1ARuX/UllTvZySnBD6SlBdX0GhpzaS+s1xYMr4 rbeFbxZM/GQFkSWHkIrMjIEPV6nvhFX5G4k28qbkkatikFcz5pQdmdXC/IvMLkMmMNYD rRot2PnSh1zjNqvzK1l5N2bO1tz0NkWdoXM0sp18h3nAQp6d6pL9JwSI3K1bQUBGImUA kQfQ== X-Gm-Message-State: APjAAAVIxeHRv5A+hKR6TEwsU9xTF5SwEvleLuwQ1UhM4JARzhx2gEqo A4LvuAMzE6lt+anVdgojA3hFGw== X-Google-Smtp-Source: APXvYqwx7oR1kSuNE+NYh/iojy3je7EKvFpCWpNOthY4Hi5K8VvhX1EaWzchKDa83iKFAdWGTXZ59g== X-Received: by 2002:a63:6105:: with SMTP id v5mr16592270pgb.312.1560189123877; Mon, 10 Jun 2019 10:52:03 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l38sm131656pje.12.2019.06.10.10.52.02 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 10 Jun 2019 10:52:02 -0700 (PDT) From: Stephen Hemminger To: ferruh.yigit@intel.com Cc: dev@dpdk.org, Stephen Hemminger Date: Mon, 10 Jun 2019 10:51:52 -0700 Message-Id: <20190610175155.21374-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190610175155.21374-1-stephen@networkplumber.org> References: <20190610175155.21374-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 4/7] kni: drop unused fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The kni net structure only exists in driver no API/ABI. Several fields were either totally unused or set and never used. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 8 -------- kernel/linux/kni/kni_misc.c | 1 - 2 files changed, 9 deletions(-) diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h index f3a1f60d4bdc..f3e6c3ca4efa 100644 --- a/kernel/linux/kni/kni_dev.h +++ b/kernel/linux/kni/kni_dev.h @@ -39,8 +39,6 @@ struct kni_dev { /* kni list */ struct list_head list; - int status; - uint16_t group_id; /* Group ID of a group of KNI devices */ uint32_t core_id; /* Core ID to bind */ char name[RTE_KNI_NAMESIZE]; /* Network device name */ struct task_struct *pthread; @@ -49,9 +47,6 @@ struct kni_dev { wait_queue_head_t wq; struct mutex sync_lock; - /* PCI device id */ - uint16_t device_id; - /* kni device */ struct net_device *net_dev; @@ -82,9 +77,6 @@ struct kni_dev { /* mbuf size */ uint32_t mbuf_size; - /* synchro for request processing */ - unsigned long synchro; - /* buffers */ void *pa[MBUF_BURST_SZ]; void *va[MBUF_BURST_SZ]; diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c index af18c67c422f..6a206d883c0d 100644 --- a/kernel/linux/kni/kni_misc.c +++ b/kernel/linux/kni/kni_misc.c @@ -346,7 +346,6 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num, kni = netdev_priv(net_dev); kni->net_dev = net_dev; - kni->group_id = dev_info.group_id; kni->core_id = dev_info.core_id; strncpy(kni->name, dev_info.name, RTE_KNI_NAMESIZE);